Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Enhancement]: Allow dropdown options recording for WooCommerce Settings (#38035) 

* Add dropdown recording

* Add changelog

* Fix lint
This commit is contained in:
Fernando Marichal 2023-05-08 12:04:14 -03:00 committed by GitHub
parent c265db936e
commit 7f87c7d1b7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce/changelog/dev-37989_allow_dropdown_recording_for_wc_settings Normal file
View File

@ -0,0 +1,4 @@
Significance: minor
Type: dev
Modify 'WC_Settings_Tracking' to allow dropdown options recording for WooCommerce Settings

31
plugins/woocommerce/includes/tracks/events/class-wc-settings-tracking.php
View File

@ -28,6 +28,21 @@ class WC_Settings_Tracking {
*/
protected $updated_options = array();
/**
* List of option names that are dropdown menus.
*
* @var array
*/
protected $dropdown_menu_options = array();
/**
* List of options that have been modified.
*
* @var array
*/
protected $modified_options = array();
/**
* Toggled options.
*
@ -61,6 +76,10 @@ class WC_Settings_Tracking {
public function add_option_to_list( $option ) {
$this->allowed_options[] = $option['id'];
if ( isset( $option['options'] ) ) {
$this->dropdown_menu_options[] = $option['id'];
}
// Delay attaching this action since it could get fired a lot.
if ( false === has_action( 'update_option', array( $this, 'track_setting_change' ) ) ) {
add_action( 'update_option', array( $this, 'track_setting_change' ), 10, 3 );
@ -91,8 +110,10 @@ class WC_Settings_Tracking {
return;
}
// Check and save toggled options.
if ( in_array( $new_value, array( 'yes', 'no' ), true ) && in_array( $old_value, array( 'yes', 'no' ), true ) ) {
if ( in_array( $option_name, $this->dropdown_menu_options, true ) ) {
$this->modified_options[ $option_name ] = $new_value;
} elseif ( in_array( $new_value, array( 'yes', 'no' ), true ) && in_array( $old_value, array( 'yes', 'no' ), true ) ) {
// Save toggled options.
$option_state = 'yes' === $new_value ? 'enabled' : 'disabled';
$this->toggled_options[ $option_state ][] = $option_name;
}
@ -120,6 +141,12 @@ class WC_Settings_Tracking {
}
}
if ( ! empty( $this->modified_options ) ) {
foreach ( $this->modified_options as $option_name => $selected_option ) {
$properties[ $option_name ] = $selected_option ?? '';
}
}
$properties['tab'] = $current_tab ?? '';
$properties['section'] = $current_section ?? '';