From d4ca34f8ace2daf45f30adfb722503fc842ec39b Mon Sep 17 00:00:00 2001 From: Shiva Poudel Date: Tue, 14 Jun 2016 12:17:35 +0545 Subject: [PATCH 1/2] Prevent on empty section, as we want to check API keys settings page --- includes/admin/class-wc-admin-api-keys.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/includes/admin/class-wc-admin-api-keys.php b/includes/admin/class-wc-admin-api-keys.php index 853579ed3dd..893e2577552 100644 --- a/includes/admin/class-wc-admin-api-keys.php +++ b/includes/admin/class-wc-admin-api-keys.php @@ -26,7 +26,6 @@ class WC_Admin_API_Keys { /** * Check if is API Keys settings page. - * * @return bool */ private function is_api_keys_settings_page() { @@ -35,7 +34,7 @@ class WC_Admin_API_Keys { && isset( $_GET['tab'] ) && 'api' == $_GET['tab'] && isset( $_GET['section'] ) - && 'keys' == isset( $_GET['section'] ); + && 'keys' == $_GET['section']; } /** From 045ef70143e575776acc467eb8837e436fbb9338 Mon Sep 17 00:00:00 2001 From: Mike Jolley Date: Tue, 14 Jun 2016 11:10:13 +0100 Subject: [PATCH 2/2] literal check --- includes/admin/class-wc-admin-api-keys.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/admin/class-wc-admin-api-keys.php b/includes/admin/class-wc-admin-api-keys.php index 893e2577552..77bf52d50b9 100644 --- a/includes/admin/class-wc-admin-api-keys.php +++ b/includes/admin/class-wc-admin-api-keys.php @@ -30,11 +30,11 @@ class WC_Admin_API_Keys { */ private function is_api_keys_settings_page() { return isset( $_GET['page'] ) - && 'wc-settings' == $_GET['page'] + && 'wc-settings' === $_GET['page'] && isset( $_GET['tab'] ) - && 'api' == $_GET['tab'] + && 'api' === $_GET['tab'] && isset( $_GET['section'] ) - && 'keys' == $_GET['section']; + && 'keys' === $_GET['section']; } /**