From 828a2cb038cabce746c154f1957bc31bf63dc56c Mon Sep 17 00:00:00 2001
From: Adrian Duffell <9312929+adrianduffell@users.noreply.github.com>
Date: Fri, 12 Mar 2021 11:58:51 +0800
Subject: [PATCH] Move Lodash to a Peer Dependency in Packages
 (https://github.com/woocommerce/woocommerce-admin/pull/6399)

* Update old versions of lodash in packages

* Add changelog entries

* Move lodash to peerDependencies in components package

* Fix broken JSON

* Fix lodash defined twice in components package

* Move lodash to peer dependency in date package

* Move lodash to peer dependency in navigation package

* Move lodash to peer dependency in notices package

* Relax lodash version constraint in components package

* Update  package changelogs
---
 plugins/woocommerce-admin/packages/components/CHANGELOG.md | 4 ++++
 plugins/woocommerce-admin/packages/components/package.json | 4 +++-
 plugins/woocommerce-admin/packages/date/CHANGELOG.md       | 2 ++
 plugins/woocommerce-admin/packages/date/package.json       | 4 +++-
 plugins/woocommerce-admin/packages/navigation/CHANGELOG.md | 6 ++++++
 plugins/woocommerce-admin/packages/navigation/package.json | 4 +++-
 plugins/woocommerce-admin/packages/notices/CHANGELOG.md    | 4 ++++
 plugins/woocommerce-admin/packages/notices/package.json    | 6 ++++--
 8 files changed, 29 insertions(+), 5 deletions(-)

diff --git a/plugins/woocommerce-admin/packages/components/CHANGELOG.md b/plugins/woocommerce-admin/packages/components/CHANGELOG.md
index 612f4de7124..ca97549bd64 100644
--- a/plugins/woocommerce-admin/packages/components/CHANGELOG.md
+++ b/plugins/woocommerce-admin/packages/components/CHANGELOG.md
@@ -12,6 +12,10 @@
 -   Fixing screen reader text being undefined for report `<Table>`
 -   Update `<SearchListControl />` to use checkbox and radio inputs.
 
+## Breaking changes
+
+-   Move Lodash to a peer dependency.
+
 # 5.1.2
 
 -   Update dependencies.
diff --git a/plugins/woocommerce-admin/packages/components/package.json b/plugins/woocommerce-admin/packages/components/package.json
index 8fd6f52af2a..f18df880a88 100644
--- a/plugins/woocommerce-admin/packages/components/package.json
+++ b/plugins/woocommerce-admin/packages/components/package.json
@@ -49,7 +49,6 @@
 		"emoji-flags": "1.3.0",
 		"gridicons": "3.3.1",
 		"interpolate-components": "1.1.1",
-		"lodash": "4.17.15",
 		"memoize-one": "5.1.1",
 		"moment": "2.29.1",
 		"prop-types": "15.7.2",
@@ -58,6 +57,9 @@
 		"react-router-dom": "5.2.0",
 		"react-transition-group": "4.4.1"
 	},
+	"peerDependencies": {
+		"lodash": "^4.17.0"
+	},
 	"publishConfig": {
 		"access": "public"
 	}
diff --git a/plugins/woocommerce-admin/packages/date/CHANGELOG.md b/plugins/woocommerce-admin/packages/date/CHANGELOG.md
index 317be7986a3..dd330cad150 100644
--- a/plugins/woocommerce-admin/packages/date/CHANGELOG.md
+++ b/plugins/woocommerce-admin/packages/date/CHANGELOG.md
@@ -1,7 +1,9 @@
 # Unreleased
 
 -   Take into account leap year in calculating `getLastPeriod`.
+## Breaking changes
 
+-   Move Lodash to a peer dependency.
 # 2.1.0
 
 -   Update to @wordpress/eslint coding standards.
diff --git a/plugins/woocommerce-admin/packages/date/package.json b/plugins/woocommerce-admin/packages/date/package.json
index 14fc8c8f703..c173284870c 100644
--- a/plugins/woocommerce-admin/packages/date/package.json
+++ b/plugins/woocommerce-admin/packages/date/package.json
@@ -23,9 +23,11 @@
 	"dependencies": {
 		"@wordpress/date": "3.13.0",
 		"@wordpress/i18n": "3.17.0",
-		"lodash": "4.17.15",
 		"moment": "2.29.1"
 	},
+	"peerDependencies": {
+		"lodash": "^4.17.0"
+	},
 	"publishConfig": {
 		"access": "public"
 	}
diff --git a/plugins/woocommerce-admin/packages/navigation/CHANGELOG.md b/plugins/woocommerce-admin/packages/navigation/CHANGELOG.md
index 8f8f639aed4..5732974410c 100644
--- a/plugins/woocommerce-admin/packages/navigation/CHANGELOG.md
+++ b/plugins/woocommerce-admin/packages/navigation/CHANGELOG.md
@@ -1,3 +1,9 @@
+# Unreleased
+
+## Breaking changes
+
+-   Move Lodash to a peer dependency.
+
 # 5.3.0
 
 -   `getQueryExcludedScreens` Return a list of screens that should be excluded from persisted query logic.
diff --git a/plugins/woocommerce-admin/packages/navigation/package.json b/plugins/woocommerce-admin/packages/navigation/package.json
index 88135906789..9d4e42ca63c 100644
--- a/plugins/woocommerce-admin/packages/navigation/package.json
+++ b/plugins/woocommerce-admin/packages/navigation/package.json
@@ -23,9 +23,11 @@
 	"dependencies": {
 		"@woocommerce/experimental": "file:../experimental",
 		"history": "4.10.1",
-		"lodash": "4.17.15",
 		"qs": "6.9.6"
 	},
+	"peerDependencies": {
+		"lodash": "^4.17.0"
+	},
 	"publishConfig": {
 		"access": "public"
 	}
diff --git a/plugins/woocommerce-admin/packages/notices/CHANGELOG.md b/plugins/woocommerce-admin/packages/notices/CHANGELOG.md
index dbe2fad7a0e..0f1da024fe6 100644
--- a/plugins/woocommerce-admin/packages/notices/CHANGELOG.md
+++ b/plugins/woocommerce-admin/packages/notices/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## Breaking changes
+
+-   Move Lodash to a peer dependency.
+
 ## 2.0.0 (2020-02-10)
 
 ### Breaking Change
diff --git a/plugins/woocommerce-admin/packages/notices/package.json b/plugins/woocommerce-admin/packages/notices/package.json
index d1645e9bb35..186476e611c 100644
--- a/plugins/woocommerce-admin/packages/notices/package.json
+++ b/plugins/woocommerce-admin/packages/notices/package.json
@@ -24,8 +24,10 @@
 	"dependencies": {
 		"@babel/runtime": "^7.11.2",
 		"@wordpress/a11y": "^2.13.0",
-		"@wordpress/data": "^4.25.0",
-		"lodash": "^4.17.19"
+		"@wordpress/data": "^4.25.0"
+	},
+	"peerDependencies": {
+		"lodash": "^4.17.0"
 	},
 	"publishConfig": {
 		"access": "public"