From 8bbb14f23b1f9a08f20c1f868d4707b2bce0ac90 Mon Sep 17 00:00:00 2001 From: Luigi Teschio Date: Mon, 12 Dec 2022 10:37:05 +0100 Subject: [PATCH] Add more clarity about the responsibility of reviewing/merging the PR on WC Core during the release process (https://github.com/woocommerce/woocommerce-blocks/pull/7913) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * add more clarity about the responsibility of reviewing/merging the PR on WC Core during the release process * Update .github/release-initial-checklist.md Co-authored-by: Albert Juhé Lluveras Co-authored-by: Albert Juhé Lluveras --- plugins/woocommerce-blocks/.github/patch-initial-checklist.md | 2 +- plugins/woocommerce-blocks/.github/release-initial-checklist.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/woocommerce-blocks/.github/patch-initial-checklist.md b/plugins/woocommerce-blocks/.github/patch-initial-checklist.md index 38252c37360..07f0f51b77f 100644 --- a/plugins/woocommerce-blocks/.github/patch-initial-checklist.md +++ b/plugins/woocommerce-blocks/.github/patch-initial-checklist.md @@ -72,7 +72,7 @@ Each porter is responsible for testing the PRs that fall under the focus of thei ## Pull request in WooCommerce Core for Package update -This only needs done if the patch release needs to be included in WooCommerce Core. +This only needs done if the patch release needs to be included in WooCommerce Core. Reviewing and merging the PR is your team's responsibility, except in the case of `Fix Release Request`. In this case, the WooCommerce release manager reviews and merges the PR. - [ ] Create a pull request for updating the package in WooCommerce core (based off of the WooCommerce core release branch this is deployed for). diff --git a/plugins/woocommerce-blocks/.github/release-initial-checklist.md b/plugins/woocommerce-blocks/.github/release-initial-checklist.md index 612bd70a668..3014219d76e 100644 --- a/plugins/woocommerce-blocks/.github/release-initial-checklist.md +++ b/plugins/woocommerce-blocks/.github/release-initial-checklist.md @@ -97,7 +97,7 @@ Each porter is responsible for testing the PRs that fall under the focus of thei This only needs to be done if this release is the last release of the feature plugin before code freeze in the WooCommerce core cycle. If this condition doesn't exist you can skip this section. - [ ] Remind whoever is porter this week to audit our codebase to ensure this [experimental interface document](https://github.com/woocommerce/woocommerce-blocks/blob/trunk/docs/internal-developers/blocks/feature-flags-and-experimental-interfaces.md) is up to date. See Pca54o-rM-p2 for more details. -- [ ] Create a pull request for updating the package in the [WooCommerce Core Repository](https://github.com/woocommerce/woocommerce/) that [bumps the package version](https://github.com/woocommerce/woocommerce/blob/747cb6b7184ba9fdc875ab104da5839cfda8b4be/plugins/woocommerce/composer.json) for the Woo Blocks package to the version you are releasing. +- [ ] Create a pull request for updating the package in the [WooCommerce Core Repository](https://github.com/woocommerce/woocommerce/) that [bumps the package version](https://github.com/woocommerce/woocommerce/blob/747cb6b7184ba9fdc875ab104da5839cfda8b4be/plugins/woocommerce/composer.json) for the Woo Blocks package to the version you are releasing. Reviewing and merging the PR is your team's responsibility. - The content for the pull release can follow [this example](https://github.com/woocommerce/woocommerce/pull/32627).