* Update dashboard charts to use WP Card

* Fix lint and test errors
This commit is contained in:
Joshua T Flowers 2020-12-21 14:06:41 -05:00 committed by GitHub
parent 6c72ba4994
commit 8d99e637c5
4 changed files with 74 additions and 41 deletions

View File

@ -2,11 +2,17 @@
* External dependencies
*/
import { __ } from '@wordpress/i18n';
import {
Card,
CardBody,
CardHeader,
__experimentalText as Text,
} from '@wordpress/components';
import { Component } from '@wordpress/element';
import { compose } from '@wordpress/compose';
import { EmptyTable, TableCard } from '@woocommerce/components';
import { withSelect } from '@wordpress/data';
import PropTypes from 'prop-types';
import { Card, EmptyTable, TableCard } from '@woocommerce/components';
import { getPersistedQuery } from '@woocommerce/navigation';
import {
getFilterQuery,
@ -63,13 +69,20 @@ export class Leaderboard extends Component {
if ( ! isRequesting && rows.length === 0 ) {
return (
<Card title={ title } className={ classes }>
<Card className={ classes }>
<CardHeader>
<Text variant="title.small" as="h3">
{ title }
</Text>
</CardHeader>
<CardBody size={ null }>
<EmptyTable>
{ __(
'No data recorded for the selected time period.',
'woocommerce-admin'
) }
</EmptyTable>
</CardBody>
</Card>
);
}

View File

@ -255,11 +255,17 @@ exports[`Leaderboard should render correct data in the table 1`] = `
exports[`Leaderboard should render empty message when there are no rows 1`] = `
<div>
<div
class="woocommerce-card woocommerce-leaderboard"
class="components-card is-size-medium woocommerce-leaderboard css-1xs3c37-CardUI e1q7k77g0"
>
<div
class="woocommerce-card__body"
class="components-flex components-card__header is-size-medium e1q7k77g1 css-jsa6v9-Flex-HeaderUI eboqfv50"
>
<h3
class="css-1ahfdc3-Text e15wbhsk0"
/>
</div>
<div
class="components-card__body css-xmjzce-BodyUI e1q7k77g3"
>
<div
class="woocommerce-table is-empty"

View File

@ -4,7 +4,12 @@
import { Component } from '@wordpress/element';
import PropTypes from 'prop-types';
import { __, sprintf } from '@wordpress/i18n';
import { Card } from '@woocommerce/components';
import {
Card,
CardBody,
CardHeader,
__experimentalText as Text,
} from '@wordpress/components';
import {
getHistory,
getNewPath,
@ -53,10 +58,13 @@ class ChartBlock extends Component {
className="woocommerce-dashboard__chart-block-wrapper"
onClick={ this.handleChartClick }
>
<Card
className="woocommerce-dashboard__chart-block woocommerce-analytics__card"
title={ selectedChart.label }
>
<Card className="woocommerce-dashboard__chart-block">
<CardHeader>
<Text variant="title.small" as="h3">
{ selectedChart.label }
</Text>
</CardHeader>
<CardBody size={ null }>
<a
className="screen-reader-text"
href={ getAdminLink(
@ -82,6 +90,7 @@ class ChartBlock extends Component {
showHeaderControls={ false }
filters={ filters }
/>
</CardBody>
</Card>
</div>
);

View File

@ -9,6 +9,11 @@
background: transparent;
}
}
.woocommerce-chart {
margin-top: 0;
margin-bottom: 0;
border: 0;
}
.woocommerce-chart__footer {
position: relative;
&::after {