From 4cf6625f0cae222f49fdc6b79516770c39a82d26 Mon Sep 17 00:00:00 2001 From: roykho Date: Fri, 26 Mar 2021 15:09:43 -0700 Subject: [PATCH 1/2] Prevent saved changes message when leaving page closes #29359 --- assets/js/admin/wc-shipping-zone-methods.js | 1 + 1 file changed, 1 insertion(+) diff --git a/assets/js/admin/wc-shipping-zone-methods.js b/assets/js/admin/wc-shipping-zone-methods.js index 08e4d097d0c..9b0cbe64bfb 100644 --- a/assets/js/admin/wc-shipping-zone-methods.js +++ b/assets/js/admin/wc-shipping-zone-methods.js @@ -62,6 +62,7 @@ shippingMethod.trigger( 'change:methods' ); shippingMethod.changes = {}; shippingMethod.trigger( 'saved:methods' ); + window.onbeforeunload = null; } else { window.alert( data.strings.save_failed ); } From 1234a5a46f4d97091bc43d4bc58aa202b154843d Mon Sep 17 00:00:00 2001 From: roykho Date: Tue, 30 Mar 2021 05:46:36 -0700 Subject: [PATCH 2/2] Add comment for clarity --- assets/js/admin/wc-shipping-zone-methods.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/assets/js/admin/wc-shipping-zone-methods.js b/assets/js/admin/wc-shipping-zone-methods.js index 9b0cbe64bfb..45d17f19d21 100644 --- a/assets/js/admin/wc-shipping-zone-methods.js +++ b/assets/js/admin/wc-shipping-zone-methods.js @@ -62,6 +62,8 @@ shippingMethod.trigger( 'change:methods' ); shippingMethod.changes = {}; shippingMethod.trigger( 'saved:methods' ); + + // Overrides the onbeforeunload callback added by settings.js. window.onbeforeunload = null; } else { window.alert( data.strings.save_failed );