From ef3f48bda65b95b319a017e50878dd38e0ed81a4 Mon Sep 17 00:00:00 2001 From: moon Date: Thu, 28 Apr 2022 11:22:54 -0700 Subject: [PATCH 1/3] Add is_visible --- packages/js/data/src/onboarding/types.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/js/data/src/onboarding/types.ts b/packages/js/data/src/onboarding/types.ts index 01d6a97cf01..5bc46bb1237 100644 --- a/packages/js/data/src/onboarding/types.ts +++ b/packages/js/data/src/onboarding/types.ts @@ -155,4 +155,5 @@ export type Extension = { manage_url: string; name: string; is_built_by_wc: boolean; + is_visible: boolean; }; From 082f55bee10ae5dd856091aedd1b9e2036555e29 Mon Sep 17 00:00:00 2001 From: moon Date: Thu, 28 Apr 2022 13:42:06 -0700 Subject: [PATCH 2/3] Run clean before running build commands --- plugins/woocommerce-admin/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/woocommerce-admin/package.json b/plugins/woocommerce-admin/package.json index f7149f13fde..5adf6e40e5b 100644 --- a/plugins/woocommerce-admin/package.json +++ b/plugins/woocommerce-admin/package.json @@ -11,11 +11,11 @@ "scripts": { "analyze": "cross-env NODE_ENV=production ANALYZE=true webpack", "prebuild": "pnpm run install-if-deps-outdated", - "build": "WC_ADMIN_PHASE=core pnpm run build:feature-config && cross-env NODE_ENV=production WC_ADMIN_PHASE=core webpack", + "build": "WC_ADMIN_PHASE=core pnpm run clean && pnpm run build:packages && pnpm run build:feature-config && cross-env NODE_ENV=production WC_ADMIN_PHASE=core webpack", "build:feature-config": "php ../woocommerce/bin/generate-feature-config.php", "build:packages": "cross-env NODE_ENV=production pnpm run:packages -- build", "clean": "rimraf ../woocommerce/assets/client/admin/* && pnpm run:packages -- clean --parallel", - "client:watch": "cross-env WC_ADMIN_PHASE=development pnpm run build:feature-config && cross-env WC_ADMIN_PHASE=development webpack --watch", + "client:watch": "cross-env WC_ADMIN_PHASE=development && pnpm run clean && pnpm run build:packages && pnpm run build:feature-config && cross-env WC_ADMIN_PHASE=development webpack --watch", "create-hook-reference": "node ./bin/hook-reference/index.js", "create-wc-extension": "node ./bin/starter-pack/starter-pack.js", "predev": "pnpm run -s install-if-deps-outdated", From dc00aff77e2947274874d90cd9450a78289ed7aa Mon Sep 17 00:00:00 2001 From: moon Date: Thu, 28 Apr 2022 14:28:01 -0700 Subject: [PATCH 3/3] Run dev after clean command --- plugins/woocommerce-admin/package.json | 4 ++-- plugins/woocommerce-admin/project.json | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/woocommerce-admin/package.json b/plugins/woocommerce-admin/package.json index 5adf6e40e5b..59336547fc2 100644 --- a/plugins/woocommerce-admin/package.json +++ b/plugins/woocommerce-admin/package.json @@ -11,11 +11,11 @@ "scripts": { "analyze": "cross-env NODE_ENV=production ANALYZE=true webpack", "prebuild": "pnpm run install-if-deps-outdated", - "build": "WC_ADMIN_PHASE=core pnpm run clean && pnpm run build:packages && pnpm run build:feature-config && cross-env NODE_ENV=production WC_ADMIN_PHASE=core webpack", + "build": "pnpm run clean && WC_ADMIN_PHASE=core pnpm run build:packages && WC_ADMIN_PHASE=core pnpm run build:feature-config && cross-env NODE_ENV=production WC_ADMIN_PHASE=core webpack", "build:feature-config": "php ../woocommerce/bin/generate-feature-config.php", "build:packages": "cross-env NODE_ENV=production pnpm run:packages -- build", "clean": "rimraf ../woocommerce/assets/client/admin/* && pnpm run:packages -- clean --parallel", - "client:watch": "cross-env WC_ADMIN_PHASE=development && pnpm run clean && pnpm run build:packages && pnpm run build:feature-config && cross-env WC_ADMIN_PHASE=development webpack --watch", + "client:watch": "cross-env WC_ADMIN_PHASE=development pnpm run build:feature-config && cross-env WC_ADMIN_PHASE=development webpack --watch", "create-hook-reference": "node ./bin/hook-reference/index.js", "create-wc-extension": "node ./bin/starter-pack/starter-pack.js", "predev": "pnpm run -s install-if-deps-outdated", diff --git a/plugins/woocommerce-admin/project.json b/plugins/woocommerce-admin/project.json index 3a2c2b60740..73fec286463 100644 --- a/plugins/woocommerce-admin/project.json +++ b/plugins/woocommerce-admin/project.json @@ -20,6 +20,7 @@ "executor": "@nrwl/workspace:run-commands", "options": { "commands": [ + "WC_ADMIN_PHASE=development pnpm nx clean woocommerce-admin", "WC_ADMIN_PHASE=development pnpm nx dev woocommerce-admin", "pnpm nx watch woocommerce-admin" ],