Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #30889 from woocommerce/fix/25255-variable-product-price-hash 

Include Customer VAT Exemption Status in Variable Product Price Cache Key
This commit is contained in:
Barry Hughes 2021-10-07 16:28:47 -07:00 committed by GitHub
parent 6eb5277597 30e1067864
commit 942d6c8d50
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 78 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
includes/data-stores/class-wc-product-variable-data-store-cpt.php
View File

@ -397,7 +397,16 @@ class WC_Product_Variable_Data_Store_CPT extends WC_Product_Data_Store_CPT imple
protected function get_price_hash( &$product, $for_display = false ) {
global $wp_filter;
$price_hash = $for_display && wc_tax_enabled() ? array( get_option( 'woocommerce_tax_display_shop', 'excl' ), WC_Tax::get_rates() ) : array( false );
$price_hash = array( false );
if ( $for_display && wc_tax_enabled() ) {
$price_hash = array(
get_option( 'woocommerce_tax_display_shop', 'excl' ),
WC_Tax::get_rates(),
empty( WC()->customer ) ? false : WC()->customer->is_vat_exempt(),
);
}
$filter_names = array( 'woocommerce_variation_prices_price', 'woocommerce_variation_prices_regular_price', 'woocommerce_variation_prices_sale_price' );
foreach ( $filter_names as $filter_name ) {

68
tests/php/includes/data-stores/class-wc-product-variable-data-store-cpt-test.php Normal file
View File

@ -0,0 +1,68 @@
<?php
/**
* Class WC_Product_Variable_Data_Store_CPT_Test
*/
class WC_Product_Variable_Data_Store_CPT_Test extends WC_Unit_Test_Case {
/**
* Helper filter to force prices inclusice of tax.
*/
public function __return_incl() {
return 'incl';
}
/**
* @testdox Variation price cache accounts for Customer VAT exemption.
*/
public function test_variation_price_cache_vat_exempt() {
// Set store to include tax in price display.
add_filter( 'wc_tax_enabled', '__return_true' );
add_filter( 'woocommerce_prices_include_tax', '__return_true' );
add_filter( 'pre_option_woocommerce_tax_display_shop', array( $this, '__return_incl' ) );
add_filter( 'pre_option_woocommerce_tax_display_cart', array( $this, '__return_incl' ) );
// Create tax rate.
$tax_id = WC_Tax::_insert_tax_rate(
array(
'tax_rate_country' => '',
'tax_rate_state' => '',
'tax_rate' => '10.0000',
'tax_rate_name' => 'VAT',
'tax_rate_priority' => '1',
'tax_rate_compound' => '0',
'tax_rate_shipping' => '1',
'tax_rate_order' => '1',
'tax_rate_class' => '',
)
);
// Create our variable product.
$product = WC_Helper_Product::create_variation_product();
// Verify that a VAT exempt customer gets prices with tax removed.
WC()->customer->set_is_vat_exempt( true );
$prices_no_tax = array( '9.09', '13.64', '14.55', '15.45', '16.36', '17.27' );
$variation_prices = $product->get_variation_prices( true );
$this->assertEquals( $prices_no_tax, array_values( $variation_prices['price'] ) );
// Verify that a normal customer gets prices with tax included.
// This indirectly proves that the customer's VAT exemption influences the cache key.
WC()->customer->set_is_vat_exempt( false );
$prices_with_tax = array( '10.00', '15.00', '16.00', '17.00', '18.00', '19.00' );
$variation_prices = $product->get_variation_prices( true );
$this->assertEquals( $prices_with_tax, array_values( $variation_prices['price'] ) );
// Clean up.
WC_Tax::_delete_tax_rate( $tax_id );
remove_filter( 'wc_tax_enabled', '__return_true' );
remove_filter( 'woocommerce_prices_include_tax', '__return_true' );
remove_filter( 'pre_option_woocommerce_tax_display_shop', array( $this, '__return_incl' ) );
remove_filter( 'pre_option_woocommerce_tax_display_cart', array( $this, '__return_incl' ) );
}
}