From 98a61d3a4d4d00bdc520e57ec2fedb75f76046a5 Mon Sep 17 00:00:00 2001 From: Luigi Teschio Date: Tue, 11 Jul 2023 15:03:05 +0200 Subject: [PATCH] Enable declaration-block-no-duplicate-properties stylelint rule (https://github.com/woocommerce/woocommerce-blocks/pull/10163) --- plugins/woocommerce-blocks/.stylelintrc.json | 1 - plugins/woocommerce-blocks/assets/css/abstracts/_mixins.scss | 1 - .../assets/js/base/components/price-slider/style.scss | 2 -- .../assets/js/base/components/snackbar-list/style.scss | 1 - .../assets/js/blocks/active-filters/style.scss | 1 - .../assets/js/blocks/product-categories/style.scss | 1 - .../assets/js/editor-components/tag/style.scss | 1 - 7 files changed, 8 deletions(-) diff --git a/plugins/woocommerce-blocks/.stylelintrc.json b/plugins/woocommerce-blocks/.stylelintrc.json index 4cc0427bd73..baee43fc2a8 100644 --- a/plugins/woocommerce-blocks/.stylelintrc.json +++ b/plugins/woocommerce-blocks/.stylelintrc.json @@ -4,7 +4,6 @@ "at-rule-empty-line-before": null, "at-rule-no-unknown": null, "comment-empty-line-before": null, - "declaration-block-no-duplicate-properties": null, "font-weight-notation": null, "max-line-length": null, "no-descending-specificity": null, diff --git a/plugins/woocommerce-blocks/assets/css/abstracts/_mixins.scss b/plugins/woocommerce-blocks/assets/css/abstracts/_mixins.scss index 10bc29f86bc..16aa41a7a3b 100644 --- a/plugins/woocommerce-blocks/assets/css/abstracts/_mixins.scss +++ b/plugins/woocommerce-blocks/assets/css/abstracts/_mixins.scss @@ -92,7 +92,6 @@ $fontSizes: ( word-wrap: normal !important; padding: 0; position: absolute !important; - width: 1px; } @mixin visually-hidden-focus-reveal() { diff --git a/plugins/woocommerce-blocks/assets/js/base/components/price-slider/style.scss b/plugins/woocommerce-blocks/assets/js/base/components/price-slider/style.scss index cc9f2128695..714d23c9fa6 100644 --- a/plugins/woocommerce-blocks/assets/js/base/components/price-slider/style.scss +++ b/plugins/woocommerce-blocks/assets/js/base/components/price-slider/style.scss @@ -169,7 +169,6 @@ width: 100%; height: 0; display: block; - position: relative; pointer-events: none; outline: none !important; position: absolute; @@ -366,7 +365,6 @@ @include ie11() { .wc-block-components-price-slider__range-input-wrapper { border: 0; - height: auto; position: relative; height: 50px; } diff --git a/plugins/woocommerce-blocks/assets/js/base/components/snackbar-list/style.scss b/plugins/woocommerce-blocks/assets/js/base/components/snackbar-list/style.scss index cd3f934e1e4..75b68b8aec8 100644 --- a/plugins/woocommerce-blocks/assets/js/base/components/snackbar-list/style.scss +++ b/plugins/woocommerce-blocks/assets/js/base/components/snackbar-list/style.scss @@ -14,7 +14,6 @@ display: inline-flex; width: auto; max-width: 600px; - margin: 0; pointer-events: all; border: 1px solid transparent; box-shadow: 0 1px 2px rgba(0, 0, 0, 0.1); diff --git a/plugins/woocommerce-blocks/assets/js/blocks/active-filters/style.scss b/plugins/woocommerce-blocks/assets/js/blocks/active-filters/style.scss index 20579b1922e..7bf19b372ee 100644 --- a/plugins/woocommerce-blocks/assets/js/blocks/active-filters/style.scss +++ b/plugins/woocommerce-blocks/assets/js/blocks/active-filters/style.scss @@ -160,7 +160,6 @@ height: 16px; width: 16px; line-height: 16px; - padding: 0; margin: 0 0.5em 0 0; color: currentColor; diff --git a/plugins/woocommerce-blocks/assets/js/blocks/product-categories/style.scss b/plugins/woocommerce-blocks/assets/js/blocks/product-categories/style.scss index 54a4f77a61c..6483e0d2e22 100644 --- a/plugins/woocommerce-blocks/assets/js/blocks/product-categories/style.scss +++ b/plugins/woocommerce-blocks/assets/js/blocks/product-categories/style.scss @@ -31,7 +31,6 @@ margin: 0; margin-right: 0.5em; margin-left: -60px; - position: relative; vertical-align: middle; border: 1px solid #eee; diff --git a/plugins/woocommerce-blocks/assets/js/editor-components/tag/style.scss b/plugins/woocommerce-blocks/assets/js/editor-components/tag/style.scss index d2117e2e34f..5258a069099 100644 --- a/plugins/woocommerce-blocks/assets/js/editor-components/tag/style.scss +++ b/plugins/woocommerce-blocks/assets/js/editor-components/tag/style.scss @@ -29,7 +29,6 @@ .woocommerce-tag__remove { cursor: pointer; - height: inherit; padding: 0 2px; border-radius: 0 12px 12px 0; color: $gray-700;