From 9c242bcc4c28b2c9d06a2985a5f9e4596d7b1eb8 Mon Sep 17 00:00:00 2001 From: jonathansadowski Date: Tue, 12 Jul 2022 16:07:12 -0500 Subject: [PATCH] Update github action to require valid changelog file (#33772) * Update github action to equire valid changelog file * Update github action for changelogger to install depedencies and composer * Make valid changelog files that were invalid --- .github/workflows/pr-lint-monorepo.yml | 10 ++++++++++ plugins/woocommerce/changelog/add-merge-playwright | 2 ++ .../woocommerce/changelog/add-shipping-intro-tooltips | 3 +-- .../changelog/add-shipping-intro-tooltips copy | 3 +-- .../woocommerce/changelog/remove_legacy_image_sizes | 8 ++++---- 5 files changed, 18 insertions(+), 8 deletions(-) diff --git a/.github/workflows/pr-lint-monorepo.yml b/.github/workflows/pr-lint-monorepo.yml index a21f14ef2b3..476c012a2fc 100644 --- a/.github/workflows/pr-lint-monorepo.yml +++ b/.github/workflows/pr-lint-monorepo.yml @@ -21,9 +21,19 @@ jobs: uses: shivammathur/setup-php@v2 with: php-version: '7.4' + tools: composer - name: Check change files are touched for touched projects env: BASE: ${{ github.event.pull_request.base.sha }} HEAD: ${{ github.event.pull_request.head.sha }} run: php tools/monorepo/check-changelogger-use.php --debug "$BASE" "$HEAD" + + - name: Install PNPM + run: npm install -g pnpm@^6.24.2 + + - name: Install dependencies + run: pnpm install + + - name: Run changelog validation + run: pnpm changelog --filter=* -- validate diff --git a/plugins/woocommerce/changelog/add-merge-playwright b/plugins/woocommerce/changelog/add-merge-playwright index f8809fb0193..8f145b35531 100644 --- a/plugins/woocommerce/changelog/add-merge-playwright +++ b/plugins/woocommerce/changelog/add-merge-playwright @@ -1 +1,3 @@ Significance: patch +Type: dev +Comment: A changelog file is not required for this change. diff --git a/plugins/woocommerce/changelog/add-shipping-intro-tooltips b/plugins/woocommerce/changelog/add-shipping-intro-tooltips index 5dd9eda4e88..fc93be0bb03 100644 --- a/plugins/woocommerce/changelog/add-shipping-intro-tooltips +++ b/plugins/woocommerce/changelog/add-shipping-intro-tooltips @@ -1,5 +1,4 @@ Significance: minor Type: add -Comment: Add shipping-smart-defaults intro tooltips - +Add shipping-smart-defaults intro tooltips. diff --git a/plugins/woocommerce/changelog/add-shipping-intro-tooltips copy b/plugins/woocommerce/changelog/add-shipping-intro-tooltips copy index 8eb1b4d332b..91a8c76122d 100644 --- a/plugins/woocommerce/changelog/add-shipping-intro-tooltips copy +++ b/plugins/woocommerce/changelog/add-shipping-intro-tooltips copy @@ -1,5 +1,4 @@ Significance: minor Type: add -Comment: Added partial spotlight floater to shipping smart defaults tour - +Added partial spotlight floater to shipping smart defaults tour. diff --git a/plugins/woocommerce/changelog/remove_legacy_image_sizes b/plugins/woocommerce/changelog/remove_legacy_image_sizes index 669597c9f9c..413cd012045 100644 --- a/plugins/woocommerce/changelog/remove_legacy_image_sizes +++ b/plugins/woocommerce/changelog/remove_legacy_image_sizes @@ -1,4 +1,4 @@ -Significance: minor -Type: update - -Remove legacy image sizes +Significance: minor +Type: update + +Remove legacy image sizes