Remove options to re-enable setup task list after completion (#52146)

* Remove re-eanble setup tasklist option

* Add changelog

* Remove re-eanble setup tasklist option from settings when setup task has previously completed

* Use is_complete check instead

plugins/woocommerce/changelog/update-remove-reenable-setup-tasklist-option

@@ -0,0 +1,4 @@
+Significance: patch
+Type: update
+
+Remove re-eanble setup tasklist option

plugins/woocommerce/client/admin/client/task-lists/setup-task-list/components/task-list-completed-header.tsx

@@ -26,7 +26,6 @@ import HeaderImage from '../assets/completed-celebration-header.svg';
 
 type TaskListCompletedHeaderProps = {
 	hideTasks: () => void;
-	keepTasks: () => void;
 	customerEffortScore: boolean;
 };
 
@@ -47,7 +46,7 @@ function getStoreAgeInWeeks( adminInstallTimestamp: number ) {
 
 export const TaskListCompletedHeader: React.FC<
 	TaskListCompletedHeaderProps
-> = ( { hideTasks, keepTasks, customerEffortScore } ) => {
+> = ( { hideTasks, customerEffortScore } ) => {
 	const { updateOptions } = useDispatch( OPTIONS_STORE_NAME );
 	const [ showCesModal, setShowCesModal ] = useState( false );
 	const [ hasSubmittedScore, setHasSubmittedScore ] = useState( false );
@@ -190,14 +189,6 @@ export const TaskListCompletedHeader: React.FC<
 									) }
 									renderContent={ () => (
 										<div className="woocommerce-task-card__section-controls">
-											<Button
-												onClick={ () => keepTasks() }
-											>
-												{ __(
-													'Show setup task list',
-													'woocommerce'
-												) }
-											</Button>
 											<Button
 												onClick={ () => hideTasks() }
 											>

plugins/woocommerce/client/admin/client/task-lists/setup-task-list/components/task-list-completed.tsx

@@ -12,10 +12,8 @@ import HeaderImage from '../assets/task-list-completed.svg';
 
 export const TaskListCompleted = ( {
 	hideTasks,
-	keepTasks,
 }: {
 	hideTasks: () => void;
-	keepTasks: () => void;
 } ) => {
 	return (
 		<>
@@ -37,10 +35,7 @@ export const TaskListCompleted = ( {
 									'woocommerce'
 								) }
 							</h2>
-							<Button isSecondary onClick={ keepTasks }>
+							<Button variant="primary" onClick={ hideTasks }>
-								{ __( 'Keep list', 'woocommerce' ) }
-							</Button>
-							<Button isPrimary onClick={ hideTasks }>
 								{ __( 'Hide this list', 'woocommerce' ) }
 							</Button>
 						</div>

plugins/woocommerce/client/admin/client/task-lists/setup-task-list/setup-task-list.tsx

@@ -273,14 +273,10 @@ export const SetupTaskList: React.FC< TaskListProps > = ( {
 				{ cesHeader ? (
 					<TaskListCompletedHeader
 						hideTasks={ hideTasks }
-						keepTasks={ keepTasks }
 						customerEffortScore={ true }
 					/>
 				) : (
-					<TaskListCompleted
+					<TaskListCompleted hideTasks={ hideTasks } />
-						hideTasks={ hideTasks }
-						keepTasks={ keepTasks }
-					/>
 				) }
 			</>
 		);

plugins/woocommerce/src/Internal/Admin/Onboarding/OnboardingHelper.php

@@ -83,12 +83,14 @@ class OnboardingHelper {
 			$help_tab['content'] .= '<p>' . __( 'If you need to access the setup wizard again, please click on the button below.', 'woocommerce' ) . '</p>' .
 				'<p><a href="' . wc_admin_url( '&path=/setup-wizard' ) . '" class="button button-primary">' . __( 'Setup wizard', 'woocommerce' ) . '</a></p>';
 
-			$help_tab['content'] .= '<h3>' . __( 'Task List', 'woocommerce' ) . '</h3>';
+			if ( ! $setup_list->is_complete() ) {
-			$help_tab['content'] .= '<p>' . __( 'If you need to enable or disable the task lists, please click on the button below.', 'woocommerce' ) . '</p>' .
+				$help_tab['content'] .= '<h3>' . __( 'Task List', 'woocommerce' ) . '</h3>';
-			( $setup_list->is_hidden()
+				$help_tab['content'] .= '<p>' . __( 'If you need to enable or disable the task lists, please click on the button below.', 'woocommerce' ) . '</p>' .
+				( $setup_list->is_hidden()
 				? '<p><a href="' . wc_admin_url( '&reset_task_list=1' ) . '" class="button button-primary">' . __( 'Enable', 'woocommerce' ) . '</a></p>'
 				: '<p><a href="' . wc_admin_url( '&reset_task_list=0' ) . '" class="button button-primary">' . __( 'Disable', 'woocommerce' ) . '</a></p>'
-			);
+				);
+			}
 		}
 
 		if ( $extended_list ) {