Merge branch 'trunk' into e2e/add-build-to-e2e-core-tests

packages/js/e2e-core-tests/CHANGELOG.md

@@ -1,9 +1,5 @@
 # Unreleased
 
-## Changes
-
-- Removed the node-config dependency
-
 ## Fixed
 - Moved `merchant.login()` out of `beforeAll()` block and into test body for retried runs.
 

packages/js/e2e-core-tests/package.json

@@ -21,6 +21,7 @@
   "dependencies": {
     "@jest/globals": "^26.4.2",
     "@wordpress/deprecated": "^3.2.3",
+    "config": "3.3.3",
     "faker": "^5.1.0"
   },
   "devDependencies": {
@@ -38,8 +39,7 @@
   },
   "peerDependencies": {
     "@woocommerce/api": "^0.2.0",
-    "@woocommerce/e2e-utils": "^0.1.6",
+    "@woocommerce/e2e-utils": "^0.1.6"
-	"@woocommerce/e2e-environment": "^0.2.3"
   },
   "publishConfig": {
     "access": "public"

packages/js/e2e-core-tests/src/specs/activate-and-setup/onboarding-tasklist.test.js

@@ -12,7 +12,7 @@ const {
 /**
  * External dependencies
  */
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 import deprecated from '@wordpress/deprecated';
 const {
 	it,

packages/js/e2e-core-tests/src/specs/api/coupon.test.js

@@ -6,7 +6,7 @@ const { HTTPClientFactory, Coupon } = require( '@woocommerce/api' );
 /**
  * External dependencies
  */
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const { it, describe, beforeAll } = require( '@jest/globals' );
 
 /**

packages/js/e2e-core-tests/src/specs/api/external-product.test.js

@@ -6,7 +6,7 @@ const { HTTPClientFactory, ExternalProduct } = require( '@woocommerce/api' );
 /**
  * External dependencies
  */
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const { it, describe, beforeAll } = require( '@jest/globals' );
 
 /**

packages/js/e2e-core-tests/src/specs/api/grouped-product.test.js

@@ -10,7 +10,7 @@ const {
 /**
  * External dependencies
  */
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const { it, describe, beforeAll } = require( '@jest/globals' );
 
 /**

packages/js/e2e-core-tests/src/specs/api/order.test.js

@@ -6,7 +6,7 @@ const { HTTPClientFactory, Order } = require( '@woocommerce/api' );
 /**
  * External dependencies
  */
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const { it, describe, beforeAll } = require( '@jest/globals' );
 
 /**

packages/js/e2e-core-tests/src/specs/api/telemetry.test.js

@@ -6,7 +6,7 @@ const { HTTPClientFactory } = require( '@woocommerce/api' );
 /**
  * External dependencies
  */
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const { it, describe, beforeAll } = require( '@jest/globals' );
 
 /**

packages/js/e2e-core-tests/src/specs/api/variable-product.test.js

@@ -7,7 +7,7 @@ const { HTTPClientFactory, VariableProduct, ProductVariation } = require( '@wooc
 /**
  * External dependencies
  */
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const {
 	it,
 	describe,

packages/js/e2e-core-tests/src/specs/merchant/wp-admin-order-apply-coupon.test.js

@@ -11,8 +11,8 @@ const {
 	utils,
 } = require( '@woocommerce/e2e-utils' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
-const simpleProductPrice = config.get( 'products.simple.price', '9.99' );
+const simpleProductPrice = config.has('products.simple.price') ? config.get('products.simple.price') : '9.99';
 const discountedPrice = simpleProductPrice - 5.00;
 
 const couponDialogMessage = 'Enter a coupon code to apply. Discounts are applied to line totals, before taxes.';

packages/js/e2e-core-tests/src/specs/merchant/wp-admin-order-customer-payment-page.test.js

@@ -9,9 +9,9 @@ const {
 } = require( '@woocommerce/e2e-utils' );
 
 // TODO create a function for the logic below getConfigSimpleProduct(), see: https://github.com/woocommerce/woocommerce/issues/29072
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const simpleProductName = config.get( 'products.simple.name' );
-const simpleProductPrice = config.get( 'products.simple.price', '9.99' );
+const simpleProductPrice = config.has( 'products.simple.price' ) ? config.get( 'products.simple.price' ) : '9.99';
 
 const runMerchantOrdersCustomerPaymentPage = () => {
 	let orderId;

packages/js/e2e-core-tests/src/specs/merchant/wp-admin-order-emails.test.js

@@ -9,10 +9,10 @@ const {
 	deleteAllEmailLogs,
 } = require( '@woocommerce/e2e-utils' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const customerEmail = config.get( 'addresses.customer.billing.email' );
-const adminEmail = config.get( 'users.admin.email', 'admin@woocommercecoree2etestsuite.com' );
+const adminEmail = config.has( 'users.admin.email' ) ? config.get( 'users.admin.email' )  : 'admin@woocommercecoree2etestsuite.com';
-const storeName = config.get( 'storeName', 'WooCommerce Core E2E Test Suite' );
+const storeName = 'WooCommerce Core E2E Test Suite';
 
 let orderId;
 

packages/js/e2e-core-tests/src/specs/merchant/wp-admin-order-new.test.js

@@ -7,7 +7,7 @@ const {
 	withRestApi,
 	AdminEdit,
 } = require( '@woocommerce/e2e-utils' );
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const {
 	HTTPClientFactory,
 	VariableProduct,

packages/js/e2e-core-tests/src/specs/merchant/wp-admin-order-refund.test.js

@@ -12,8 +12,8 @@ const {
 	clickAndWaitForSelector,
 } = require( '@woocommerce/e2e-utils' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
-const simpleProductPrice = config.get( 'products.simple.price', '9.99' );
+const simpleProductPrice = config.has('products.simple.price') ? config.get('products.simple.price') : '9.99';
 
 const runRefundOrderTest = () => {
 	describe('WooCommerce Orders > Refund an order', () => {

packages/js/e2e-core-tests/src/specs/merchant/wp-admin-order-status-filters.test.js

@@ -1,6 +1,8 @@
 /**
  * Internal dependencies
  */
+const config = require( 'config' );
+
 const {
 	merchant,
 	withRestApi,

packages/js/e2e-core-tests/src/specs/merchant/wp-admin-product-new.test.js

@@ -24,11 +24,11 @@ const {
 	it,
 	describe,
 } = require( '@jest/globals' );
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 
 const VirtualProductName = 'Virtual Product Name';
 const NonVirtualProductName = 'Non-Virtual Product Name';
-const simpleProductPrice = config.get( 'products.simple.price', '9.99' );
+const simpleProductPrice = config.has('products.simple.price') ? config.get('products.simple.price') : '9.99';
 
 const openNewProductAndVerify = async () => {
 	// Go to "add product" page

packages/js/e2e-core-tests/src/specs/merchant/wp-admin-product-search.test.js

@@ -8,9 +8,9 @@ const {
 	createSimpleProduct
 } = require( '@woocommerce/e2e-utils' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const simpleProductName = config.get( 'products.simple.name' );
-const simpleProductPrice = config.get( 'products.simple.price', '9.99' );
+const simpleProductPrice = config.has('products.simple.price') ? config.get('products.simple.price') : '9.99';
 
 const runProductSearchTest = () => {
 	describe('Products > Search and View a product', () => {

packages/js/e2e-core-tests/src/specs/merchant/wp-admin-settings-shipping-zones.test.js

@@ -21,8 +21,8 @@ const {
 	beforeAll,
 } = require( '@jest/globals' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
-const simpleProductPrice = config.get( 'products.simple.price', '9.99' );
+const simpleProductPrice = config.has( 'products.simple.price' ) ? config.get( 'products.simple.price' ) : '9.99';
 const california = 'state:US:CA';
 const sanFranciscoZIP = '94107';
 const shippingZoneNameUS = 'US with Flat rate';

packages/js/e2e-core-tests/src/specs/shopper/front-end-cart-calculate-shipping.test.js

@@ -18,8 +18,8 @@ const {
 	beforeAll,
 } = require( '@jest/globals' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
-const firstProductPrice = config.get( 'products.simple.price', '9.99' );
+const firstProductPrice = config.has( 'products.simple.price' ) ? config.get( 'products.simple.price' ) : '9.99';
 const secondProductPrice = '4.99';
 const fourProductPrice = firstProductPrice * 4;
 var twoProductsPrice = (+firstProductPrice) + (+secondProductPrice);

packages/js/e2e-core-tests/src/specs/shopper/front-end-cart-redirection.test.js

@@ -21,7 +21,7 @@
 	afterAll,
 } = require( '@jest/globals' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const simpleProductName = config.get( 'products.simple.name' );
 
 const runCartRedirectionTest = () => {

packages/js/e2e-core-tests/src/specs/shopper/front-end-cart.test.js

@@ -17,9 +17,9 @@ const {
 	beforeAll,
 } = require( '@jest/globals' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const simpleProductName = config.get( 'products.simple.name' );
-const singleProductPrice = config.get( 'products.simple.price', '9.99' );
+const singleProductPrice = config.has('products.simple.price') ? config.get('products.simple.price') : '9.99';
 const twoProductPrice = singleProductPrice * 2;
 
 const runCartPageTest = () => {

packages/js/e2e-core-tests/src/specs/shopper/front-end-checkout-create-account.test.js

@@ -21,7 +21,7 @@ const {
 	beforeAll,
 } = require( '@jest/globals' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const customerBilling = config.get( 'addresses.customer.billing' );
 
 const runCheckoutCreateAccountTest = () => {

packages/js/e2e-core-tests/src/specs/shopper/front-end-checkout-login-account.test.js

@@ -19,7 +19,7 @@ const {
 	beforeAll,
 } = require( '@jest/globals' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require('config');
 
 const runCheckoutLoginAccountTest = () => {
 	describe('Shopper Checkout Login Account', () => {

packages/js/e2e-core-tests/src/specs/shopper/front-end-checkout.test.js

@@ -9,9 +9,9 @@ const {
 	uiUnblocked,
 } = require( '@woocommerce/e2e-utils' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const simpleProductName = config.get( 'products.simple.name' );
-const singleProductPrice = config.get( 'products.simple.price', '9.99' );
+const singleProductPrice = config.has('products.simple.price') ? config.get('products.simple.price') : '9.99';
 const twoProductPrice = singleProductPrice * 2;
 const threeProductPrice = singleProductPrice * 3;
 const fourProductPrice = singleProductPrice * 4;

packages/js/e2e-core-tests/src/specs/shopper/front-end-my-account-pay-order.test.js

@@ -11,7 +11,7 @@ const {
 
 let simplePostIdValue;
 let orderNum;
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const simpleProductName = config.get( 'products.simple.name' );
 
 const runMyAccountPayOrderTest = () => {

packages/js/e2e-core-tests/src/specs/shopper/front-end-order-email-receiving.test.js

@@ -12,7 +12,7 @@
 
 let simplePostIdValue;
 let orderId;
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const simpleProductName = config.get( 'products.simple.name' );
 const customerEmail = config.get( 'addresses.customer.billing.email' );
 const storeName = 'WooCommerce Core E2E Test Suite';

packages/js/e2e-core-tests/src/specs/shopper/front-end-product-browse-search-sort.test.js

@@ -17,11 +17,11 @@ const {
 	beforeAll,
 } = require( '@jest/globals' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const simpleProductName = config.get( 'products.simple.name' );
-const singleProductPrice = config.get( 'products.simple.price', '9.99' );
+const singleProductPrice = config.has('products.simple.price') ? config.get('products.simple.price') : '9.99';
-const singleProductPrice2 = '1' + singleProductPrice;
+const singleProductPrice2 = config.has('products.simple.price') ? '1' + singleProductPrice : '19.99';
-const singleProductPrice3 = '2' + singleProductPrice;
+const singleProductPrice3 = config.has('products.simple.price') ? '2' + singleProductPrice : '29.99';
 const clothing = 'Clothing';
 const audio = 'Audio';
 const hardware = 'Hardware';

packages/js/e2e-core-tests/src/specs/shopper/front-end-single-product.test.js

@@ -9,7 +9,7 @@ const {
 	uiUnblocked
 } = require( '@woocommerce/e2e-utils' );
 
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 
 // Variables for simple product
 const simpleProductName = config.get( 'products.simple.name' );
@@ -20,7 +20,7 @@ const defaultVariableProduct = config.get( 'products.variable' );
 let variableProductId;
 
 // Variables for grouped product
-const simpleProductPrice = config.get( 'products.simple.price', '9.99' );
+const simpleProductPrice = config.has('products.simple.price') ? config.get('products.simple.price') : '9.99';
 const simple1 = {
 	name: simpleProductName + ' 1',
 	regularPrice: simpleProductPrice

packages/js/e2e-core-tests/src/specs/shopper/front-end-variable-product-updates.test.js

@@ -6,7 +6,7 @@ const {
 	shopper,
 	createVariableProduct,
 } = require( '@woocommerce/e2e-utils' );
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require('config');
 
 let variablePostIdValue;
 

packages/js/e2e-environment/CHANGELOG.md

@@ -1,11 +1,5 @@
 # Unreleased
 
-
-## Added
-
-- Added a `config` export to the `@woocommerce/e2e-environment` package that has all data and methods of the [config](https://github.com/lorenwest/node-config) package
-  - it provides its own `get()` method that accepts an optional default parameter to be used if the property is not found in the config file.
-  
 ## Added
 
 - Added `post-results-to-github-pr.js` to post smoke test results to a GitHub PR.

packages/js/e2e-environment/README.md

@@ -98,22 +98,6 @@ The E2E environment has the following methods to let us control Jest's overall b
 E2E_RETRY_TIMES=2 pnpx wc-e2e test:e2e
 ```
 
-### Default Environment Configurations
-
-The E2E environment exports a config object which provides all the functionality of the [config](https://www.npmjs.com/package/config) package along with extending the `get` method to accept an optional second argument that will be used if the property is not found in the config file.
-
-```js
-const { config } = require( '@woocommerce/e2e-environment' );
-
-// 'users.admin.email' doesn't exist
-const adminEmail = config.get( 'users.admin.email', 'admin@woocommercecoree2etestsuite.com' );
-
-console.log( adminEmail );
-// admin@woocommercecoree2etestsuite.com
-```
-
-**Note**: If the default parameter is not found and no optional parameter is provided, an error will be thrown.
-
 #### Test Screenshots
 
 The test sequencer provides a screenshot function for test failures. To enable screenshots on test failure use

packages/js/e2e-environment/config/config.js

@@ -1,32 +0,0 @@
-/**
- * External Dependencies
- */
-const config = require( 'config' );
-
-/**
- * Since the 'config' object is not extensible, we create an empty 'e2eConfig' object and map
- * its prototype to the 'config' object. This allows us to extend the new 'e2eConfig' object
- * while still having access to all the data and methods of 'config'
- */
-const e2eConfig = Object.create( config );
-
-/**
- *
- * @param property { string } - the property to be fetched from the config file
- * @param defaultValue { string | number | boolean | null } - default value if 'property' is not found
- * @returns { string | number | boolean }
- * @throws Error
- */
-e2eConfig.get = ( property, defaultValue = null ) => {
-	if ( config.has( property ) ) {
-		return config.get( property );
-	} else if ( defaultValue ) {
-		return defaultValue;
-	}
-
-	throw new Error(
-		`Configuration property "${ property }" is not defined and no defaultValue has been provided`
-	);
-};
-
-module.exports = e2eConfig;

packages/js/e2e-environment/config/index.js

@@ -1,7 +1,6 @@
 /**
  * Internal dependencies
  */
-const config = require('./config');
 const jestConfig = require( './jest.config' );
 const jestPuppeteerConfig = require( './jest-puppeteer.config' );
 const jestobjectConfig = require('./jest-object.config');
@@ -13,7 +12,6 @@ const {
 } = require( './use-config' );
 
 module.exports = {
-	config,
 	jestConfig,
 	...jestobjectConfig,
 	jestPuppeteerConfig,

packages/js/e2e-utils/CHANGELOG.md

@@ -1,9 +1,4 @@
 # Unreleased
-## Changes
-
-- Removed node-config dependency
-- Added @woocommerce/e2e-environment peerDependency
-- Updated the package to use the custom node-config object from @woocommerce/e2e-environment
 
 ## Fixed
 

packages/js/e2e-utils/package.json

@@ -14,6 +14,7 @@
     "@automattic/puppeteer-utils": "github:Automattic/puppeteer-utils#0f3ec50",
     "@wordpress/deprecated": "^3.2.3",
     "@wordpress/e2e-test-utils": "^4.16.1",
+    "config": "3.3.3",
     "faker": "^5.1.0",
     "fishery": "^1.2.0"
   },
@@ -34,8 +35,7 @@
     "eslint": "^8.1.0"
   },
   "peerDependencies": {
-    "@woocommerce/api": "^0.2.0",
+    "@woocommerce/api": "^0.2.0"
-	"@woocommerce/e2e-environment": "^0.2.3"
   },
   "publishConfig": {
     "access": "public"

packages/js/e2e-utils/src/factories.js

@@ -1,5 +1,5 @@
 import { HTTPClientFactory } from '@woocommerce/api';
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 import { simpleProductFactory } from './factories/simple-product';
 import { variableProductFactory } from './factories/variable-product';
 import { variationFactory } from './factories/variation';

packages/js/e2e-utils/src/flows/constants.js

@@ -1,7 +1,7 @@
 /**
  * External dependencies
  */
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 const baseUrl = config.get( 'url' );
 
 /**

packages/js/e2e-utils/src/flows/merchant.js

@@ -1,7 +1,7 @@
 /**
  * External dependencies
  */
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 
 /**
  * Internal dependencies
@@ -440,9 +440,10 @@ const merchant = {
 	 */
 	collapseAdminMenu: async ( collapse = true ) => {
 		const collapseButton = await page.$( '.folded #collapse-button' );
-		if ( ( ! collapse ) == collapseButton ) {
+		if ( ( ! collapseButton ) == collapse ) {
 			await collapseButton.click();
 		}
+
 	},
 };
 

packages/js/e2e-utils/src/flows/shopper.js

@@ -2,7 +2,7 @@
  * External dependencies
  */
 const { pressKeyWithModifier } = require( '@wordpress/e2e-test-utils' );
-const { config } = require( '@woocommerce/e2e-environment' );
+const config = require( 'config' );
 
 /**
  * Internal dependencies

plugins/woocommerce/composer.json

@@ -39,6 +39,11 @@
 		"sort-packages": true,
 		"platform": {
 			"php": "7.0.33"
+		},
+		"allow-plugins": {
+			"automattic/jetpack-autoloader": true,
+			"composer/installers": true,
+			"bamarni/composer-bin-plugin": true
 		}
 	},
 	"autoload": {

plugins/woocommerce/legacy/js/frontend/checkout.js

@@ -579,7 +579,7 @@ jQuery( function( $ ) {
 			var scrollElement           = $( '.woocommerce-NoticeGroup-updateOrderReview, .woocommerce-NoticeGroup-checkout' );
 
 			if ( ! scrollElement.length ) {
-				scrollElement = $( '.form.checkout' );
+				scrollElement = $( 'form.checkout' );
 			}
 			$.scroll_to_notices( scrollElement );
 		}

plugins/woocommerce/legacy/project.json

@@ -9,7 +9,7 @@
 			"options": {
 				"commands": [
 					{
-						"command": "grunt assets",
+						"command": "pnpx grunt assets",
 						"forwardAllArgs": false
 					}
 				],
@@ -25,11 +25,11 @@
 			"options": {
 				"commands": [
 					{
-						"command": "grunt eslint",
+						"command": "pnpx grunt eslint",
 						"forwardAllArgs": false
 					},
 					{
-						"command": "grunt stylelint",
+						"command": "pnpx grunt stylelint",
 						"forwardAllArgs": false
 					}
 				],

plugins/woocommerce/project.json

@@ -53,7 +53,7 @@
 		"build-watch": {
 			"executor": "@nrwl/workspace:run-commands",
 			"options": {
-				"command": "grunt watch",
+				"command": "pnpx grunt watch",
 				"cwd": "plugins/woocommerce/legacy"
 			}
 		},

pnpm-lock.yaml

@@ -113,10 +113,12 @@ importers:
       '@wordpress/babel-preset-default': 3.0.2
       '@wordpress/browserslist-config': ^4.1.0
       '@wordpress/deprecated': ^3.2.3
+      config: 3.3.3
       faker: ^5.1.0
     dependencies:
       '@jest/globals': 26.6.2
       '@wordpress/deprecated': 3.2.3
+      config: 3.3.3
       faker: 5.5.3
     devDependencies:
       '@babel/cli': 7.12.8_@babel+core@7.12.9
@@ -216,6 +218,7 @@ importers:
       '@wordpress/browserslist-config': ^4.1.0
       '@wordpress/deprecated': ^3.2.3
       '@wordpress/e2e-test-utils': ^4.16.1
+      config: 3.3.3
       eslint: ^8.1.0
       faker: ^5.1.0
       fishery: ^1.2.0
@@ -223,6 +226,7 @@ importers:
       '@automattic/puppeteer-utils': github.com/Automattic/puppeteer-utils/0f3ec50
       '@wordpress/deprecated': 3.2.3
       '@wordpress/e2e-test-utils': 4.16.1_jest@27.3.1
+      config: 3.3.3
       faker: 5.5.3
       fishery: 1.4.0
     devDependencies:
@@ -7568,7 +7572,6 @@ packages:
     engines: {node: '>= 6.0.0'}
     dependencies:
       json5: 2.2.0
-    dev: true
 
   /config/3.3.6:
     resolution: {integrity: sha512-Hj5916C5HFawjYJat1epbyY2PlAgLpBtDUlr0MxGLgo3p5+7kylyvnRY18PqJHgnNWXcdd0eWDemT7eYWuFgwg==}