From 2a1ed2c1cb3cdf189e53fcab5be8f865a0ad7469 Mon Sep 17 00:00:00 2001 From: Jeremy Pry Date: Fri, 8 Jun 2018 11:31:45 -0400 Subject: [PATCH 1/2] Update the WP Coding Standards link --- .github/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 428be401e17..9e38b6e1160 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -44,7 +44,7 @@ https://woocommerce.com/contact-us/ ## Coding Guidelines -- **Ensure you stick to the [WordPress Coding Standards](https://make.wordpress.org/core/handbook/coding-standards/php/)** +- **Ensure you stick to the [WordPress Coding Standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/)** - Install our pre-commit hook using composer. It'll help with the Coding Standards. To install run `composer install` from the command line within the woocommerce plugin directory. - Ensure you use LF line endings in your code editor. Use [EditorConfig](http://editorconfig.org/) if your editor supports it so that indentation, line endings and other settings are auto configured. - When committing, reference your issue number (#1234) and include a note about the fix. From 2346183501699affd945e7bd1bc2f43701d7d993 Mon Sep 17 00:00:00 2001 From: Jeremy Pry Date: Fri, 8 Jun 2018 13:23:58 -0400 Subject: [PATCH 2/2] Include explicit mention of PHP 5.2 requirements --- .github/CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 9e38b6e1160..4491e491985 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -48,6 +48,7 @@ https://woocommerce.com/contact-us/ - Install our pre-commit hook using composer. It'll help with the Coding Standards. To install run `composer install` from the command line within the woocommerce plugin directory. - Ensure you use LF line endings in your code editor. Use [EditorConfig](http://editorconfig.org/) if your editor supports it so that indentation, line endings and other settings are auto configured. - When committing, reference your issue number (#1234) and include a note about the fix. +- Ensure that your code is compatible with PHP 5.2+. - Push the changes to your fork and submit a pull request on the master branch of the WooCommerce repository. Existing maintenance branches will be maintained by WooCommerce developers. Please **don't** modify the changelog or update the .pot files. These will be maintained by the WooCommerce team.