Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

has_meta -> meta_exists 

#13590

Avoid has_meta conflict with old method.

#13581
This commit is contained in:
Mike Jolley 2017-03-14 16:49:13 +00:00
parent 1740f1e3e8
commit a3cc5cc9bb
3 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
includes/abstracts/abstract-wc-data.php
View File

@ -263,7 +263,7 @@ abstract class WC_Data {
* @param string $key
* @return boolean
*/
public function has_meta( $key = '' ) {
public function meta_exists( $key = '' ) {
$this->maybe_read_meta_data();
$array_keys = wp_list_pluck( $this->get_meta_data(), 'key' );
return in_array( $key, $array_keys );

8
includes/legacy/abstract-wc-legacy-order.php
View File

@ -462,13 +462,9 @@ abstract class WC_Abstract_Legacy_Order extends WC_Data {
* version and should be removed in future versions.
*
* @deprecated
* @return boolean|array of meta data.
* @return array of meta data.
*/
public function has_meta( $key = '' ) {
if ( ! is_numeric( $key ) ) {
return parent::has_meta( $key );
}
public function has_meta( $order_item_id ) {
global $wpdb;
wc_deprecated_function( 'WC_Order::has_meta( $order_item_id )', '2.7', 'WC_Order_item::get_meta_data' );

6
tests/unit-tests/crud/data.php
View File

@ -132,9 +132,9 @@ class WC_Tests_CRUD_Data extends WC_Unit_Test_Case {
$object->save_meta_data();
$object = new WC_Mock_WC_Data( $object_id );
$this->assertTrue( $object->has_meta( 'test_meta_key' ) );
$this->assertTrue( $object->has_meta( 'test_multi_meta_key' ) );
$this->assertFalse( $object->has_meta( 'thiskeyisnothere' ) );
$this->assertTrue( $object->meta_exists( 'test_meta_key' ) );
$this->assertTrue( $object->meta_exists( 'test_multi_meta_key' ) );
$this->assertFalse( $object->meta_exists( 'thiskeyisnothere' ) );
}
/**