Merge pull request woocommerce/woocommerce-admin#1119 from woocommerce/fix/1115-number-filter-uncontrolled-warning

Fix “uncontrolled input” warning in NumberFilter component.
2018-12-18 16:34:39 -07:00 · 2018-12-18 16:34:39 -07:00 · a96272a5fe
parent 6f773e7537 92c96b834e
commit a96272a5fe
1 changed files with 3 additions and 3 deletions
--- a/plugins/woocommerce-admin/packages/components/src/filters/advanced/number-filter.js
+++ b/plugins/woocommerce-admin/packages/components/src/filters/advanced/number-filter.js
@ -67,14 +67,14 @@ class NumberFilter extends Component {
 					suffix={ <span dangerouslySetInnerHTML={ { __html: currencySymbol } } /> }
 					className="woocommerce-filters-advanced__input"
 					type="number"
-					value={ value }
+					value={ value || '' }
 					onChange={ onChange }
 				/>
 				: <TextControlWithAffixes
 					prefix={ <span dangerouslySetInnerHTML={ { __html: currencySymbol } } /> }
 					className="woocommerce-filters-advanced__input"
 					type="number"
-					value={ value }
+					value={ value || '' }
 					onChange={ onChange }
 				/>
 			);
@ -84,7 +84,7 @@ class NumberFilter extends Component {
 			<TextControl
 				className="woocommerce-filters-advanced__input"
 				type="number"
-				value={ value }
+				value={ value || '' }
 				onChange={ onChange }
 			/>
 		);