Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request woocommerce/woocommerce-admin#1119 from woocommerce/fix/1115-number-filter-uncontrolled-warning 

Fix “uncontrolled input” warning in NumberFilter component.
This commit is contained in:
Jeff Stieler 2018-12-18 16:34:39 -07:00 committed by GitHub
parent 6f773e7537 92c96b834e
commit a96272a5fe
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/woocommerce-admin/packages/components/src/filters/advanced/number-filter.js
View File

@ -67,14 +67,14 @@ class NumberFilter extends Component {
suffix={ <span dangerouslySetInnerHTML={ { __html: currencySymbol } } /> } suffix={ <span dangerouslySetInnerHTML={ { __html: currencySymbol } } /> }
className="woocommerce-filters-advanced__input" className="woocommerce-filters-advanced__input"
type="number" type="number"
value={ value } value={ value || '' }
onChange={ onChange } onChange={ onChange }
/> />
: <TextControlWithAffixes : <TextControlWithAffixes
prefix={ <span dangerouslySetInnerHTML={ { __html: currencySymbol } } /> } prefix={ <span dangerouslySetInnerHTML={ { __html: currencySymbol } } /> }
className="woocommerce-filters-advanced__input" className="woocommerce-filters-advanced__input"
type="number" type="number"
value={ value } value={ value || '' }
onChange={ onChange } onChange={ onChange }
/> />
); );
@ -84,7 +84,7 @@ class NumberFilter extends Component {
<TextControl <TextControl
className="woocommerce-filters-advanced__input" className="woocommerce-filters-advanced__input"
type="number" type="number"
value={ value } value={ value || '' }
onChange={ onChange } onChange={ onChange }
/> />
); );