Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[REST API] Return empty result when there is no on_sale products 

This forces return an empty array as result when using `on_sale=true`.

By default `WP_Query` will return all results when `post__in` is equal
to `array()`, so changing to `array( 0 )` will force the expected
behavior.

Closes #16933
This commit is contained in:
Claudio Sanches 2017-09-26 14:02:33 -03:00
parent 500ff22270
commit ab1b100a36
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
includes/api/class-wc-rest-products-controller.php
View File

@ -281,8 +281,13 @@ class WC_REST_Products_Controller extends WC_REST_Legacy_Products_Controller {
// Filter by on sale products. // Filter by on sale products.
if ( is_bool( $request['on_sale'] ) ) { if ( is_bool( $request['on_sale'] ) ) {
$on_sale_key = $request['on_sale'] ? 'post__in' : 'post__not_in'; $on_sale_key = $request['on_sale'] ? 'post__in' : 'post__not_in';
$args[ $on_sale_key ] += wc_get_product_ids_on_sale(); $on_sale_ids = wc_get_product_ids_on_sale();
// Use 0 when there's no on sale products to avoid return all products.
$on_sale_ids = empty( $on_sale_ids ) ? array( 0 ) : $on_sale_ids;
$args[ $on_sale_key ] += $on_sale_ids;
} }
// Force the post_type argument, since it's not a user input variable. // Force the post_type argument, since it's not a user input variable.