Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add more comments to admin webpacks config & simplify the logic

This commit is contained in:
Chi-Hsuan Huang 2022-04-15 12:08:59 +08:00
parent adda46cc7b
commit ac95d54669
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
plugins/woocommerce-admin/webpack.config.js
View File

@ -58,6 +58,7 @@ wpAdminScripts.forEach( ( name ) => {
entryPoints[ name ] = `./client/wp-admin-scripts/${ name }`; entryPoints[ name ] = `./client/wp-admin-scripts/${ name }`;
} ); } );
// WordPress.org’s translation infrastructure ignores files named “.min.js” so we need to name our JS files without min when releasing the plugin.
const suffix = WC_ADMIN_PHASE === 'core' ? '' : '.min'; const suffix = WC_ADMIN_PHASE === 'core' ? '' : '.min';
const webpackConfig = { const webpackConfig = {
@ -181,10 +182,9 @@ const webpackConfig = {
// TODO: Partially replace with __webpack_get_script_filename__ in app with Webpack 5.x. // TODO: Partially replace with __webpack_get_script_filename__ in app with Webpack 5.x.
// The CSS chunk portion will need to remain, as it originates in MiniCssExtractPlugin. // The CSS chunk portion will need to remain, as it originates in MiniCssExtractPlugin.
new AsyncChunkSrcVersionParameterPlugin(), new AsyncChunkSrcVersionParameterPlugin(),
// Generate unminified files to load the unminified version when `define( 'SCRIPT_DEBUG', true );` is set in wp-config. // We only want to generate unminified files in the development phase.
// This is also required to publish human readeable code in the deployed "plugin". WC_ADMIN_PHASE === 'development' &&
// See https://developer.wordpress.org/plugins/wordpress-org/detailed-plugin-guidelines/#4-code-must-be-mostly-human-readable // Generate unminified files to load the unminified version when `define( 'SCRIPT_DEBUG', true );` is set in wp-config.
WC_ADMIN_PHASE !== 'core' &&
new UnminifyWebpackPlugin( { new UnminifyWebpackPlugin( {
test: /\.js($|\?)/i, test: /\.js($|\?)/i,
mainEntry: 'app/index.min.js', mainEntry: 'app/index.min.js',
@ -200,7 +200,11 @@ const webpackConfig = {
}, },
}; };
if ( webpackConfig.mode !== 'production' && WC_ADMIN_PHASE !== 'core' ) { // Use the source map if we're in development mode, .
if (
webpackConfig.mode === 'development' ||
WC_ADMIN_PHASE === 'development'
) {
webpackConfig.devtool = process.env.SOURCEMAP || 'source-map'; webpackConfig.devtool = process.env.SOURCEMAP || 'source-map';
} }