Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove `isExperimentalBuild` Checks in Classic Template Block (https://github.com/woocommerce/woocommerce-blocks/pull/8902) 

* Remove isExperimentalBuild checks.

By removing the `isExperimentalBuild` conditional checks in the Classic
Template block, we can ensure the features added in woocommerce/woocommerce-blocks#8324 will land in
WooCommerce Core and are not limited to the feature plugin.

See p1680000654295729-slack-C02UBB1EPEF for additional context.

* Revert isExperimentalBuild removal on registration

The conditional `isExperimentalBuild` conditional check that was
wrapping some conditional registration of the classic template
block seems to be  unrelated to the template conversion/migration.

This is something we can revisit and test separately but should not be
included in this changeset.
This commit is contained in:
Daniel W. Robert 2023-03-30 08:47:02 -04:00 committed by GitHub
parent 9c15276488
commit ae012817cc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/woocommerce-blocks/assets/js/blocks/classic-template/index.tsx
View File

@ -89,7 +89,7 @@ const Edit = ( {
getButtonLabel, getButtonLabel,
} = conversionConfig[ templateType ]; } = conversionConfig[ templateType ];
const canConvert = isExperimentalBuild() && isConversionPossible(); const canConvert = isConversionPossible();
const placeholderDescription = getDescription( templateTitle, canConvert ); const placeholderDescription = getDescription( templateTitle, canConvert );
return ( return (