From b74bd01ca1d300a1dd5ad06f236e5ff0e0bd7578 Mon Sep 17 00:00:00 2001
From: RJ <27843274+rjchow@users.noreply.github.com>
Date: Tue, 6 Aug 2024 20:20:45 +0800
Subject: [PATCH] fix: remove defaultProps in prep for react 19 (#50266)

---
 ...-remove-functional-component-default-props |  4 +++
 packages/js/components/src/calendar/input.js  | 18 +++-------
 packages/js/components/src/date/index.js      | 13 ++++---
 packages/js/components/src/summary/index.js   | 10 +++---
 packages/js/components/src/summary/number.js  | 24 ++++---------
 packages/js/components/src/timeline/index.js  | 24 ++++++-------
 .../components/src/timeline/timeline-group.js | 17 ++++-----
 .../components/src/timeline/timeline-item.js  |  9 +----
 .../js/components/src/view-more-list/index.js |  6 +---
 .../client/activity-panel/activity-panel.js   |  6 +---
 .../client/activity-panel/panels/help.js      | 19 +++++-----
 .../components/report-table/index.js          | 36 +++++++------------
 .../homescreen/activity-panel/orders/index.js |  9 -----
 .../marketing/coupons/knowledge-base/index.js | 15 +++-----
 .../coupons/recommended-extensions/index.js   | 15 +++-----
 .../products-control/index.js                 | 15 +++-----
 ...-remove-functional-component-default-props |  4 +++
 17 files changed, 86 insertions(+), 158 deletions(-)
 create mode 100644 packages/js/components/changelog/50266-fix-remove-functional-component-default-props
 create mode 100644 plugins/woocommerce/changelog/50266-fix-remove-functional-component-default-props

diff --git a/packages/js/components/changelog/50266-fix-remove-functional-component-default-props b/packages/js/components/changelog/50266-fix-remove-functional-component-default-props
new file mode 100644
index 00000000000..6e876bf13d2
--- /dev/null
+++ b/packages/js/components/changelog/50266-fix-remove-functional-component-default-props
@@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Removed defaultProps from React functional components since they will be deprecated for React 19
\ No newline at end of file
diff --git a/packages/js/components/src/calendar/input.js b/packages/js/components/src/calendar/input.js
index 1b3c433dd18..049b529954b 100644
--- a/packages/js/components/src/calendar/input.js
+++ b/packages/js/components/src/calendar/input.js
@@ -9,17 +9,17 @@ import { uniqueId, noop } from 'lodash';
 import PropTypes from 'prop-types';
 
 const DateInput = ( {
-	disabled,
+	disabled = false,
 	value,
 	onChange,
 	dateFormat,
 	label,
 	describedBy,
 	error,
-	onFocus,
-	onBlur,
-	onKeyDown,
-	errorPosition,
+	onFocus = () => {},
+	onBlur = () => {},
+	onKeyDown = noop,
+	errorPosition = 'bottom center',
 } ) => {
 	const classes = classnames( 'woocommerce-calendar__input', {
 		'is-empty': value.length === 0,
@@ -73,12 +73,4 @@ DateInput.propTypes = {
 	onKeyDown: PropTypes.func,
 };
 
-DateInput.defaultProps = {
-	disabled: false,
-	onFocus: () => {},
-	onBlur: () => {},
-	errorPosition: 'bottom center',
-	onKeyDown: noop,
-};
-
 export default DateInput;
diff --git a/packages/js/components/src/date/index.js b/packages/js/components/src/date/index.js
index e67a986039f..281d54ed538 100644
--- a/packages/js/components/src/date/index.js
+++ b/packages/js/components/src/date/index.js
@@ -15,7 +15,12 @@ import { createElement } from '@wordpress/element';
  * @param {string} props.visibleFormat
  * @return {Object} -
  */
-const Date = ( { date, machineFormat, screenReaderFormat, visibleFormat } ) => {
+const Date = ( {
+	date,
+	machineFormat = 'Y-m-d H:i:s',
+	screenReaderFormat = 'F j, Y',
+	visibleFormat = 'Y-m-d',
+} ) => {
 	return (
 		<time dateTime={ formatDate( machineFormat, date ) }>
 			<span aria-hidden="true">
@@ -48,10 +53,4 @@ Date.propTypes = {
 	visibleFormat: PropTypes.string,
 };
 
-Date.defaultProps = {
-	machineFormat: 'Y-m-d H:i:s',
-	screenReaderFormat: 'F j, Y',
-	visibleFormat: 'Y-m-d',
-};
-
 export default Date;
diff --git a/packages/js/components/src/summary/index.js b/packages/js/components/src/summary/index.js
index 9f035ba76f5..fece5465636 100644
--- a/packages/js/components/src/summary/index.js
+++ b/packages/js/components/src/summary/index.js
@@ -22,7 +22,11 @@ import Menu from './menu';
  * @param {string} props.label
  * @return {Object} -
  */
-const SummaryList = ( { children, isDropdownBreakpoint, label } ) => {
+const SummaryList = ( {
+	children,
+	isDropdownBreakpoint,
+	label = __( 'Performance Indicators', 'woocommerce' ),
+} ) => {
 	const items = children( {} );
 	// We default to "one" because we can't have empty children.
 	const itemCount = Children.count( items ) || 1;
@@ -79,10 +83,6 @@ SummaryList.propTypes = {
 	label: PropTypes.string,
 };
 
-SummaryList.defaultProps = {
-	label: __( 'Performance Indicators', 'woocommerce' ),
-};
-
 export default withViewportMatch( {
 	isDropdownBreakpoint: '< large',
 } )( SummaryList );
diff --git a/packages/js/components/src/summary/number.js b/packages/js/components/src/summary/number.js
index 4802dcb2f7f..8c1243311f8 100644
--- a/packages/js/components/src/summary/number.js
+++ b/packages/js/components/src/summary/number.js
@@ -39,18 +39,18 @@ import { Text } from '../experimental';
 const SummaryNumber = ( {
 	children,
 	delta,
-	href,
-	hrefType,
-	isOpen,
+	href = '',
+	hrefType = 'wc-admin',
+	isOpen = false,
 	label,
 	labelTooltipText,
 	onToggle,
-	prevLabel,
+	prevLabel = __( 'Previous period:', 'woocommerce' ),
 	prevValue,
-	reverseTrend,
-	selected,
+	reverseTrend = false,
+	selected = false,
 	value,
-	onLinkClickCallback,
+	onLinkClickCallback = noop,
 } ) => {
 	const liClasses = classnames( 'woocommerce-summary__item-container', {
 		'is-dropdown-button': onToggle,
@@ -238,14 +238,4 @@ SummaryNumber.propTypes = {
 	onLinkClickCallback: PropTypes.func,
 };
 
-SummaryNumber.defaultProps = {
-	href: '',
-	hrefType: 'wc-admin',
-	isOpen: false,
-	prevLabel: __( 'Previous period:', 'woocommerce' ),
-	reverseTrend: false,
-	selected: false,
-	onLinkClickCallback: noop,
-};
-
 export default SummaryNumber;
diff --git a/packages/js/components/src/timeline/index.js b/packages/js/components/src/timeline/index.js
index 0ca053fcba5..5d0d67ce8c2 100644
--- a/packages/js/components/src/timeline/index.js
+++ b/packages/js/components/src/timeline/index.js
@@ -13,9 +13,16 @@ import { createElement } from '@wordpress/element';
 import TimelineGroup from './timeline-group';
 import { sortByDateUsing, groupItemsUsing } from './util';
 
-const Timeline = ( props ) => {
-	const { className, items, groupBy, orderBy, dateFormat, clockFormat } =
-		props;
+const Timeline = ( {
+	className = '',
+	items = [],
+	groupBy = 'day',
+	orderBy = 'desc',
+	/* translators: PHP date format string used to display dates, see php.net/date. */
+	dateFormat = __( 'F j, Y', 'woocommerce' ),
+	/* translators: PHP clock format string used to display times, see php.net/date. */
+	clockFormat = __( 'g:ia', 'woocommerce' ),
+} ) => {
 	const timelineClassName = classnames( 'woocommerce-timeline', className );
 
 	// Early return in case no data was passed to the component.
@@ -111,16 +118,5 @@ Timeline.propTypes = {
 	clockFormat: PropTypes.string,
 };
 
-Timeline.defaultProps = {
-	className: '',
-	items: [],
-	groupBy: 'day',
-	orderBy: 'desc',
-	/* translators: PHP date format string used to display dates, see php.net/date. */
-	dateFormat: __( 'F j, Y', 'woocommerce' ),
-	/* translators: PHP clock format string used to display times, see php.net/date. */
-	clockFormat: __( 'g:ia', 'woocommerce' ),
-};
-
 export { orderByOptions, groupByOptions } from './util';
 export default Timeline;
diff --git a/packages/js/components/src/timeline/timeline-group.js b/packages/js/components/src/timeline/timeline-group.js
index 6c97877ae4e..6ddcde8e02b 100644
--- a/packages/js/components/src/timeline/timeline-group.js
+++ b/packages/js/components/src/timeline/timeline-group.js
@@ -11,8 +11,12 @@ import { createElement } from '@wordpress/element';
 import TimelineItem from './timeline-item';
 import { sortByDateUsing } from './util';
 
-const TimelineGroup = ( props ) => {
-	const { group, className, orderBy, clockFormat } = props;
+const TimelineGroup = ( {
+	group = { title: '', items: [] },
+	className = '',
+	orderBy = 'desc',
+	clockFormat,
+} ) => {
 	const groupClassName = classnames(
 		'woocommerce-timeline-group',
 		className
@@ -102,13 +106,4 @@ TimelineGroup.propTypes = {
 	clockFormat: PropTypes.string,
 };
 
-TimelineGroup.defaultProps = {
-	className: '',
-	group: {
-		title: '',
-		items: [],
-	},
-	orderBy: 'desc',
-};
-
 export default TimelineGroup;
diff --git a/packages/js/components/src/timeline/timeline-item.js b/packages/js/components/src/timeline/timeline-item.js
index ecf1a829050..59914878900 100644
--- a/packages/js/components/src/timeline/timeline-item.js
+++ b/packages/js/components/src/timeline/timeline-item.js
@@ -6,9 +6,7 @@ import { format } from '@wordpress/date';
 import PropTypes from 'prop-types';
 import { createElement } from '@wordpress/element';
 
-const TimelineItem = ( props ) => {
-	const { item, className, clockFormat } = props;
-
+const TimelineItem = ( { item = {}, className = '', clockFormat } ) => {
 	const itemClassName = classnames( 'woocommerce-timeline-item', className );
 	const itemTimeString = format( clockFormat, item.date );
 
@@ -74,9 +72,4 @@ TimelineItem.propTypes = {
 	} ).isRequired,
 };
 
-TimelineItem.defaultProps = {
-	className: '',
-	item: {},
-};
-
 export default TimelineItem;
diff --git a/packages/js/components/src/view-more-list/index.js b/packages/js/components/src/view-more-list/index.js
index 804b50c23f1..8b888693142 100644
--- a/packages/js/components/src/view-more-list/index.js
+++ b/packages/js/components/src/view-more-list/index.js
@@ -17,7 +17,7 @@ import Tag from '../tag';
  * @param {Array}  props.items
  * @return {Object} -
  */
-const ViewMoreList = ( { items } ) => {
+const ViewMoreList = ( { items = [] } ) => {
 	return (
 		<Tag
 			className="woocommerce-view-more-list"
@@ -49,8 +49,4 @@ ViewMoreList.propTypes = {
 	items: PropTypes.arrayOf( PropTypes.node ),
 };
 
-ViewMoreList.defaultProps = {
-	items: [],
-};
-
 export default ViewMoreList;
diff --git a/plugins/woocommerce-admin/client/activity-panel/activity-panel.js b/plugins/woocommerce-admin/client/activity-panel/activity-panel.js
index ea72b9bd49f..33b68c7f05b 100644
--- a/plugins/woocommerce-admin/client/activity-panel/activity-panel.js
+++ b/plugins/woocommerce-admin/client/activity-panel/activity-panel.js
@@ -15,7 +15,7 @@ import {
 	useUserPreferences,
 	getVisibleTasks,
 } from '@woocommerce/data';
-import { getHistory, addHistoryListener } from '@woocommerce/navigation';
+import { addHistoryListener } from '@woocommerce/navigation';
 import { recordEvent } from '@woocommerce/tracks';
 import { useSlot } from '@woocommerce/experimental';
 import {
@@ -503,8 +503,4 @@ export const ActivityPanel = ( { isEmbedded, query } ) => {
 	);
 };
 
-ActivityPanel.defaultProps = {
-	getHistory,
-};
-
 export default ActivityPanel;
diff --git a/plugins/woocommerce-admin/client/activity-panel/panels/help.js b/plugins/woocommerce-admin/client/activity-panel/panels/help.js
index 2d29a5babb8..cf4bddb7638 100644
--- a/plugins/woocommerce-admin/client/activity-panel/panels/help.js
+++ b/plugins/woocommerce-admin/client/activity-panel/panels/help.js
@@ -15,7 +15,7 @@ import {
 	SETTINGS_STORE_NAME,
 } from '@woocommerce/data';
 import { compose } from 'redux';
-import { recordEvent } from '@woocommerce/tracks';
+import { recordEvent as fallbackRecordEvent } from '@woocommerce/tracks';
 
 /**
  * Internal dependencies
@@ -359,15 +359,18 @@ function getListItems( props ) {
 	} ) );
 }
 
-export const HelpPanel = ( props ) => {
-	const { taskName } = props;
+export const HelpPanel = ( {
+	taskName,
+	recordEvent = fallbackRecordEvent,
+	...props
+} ) => {
 	useEffect( () => {
-		props.recordEvent( 'help_panel_open', {
+		recordEvent( 'help_panel_open', {
 			task_name: taskName || 'homescreen',
 		} );
-	}, [ taskName ] );
+	}, [ taskName, recordEvent ] );
 
-	const listItems = getListItems( props );
+	const listItems = getListItems( { taskName, recordEvent, ...props } );
 
 	return (
 		<Fragment>
@@ -382,10 +385,6 @@ export const HelpPanel = ( props ) => {
 	);
 };
 
-HelpPanel.defaultProps = {
-	recordEvent,
-};
-
 export default compose(
 	withSelect( ( select ) => {
 		const { getSettings } = select( SETTINGS_STORE_NAME );
diff --git a/plugins/woocommerce-admin/client/analytics/components/report-table/index.js b/plugins/woocommerce-admin/client/analytics/components/report-table/index.js
index 89f020645ce..f43cf9f7996 100644
--- a/plugins/woocommerce-admin/client/analytics/components/report-table/index.js
+++ b/plugins/woocommerce-admin/client/analytics/components/report-table/index.js
@@ -7,7 +7,7 @@ import { Fragment, useRef, useState } from '@wordpress/element';
 import { compose } from '@wordpress/compose';
 import { focus } from '@wordpress/dom';
 import { withDispatch, withSelect } from '@wordpress/data';
-import { get, noop, partial, uniq } from 'lodash';
+import { get, partial, uniq } from 'lodash';
 import { __, sprintf } from '@wordpress/i18n';
 import PropTypes from 'prop-types';
 import { STORE_KEY as CES_STORE_KEY } from '@woocommerce/customer-effort-score';
@@ -50,17 +50,23 @@ const ReportTable = ( props ) => {
 		getRowsContent,
 		getSummary,
 		isRequesting,
-		primaryData,
-		tableData,
+		primaryData = {},
+		tableData = {
+			items: {
+				data: [],
+				totalResults: 0,
+			},
+			query: {},
+		},
 		endpoint,
 		// These props are not used in the render function, but are destructured
 		// so they are not included in the `tableProps` variable.
 		// eslint-disable-next-line no-unused-vars
 		itemIdField,
-		// eslint-disable-next-line no-unused-vars
-		tableQuery,
+		// eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars
+		tableQuery = {},
 		compareBy,
-		compareParam,
+		compareParam = 'filter',
 		searchBy,
 		labels = {},
 		...tableProps
@@ -249,7 +255,7 @@ const ReportTable = ( props ) => {
 	};
 
 	const onSearchChange = ( values ) => {
-		const { baseSearchQuery, addCesSurveyForCustomerSearch } = props;
+		const { baseSearchQuery = {}, addCesSurveyForCustomerSearch } = props;
 		// A comma is used as a separator between search terms, so we want to escape
 		// any comma they contain.
 		const searchTerms = values.map( ( v ) =>
@@ -553,22 +559,6 @@ ReportTable.propTypes = {
 	title: PropTypes.string.isRequired,
 };
 
-ReportTable.defaultProps = {
-	primaryData: {},
-	tableData: {
-		items: {
-			data: [],
-			totalResults: 0,
-		},
-		query: {},
-	},
-	tableQuery: {},
-	compareParam: 'filter',
-	downloadable: false,
-	onSearch: noop,
-	baseSearchQuery: {},
-};
-
 const EMPTY_ARRAY = [];
 const EMPTY_OBJECT = {};
 
diff --git a/plugins/woocommerce-admin/client/homescreen/activity-panel/orders/index.js b/plugins/woocommerce-admin/client/homescreen/activity-panel/orders/index.js
index dbbed28530d..a443b883e3e 100644
--- a/plugins/woocommerce-admin/client/homescreen/activity-panel/orders/index.js
+++ b/plugins/woocommerce-admin/client/homescreen/activity-panel/orders/index.js
@@ -360,17 +360,8 @@ function OrdersPanel( { unreadOrdersCount, orderStatuses } ) {
 }
 
 OrdersPanel.propTypes = {
-	isError: PropTypes.bool,
-	isRequesting: PropTypes.bool,
 	unreadOrdersCount: PropTypes.number,
-	orders: PropTypes.array.isRequired,
 	orderStatuses: PropTypes.array,
 };
 
-OrdersPanel.defaultProps = {
-	orders: [],
-	isError: false,
-	isRequesting: false,
-};
-
 export default OrdersPanel;
diff --git a/plugins/woocommerce-admin/client/marketing/coupons/knowledge-base/index.js b/plugins/woocommerce-admin/client/marketing/coupons/knowledge-base/index.js
index 37459ad1130..85bce281fa2 100644
--- a/plugins/woocommerce-admin/client/marketing/coupons/knowledge-base/index.js
+++ b/plugins/woocommerce-admin/client/marketing/coupons/knowledge-base/index.js
@@ -24,8 +24,11 @@ const KnowledgeBase = ( {
 	posts,
 	isLoading,
 	error,
-	title,
-	description,
+	title = __( 'WooCommerce knowledge base', 'woocommerce' ),
+	description = __(
+		'Learn the ins and outs of successful marketing from the experts at WooCommerce.',
+		'woocommerce'
+	),
 	category,
 } ) => {
 	const [ page, updatePage ] = useState( 1 );
@@ -227,14 +230,6 @@ KnowledgeBase.propTypes = {
 	category: PropTypes.string,
 };
 
-KnowledgeBase.defaultProps = {
-	title: __( 'WooCommerce knowledge base', 'woocommerce' ),
-	description: __(
-		'Learn the ins and outs of successful marketing from the experts at WooCommerce.',
-		'woocommerce'
-	),
-};
-
 export { KnowledgeBase };
 
 export default compose(
diff --git a/plugins/woocommerce-admin/client/marketing/coupons/recommended-extensions/index.js b/plugins/woocommerce-admin/client/marketing/coupons/recommended-extensions/index.js
index c663bee025e..420b2f3b192 100644
--- a/plugins/woocommerce-admin/client/marketing/coupons/recommended-extensions/index.js
+++ b/plugins/woocommerce-admin/client/marketing/coupons/recommended-extensions/index.js
@@ -19,8 +19,11 @@ import Card from '../card';
 const RecommendedExtensions = ( {
 	extensions,
 	isLoading,
-	title,
-	description,
+	title = __( 'Recommended extensions', 'woocommerce' ),
+	description = __(
+		'Great marketing requires the right tools. Take your marketing to the next level with our recommended marketing extensions.',
+		'woocommerce'
+	),
 	category,
 } ) => {
 	if ( extensions.length === 0 && ! isLoading ) {
@@ -95,14 +98,6 @@ RecommendedExtensions.propTypes = {
 	category: PropTypes.string,
 };
 
-RecommendedExtensions.defaultProps = {
-	title: __( 'Recommended extensions', 'woocommerce' ),
-	description: __(
-		'Great marketing requires the right tools. Take your marketing to the next level with our recommended marketing extensions.',
-		'woocommerce'
-	),
-};
-
 export { RecommendedExtensions };
 export { default as RecommendedExtensionsPlaceholder } from './placeholder';
 
diff --git a/plugins/woocommerce-blocks/assets/js/editor-components/products-control/index.js b/plugins/woocommerce-blocks/assets/js/editor-components/products-control/index.js
index 91bb6d8a30f..a5d6a59ac82 100644
--- a/plugins/woocommerce-blocks/assets/js/editor-components/products-control/index.js
+++ b/plugins/woocommerce-blocks/assets/js/editor-components/products-control/index.js
@@ -27,10 +27,10 @@ const ProductsControl = ( {
 	error,
 	onChange,
 	onSearch,
-	selected,
-	products,
-	isLoading,
-	isCompact,
+	selected = [],
+	products = [],
+	isLoading = true,
+	isCompact = false,
 } ) => {
 	const messages = {
 		clear: __( 'Clear all products', 'woocommerce' ),
@@ -90,11 +90,4 @@ ProductsControl.propTypes = {
 	isLoading: PropTypes.bool,
 };
 
-ProductsControl.defaultProps = {
-	selected: [],
-	products: [],
-	isCompact: false,
-	isLoading: true,
-};
-
 export default withSearchedProducts( ProductsControl );
diff --git a/plugins/woocommerce/changelog/50266-fix-remove-functional-component-default-props b/plugins/woocommerce/changelog/50266-fix-remove-functional-component-default-props
new file mode 100644
index 00000000000..6e876bf13d2
--- /dev/null
+++ b/plugins/woocommerce/changelog/50266-fix-remove-functional-component-default-props
@@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Removed defaultProps from React functional components since they will be deprecated for React 19
\ No newline at end of file