Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify emitEventWithAbort logic (https://github.com/woocommerce/woocommerce-blocks/pull/3256)

This commit is contained in:
Albert Juhé Lluveras 2020-10-09 10:52:04 +02:00 committed by GitHub
parent d9c0d20129
commit b98ecd8116
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/woocommerce-blocks/assets/js/base/context/shared/event-emit/emitters.js
View File

@ -58,22 +58,18 @@ export const emitEvent = async ( observers, eventType, data ) => {
*/
export const emitEventWithAbort = async ( observers, eventType, data ) => {
const observersByType = getObserversByPriority( observers, eventType );
let emitterResponse = true;
for ( const observer of observersByType ) {
try {
const response = await Promise.resolve( observer.callback( data ) );
if (
typeof response === 'object' &&
typeof response.type === 'undefined'
) {
if ( typeof response !== 'object' ) {
continue;
}
if ( typeof response.type === 'undefined' ) {
throw new Error(
'If you want to abort event emitter processing, your observer must return an object with a type property'
);
}
emitterResponse = typeof response === 'object' ? response : true;
if ( emitterResponse !== true ) {
return emitterResponse;
}
return response;
} catch ( e ) {
// We don't handle thrown errors but just console.log for troubleshooting.
// eslint-disable-next-line no-console
@ -81,5 +77,5 @@ export const emitEventWithAbort = async ( observers, eventType, data ) => {
return { type: 'error' };
}
}
return emitterResponse;
return true;
};