Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert setting up permalinks in PW global setup (#35337) 

* Revert permalinks setup

* Add changelog

Co-authored-by: Jon Lane <jon.lane@automattic.com>
This commit is contained in:
Jamel Noel Reid 2022-10-26 14:36:44 -05:00 committed by GitHub
parent c72122ab5d
commit bfe0e958b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce/changelog/revert-setup-permalinks Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: dev
Revert the changes introduced in PR #35282

37
plugins/woocommerce/tests/e2e-pw/global-setup.js
View File

@ -11,19 +11,6 @@ const adminPassword = ADMIN_PASSWORD ?? 'password';
const customerUsername = CUSTOMER_USER ?? 'customer';
const customerPassword = CUSTOMER_PASSWORD ?? 'password';
const setupPermalinks = async ( adminPage, baseURL ) => {
console.log( 'Trying to setup permalinks!' );
await adminPage.goto( baseURL + '/wp-admin/options-permalink.php' );
await expect( adminPage.locator( 'div.wrap > h1' ) ).toHaveText(
'Permalink Settings'
);
await adminPage.click( '#custom_selection' );
await adminPage.fill( '#permalink_structure', '/%postname%/' );
await adminPage.click( '#submit' );
console.log( 'Permalinks Set!' );
}
module.exports = async ( config ) => {
const { stateDir, baseURL, userAgent } = config.projects[ 0 ].use;
@ -142,30 +129,6 @@ module.exports = async ( config ) => {
process.exit( 1 );
}
// Ensure that permalinks are correctly setup since we can't set it up using wp-env when not using the default WP version.
// More info here: https://github.com/WordPress/gutenberg/issues/28201
let permalinkConfigured = false;
const permalinkRetries = 5;
for ( let i = 0; i < permalinkRetries; i++ ) {
try {
await setupPermalinks( adminPage, baseURL );
permalinkConfigured = true;
break;
} catch ( e ) {
console.log(
`Setting permalink failed, Retrying... ${ i }/${ permalinkRetries }`
);
console.log( e );
}
}
if ( ! permalinkConfigured ) {
console.error(
'Cannot proceed e2e test, as we could not setup permalinks. Please check if the test site has been setup correctly.'
);
process.exit( 1 );
}
// Sign in as customer user and save state
const customerRetries = 5;
for ( let i = 0; i < customerRetries; i++ ) {