Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix error when adding to cart from the Product Collection block if Google Analytics plugin is enabled (II) (#43177) 

* Revert "Trigger event `experimental__woocommerce_blocks-cart-add-item` in the SSR Product Button vis Interactivity API (#42946)"

This reverts commit 4fec136da1.

* Add changefile(s) from automation for the following project(s): woocommerce-blocks

---------

Co-authored-by: github-actions <github-actions@github.com>
This commit is contained in:
Albert Juhé Lluveras 2023-12-29 17:23:35 +01:00 committed by GitHub
parent 4efd2123a3
commit c58b0cf936
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/woocommerce-blocks/assets/js/atomic/blocks/product-elements/button/frontend.tsx
View File

@ -7,7 +7,6 @@ import { CART_STORE_KEY as storeKey } from '@woocommerce/block-data';
import { Cart } from '@woocommerce/type-defs/cart'; import { Cart } from '@woocommerce/type-defs/cart';
import { createRoot } from '@wordpress/element'; import { createRoot } from '@wordpress/element';
import NoticeBanner from '@woocommerce/base-components/notice-banner'; import NoticeBanner from '@woocommerce/base-components/notice-banner';
import { doAction } from '@wordpress/hooks';
interface Context { interface Context {
isLoading: boolean; isLoading: boolean;
@ -136,7 +135,6 @@ const { state } = store< Store >( 'woocommerce/product-button', {
*addToCart() { *addToCart() {
const context = getContext(); const context = getContext();
const { productId, quantityToAdd } = context; const { productId, quantityToAdd } = context;
const product = getProductById( state.cart, productId );
context.isLoading = true; context.isLoading = true;
@ -146,15 +144,6 @@ const { state } = store< Store >( 'woocommerce/product-button', {
quantityToAdd quantityToAdd
); );
// Adding a manual trigger of the event for backward compatibility
// and symmetry ("remove" event is triggered properly from Cart and Mini Cart).
// The events will be revisited and unified in scope of:
// https://github.com/woocommerce/woocommerce/pull/42946
yield doAction(
`experimental__woocommerce_blocks-cart-add-item`,
product
);
// After the cart is updated, sync the temporary number of items again. // After the cart is updated, sync the temporary number of items again.
context.temporaryNumberOfItems = state.numberOfItemsInTheCart; context.temporaryNumberOfItems = state.numberOfItemsInTheCart;
} catch ( error ) { } catch ( error ) {

4
plugins/woocommerce/changelog/43177-fix-add-to-cart-google-analytics-error-ii Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: fix
Comment: Product Button: remove the `experimental__woocommerce_blocks-cart-add-item` event to avoid conflicts with extensions.