Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add errors to log.

This commit is contained in:
vedanshujain 2022-04-04 13:43:19 +05:30
parent bb10c88b8f
commit c5df64ca57
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/woocommerce/src/Database/Migrations/CustomOrderTable/MetaToCustomTableMigrator.php
View File

@ -283,8 +283,7 @@ abstract class MetaToCustomTableMigrator {
$result = $wpdb->query( $queries );
$wpdb->query( 'COMMIT;' ); // For some reason, this seems necessary on some hosts? Maybe a MySQL configuration?
if ( count( $batch ) !== $result ) {
// Some rows were not inserted.
// TODO: Find and log the entity ids that were not inserted.
$this->errors[] = 'Error with batch: ' . $wpdb->last_error;
}
}
@ -304,8 +303,7 @@ abstract class MetaToCustomTableMigrator {
$result = $wpdb->query( $queries );
$wpdb->query( 'COMMIT;' ); // For some reason, this seems necessary on some hosts? Maybe a MySQL configuration?
if ( count( $batch ) !== $result ) {
// Some rows were not inserted.
// TODO: Find and log the entity ids that were not updateed.
$this->errors[] = 'Error with batch: ' . $wpdb->last_error;
}
}
@ -486,11 +484,6 @@ WHERE
* @return array[] Validated and combined data with errors.
*/
private function process_and_sanitize_data( $entity_data, $meta_data ) {
/**
* TODO: Add more validations for:
* 1. Column size
* 2. Value limits
*/
$sanitized_entity_data = array();
$error_records = array();
$this->process_and_sanitize_entity_data( $sanitized_entity_data, $error_records, $entity_data );
@ -565,7 +558,6 @@ WHERE
$value = wc_string_to_bool( $value );
break;
case 'date':
// TODO: Test this validation in unit tests.
try {
if ( '' === $value ) {
$value = null;