Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only run "woocommerce_admin_shared_settings" filter on admin requests (#51161) 

* Only load settings if it's admin

* Add changelog
This commit is contained in:
Chi-Hsuan Huang 2024-09-06 11:44:01 +08:00 committed by GitHub
parent 0ef7d95aff
commit cb2549386a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce/changelog/perf-only-load-settings-in-admin Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: performance
Only run woocommerce_admin_shared_settings filter on admin requests

8
plugins/woocommerce/src/Internal/Admin/WCAdminSharedSettings.php
View File

@ -54,14 +54,18 @@ class WCAdminSharedSettings {
* @return void * @return void
*/ */
public function on_woocommerce_blocks_loaded() { public function on_woocommerce_blocks_loaded() {
// Ensure we only add admin settings on the admin.
if ( ! is_admin() ) {
return;
}
if ( class_exists( '\Automattic\WooCommerce\Blocks\Assets\AssetDataRegistry' ) ) { if ( class_exists( '\Automattic\WooCommerce\Blocks\Assets\AssetDataRegistry' ) ) {
\Automattic\WooCommerce\Blocks\Package::container()->get( \Automattic\WooCommerce\Blocks\Assets\AssetDataRegistry::class )->add( \Automattic\WooCommerce\Blocks\Package::container()->get( \Automattic\WooCommerce\Blocks\Assets\AssetDataRegistry::class )->add(
$this->settings_prefix, $this->settings_prefix,
function() { function () {
return apply_filters( 'woocommerce_admin_shared_settings', array() ); return apply_filters( 'woocommerce_admin_shared_settings', array() );
} }
); );
} }
} }
} }