From cb31c3a468decd4748ca35d7d630fb0d4d1a02c1 Mon Sep 17 00:00:00 2001 From: Moon Date: Tue, 6 Jul 2021 12:30:39 -0700 Subject: [PATCH] Add CES to translated scripts list (https://github.com/woocommerce/woocommerce-admin/pull/7270) * Add CES to translated scripts list --- plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md | 9 +++++++++ plugins/woocommerce-admin/readme.txt | 1 + plugins/woocommerce-admin/src/Loader.php | 1 + 3 files changed, 11 insertions(+) diff --git a/plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md b/plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md index ae43bf91928..790695859e2 100644 --- a/plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md +++ b/plugins/woocommerce-admin/TESTING-INSTRUCTIONS.md @@ -2,6 +2,15 @@ ## Unreleased +### Fix missing translation strings for CES #7270 + + +1. Navigate to Settings -> General and change the site language to a non-English (I've used Espanol for testing purposes). +2. You might need to update the language file if it's your first time using the selected language. Update the language file from Dashboard -> Updates +3. Go to WooCommerce -> Settings +4. Click the [ Save Changes ] button to trigger the CES modal. +5. Confirm the modal has correct translations (Refer to the screenshots) + ### Use saved values if available when switching tabs #7226 1. Start onboarding wizard and continue to step 4. diff --git a/plugins/woocommerce-admin/readme.txt b/plugins/woocommerce-admin/readme.txt index d00f13e4805..8b31ee2f4b2 100644 --- a/plugins/woocommerce-admin/readme.txt +++ b/plugins/woocommerce-admin/readme.txt @@ -104,6 +104,7 @@ Release and roadmap notes are available on the [WooCommerce Developers Blog](htt - Fix: Fix and refactor explat polling to use setTimeout #7274 - Fix: Cache product/variation revenue query results. #7067 - Tweak: Remove performance indicators when Analytics Flag disabled #7234 +- Fix: Fix missing translation strings for CES #7270 - Tweak: Revert Card component removal #7167 - Tweak: Removed unused feature flags #7233 and #7273 - Tweak: Repurpose disable wc-admin filter to remove optional features #7232 diff --git a/plugins/woocommerce-admin/src/Loader.php b/plugins/woocommerce-admin/src/Loader.php index 25666af8655..926a3b748b3 100644 --- a/plugins/woocommerce-admin/src/Loader.php +++ b/plugins/woocommerce-admin/src/Loader.php @@ -390,6 +390,7 @@ class Loader { 'wc-currency', 'wc-date', 'wc-components', + 'wc-customer-effort-score', WC_ADMIN_APP, );