From ccc5042ce957074a1c2dba95252a898fbf3c577c Mon Sep 17 00:00:00 2001
From: Lukas Kurzmann <lukas.kurzmann@student.tugraz.at>
Date: Wed, 28 Aug 2024 18:00:45 +0200
Subject: [PATCH] =?UTF-8?q?fixes=20not=20allowed=20size=20parameter=20for?=
 =?UTF-8?q?=20any=20input=20types,=20which=20do=20not=20al=E2=80=A6=20(#50?=
 =?UTF-8?q?438)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fixes not allowed size parameter for any input types, which do not allow them

* add changelog

* Update plugins/woocommerce/templates/global/quantity-input.php

* Appease linter

---------

Co-authored-by: Lukas Kurzmann <lukas.kurzmann@sunlime.at>
Co-authored-by: Nadir Seghir <nadir.seghir@gmail.com>
Co-authored-by: Jorge Torres <jorge.torres@automattic.com>
---
 plugins/woocommerce/changelog/bugfix-quantity-html-issue | 5 +++++
 plugins/woocommerce/templates/global/quantity-input.php  | 6 ++++--
 2 files changed, 9 insertions(+), 2 deletions(-)
 create mode 100644 plugins/woocommerce/changelog/bugfix-quantity-html-issue

diff --git a/plugins/woocommerce/changelog/bugfix-quantity-html-issue b/plugins/woocommerce/changelog/bugfix-quantity-html-issue
new file mode 100644
index 00000000000..a243dfb8f2a
--- /dev/null
+++ b/plugins/woocommerce/changelog/bugfix-quantity-html-issue
@@ -0,0 +1,5 @@
+Significance: patch
+Type: fix
+Comment: Fixes a warning that only shows up when validating page content
+
+
diff --git a/plugins/woocommerce/templates/global/quantity-input.php b/plugins/woocommerce/templates/global/quantity-input.php
index 61dbe181f10..2ff50286e4f 100644
--- a/plugins/woocommerce/templates/global/quantity-input.php
+++ b/plugins/woocommerce/templates/global/quantity-input.php
@@ -12,7 +12,7 @@
  *
  * @see     https://woocommerce.com/document/template-structure/
  * @package WooCommerce\Templates
- * @version 7.8.0
+ * @version 9.4.0
  *
  * @var bool   $readonly If the input should be set to readonly mode.
  * @var string $type     The input type attribute.
@@ -42,7 +42,9 @@ $label = ! empty( $args['product_name'] ) ? sprintf( esc_html__( '%s quantity',
 		name="<?php echo esc_attr( $input_name ); ?>"
 		value="<?php echo esc_attr( $input_value ); ?>"
 		aria-label="<?php esc_attr_e( 'Product quantity', 'woocommerce' ); ?>"
-		size="4"
+		<?php if ( in_array( $type, array( 'text', 'search', 'tel', 'url', 'email', 'password' ), true ) ) : ?>
+			size="4"
+		<?php endif; ?>
 		min="<?php echo esc_attr( $min_value ); ?>"
 		max="<?php echo esc_attr( 0 < $max_value ? $max_value : '' ); ?>"
 		<?php if ( ! $readonly ) : ?>