From ce371a0af7823e362382b87bef200dd25e9e8e8e Mon Sep 17 00:00:00 2001 From: Niels Lange Date: Fri, 8 Oct 2021 11:54:52 +0700 Subject: [PATCH] Add documentation guidelines (https://github.com/woocommerce/woocommerce-blocks/pull/4893) * Add documentation guidelines * Link to Automattic Writing Style Guide * Adjust section for heading usage * Update docs/contributors/documentation-guidelines.md Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> --- .../contributors/documentation-guidelines.md | 156 ++++++++++++++++++ 1 file changed, 156 insertions(+) create mode 100644 plugins/woocommerce-blocks/docs/contributors/documentation-guidelines.md diff --git a/plugins/woocommerce-blocks/docs/contributors/documentation-guidelines.md b/plugins/woocommerce-blocks/docs/contributors/documentation-guidelines.md new file mode 100644 index 00000000000..d84dc29ea58 --- /dev/null +++ b/plugins/woocommerce-blocks/docs/contributors/documentation-guidelines.md @@ -0,0 +1,156 @@ +# Documentation Guidelines + +- [Documentation Guidelines](#documentation-guidelines) + - [Use Automattic Writing Style Guide](#use-automattic-writing-style-guide) + - [Use active instead of passive voice](#use-active-instead-of-passive-voice) + - [Use the personal pronoun “you”](#use-the-personal-pronoun-you) + - [Don’t use gendered pronouns](#dont-use-gendered-pronouns) + - [Filename must resemble the title](#filename-must-resemble-the-title) + - [Use correct heading hierarchy](#use-correct-heading-hierarchy) + - [Use semantically correct markup](#use-semantically-correct-markup) + - [Use correct spelling](#use-correct-spelling) + - [Use images not wider than 50% width](#use-images-not-wider-than-50-width) + - [Use descriptive links](#use-descriptive-links) + - [Explain arguments](#explain-arguments) + - [Explicitly define language for code examples](#explicitly-define-language-for-code-examples) + - [Use table of contents for top-level readme](#use-table-of-contents-for-top-level-readme) + - [Use internal links](#use-internal-links) + - [Sort releases descending](#sort-releases-descending) + - [Structure “How to” instructions](#structure-how-to-instructions) + - [Link references](#link-references) + +## Use Automattic Writing Style Guide + +The [Automattic Writing Style Guide](https://fieldguide.automattic.com/the-automattic-style-guide/) serves as the foundation of these documentation guidelines. + +## Use active instead of passive voice + +Active voice should be preferred over passive voice. Passive voice can be used, when it fits better. + +**Example** + +- **Active voice:** You want to render your own components in specific places in the Cart and Checkout. +- **Passive voice:** Slots and Fills add the possibility to render your own HTML in pre-defined places in the Cart and Checkout. + +## Use the personal pronoun “you” + +When using active voice, the second person singular (you) must be used. + +## Don’t use gendered pronouns + +Gendered pronouns (she/her/hers and he/him/his) must not be used. + +## Filename must resemble the title + +The filename of the document must match the title. + +**Example** + +- **Title:** Slots and Fills +- **Filename:** slots-and-fills.md + +## Use correct heading hierarchy + +Correct H1-H6 headings must be used. Each document can only have one H1 heading. An H3 heading can only be used within an H2 heading, an H4 heading can only be used within an H3 heading, etc. If possible, avoid using articles in headings. + +**Example** + +- **Incorrect:** The problem +- **Correct:** Problem + +## Use semantically correct markup + +The markup used must be semantically correct, e.g. list markup must only be used to display a list. + +## Use correct spelling + +Classes and tokens from the codebase must be written exactly as they appear in the codebase. Proper nouns must be written correctly. + +**Example** + +- **ExtendRestApi:** The `p` and the `i` of `ExtendRestApi` are written in lowercase +- **Composer:** The `C` of `Composer` is written in uppercase. +- **ESLint:** The `E`, the `S` and the `L` of `ESLint` are written in uppercase. + +## Use images not wider than 50% width + +Embedded images should not exceed a width of 50%. + +## Use descriptive links + +When linking to another document, a descriptive link text must be used. + +**Example** + +- **Incorrect:** Check this document +- **Correct:** Check the Slot Fill documentation + +## Explain arguments + +When listing or describing arguments, a table must be used to describe them. Refer to them as either arguments or props, depending on if they’re being used on a component or in a function/method. In the table, the description column should begin with a capital letter and end in a full stop. When listing an argument that is an array/object, list the argument name, type: array/object and a high-level description of what the purpose of the argument is. Then below, you detail the individual keys of the array/object. + +**Example** + +| Argument | Type | Default value | Required | Description | +| -------- | ---- | ------------- | -------- | ----------- | +| ... | ... | ... | ... | ... | + +## Explicitly define language for code examples + +When using code examples, the fence format and the language definition must be used. + +**Example** + +- **CSS code example:** +
+
+```CSS
+/* This will apply to prices in the checkout block */
+.wc-block-checkout .wc-block-components-formatted-money-amount {
+	font-style: italic;
+}
+```
+
+
+ +- **JS code example:** +
+
+```js
+import { registerExpressPaymentMethod } from '@woocommerce/blocks-registry';
+```
+
+
+ +## Use table of contents for top-level readme + +Every top-level README must have a table of contents. The table of contents can be generated automatically using the Visual Studio Code extension Markdown All in One. + +## Use internal links + +When listing features and options, e.g. ExperimentalOrderMeta, a table of contents with internal links must be used to allow jumping to the specific feature and option directly. + +## Sort releases descending + +Releases must be sorted starting with the most recent release. + +**Example** + +- 5.7.1 +- 5.7.0 +- 5.6.0 +- 5.5.0 + +## Structure “How to” instructions + +When explaining functionality, the following structure should be used: + +- Problem +- Solution +- Usage +- Things to consider +- Putting it together + +## Link references + +When referencing other documentations, the corresponding document should be linked.