From d38e22329ff561148d35e0485fbc6e5f798fb132 Mon Sep 17 00:00:00 2001
From: Jon Surrell <jon.surrell@gmail.com>
Date: Thu, 5 Jan 2017 16:33:58 +0100
Subject: [PATCH] Replace count with empty check

---
 .../admin/class-wc-admin-log-table-list.php   | 34 ++++++++-----------
 1 file changed, 15 insertions(+), 19 deletions(-)

diff --git a/includes/admin/class-wc-admin-log-table-list.php b/includes/admin/class-wc-admin-log-table-list.php
index 6410b17b85e..09b1db29744 100644
--- a/includes/admin/class-wc-admin-log-table-list.php
+++ b/includes/admin/class-wc-admin-log-table-list.php
@@ -200,26 +200,22 @@ class WC_Admin_Log_Table_List extends WP_List_Table {
 			ORDER BY source ASC
 		" );
 
-		$source_count = count( $sources );
-
-		if ( ! $source_count ) {
-			return;
+		if ( ! empty( $sources ) ) {
+			$selected_source = isset( $_REQUEST['source'] ) ? $_REQUEST['source'] : '';
+			?>
+				<label for="filter-by-source" class="screen-reader-text"><?php _e( 'Filter by source', 'woocommerce' ); ?></label>
+				<select name="source" id="filter-by-source">
+					<option<?php selected( $selected_source, '' ); ?> value=""><?php _e( 'All sources', 'woocommerce' ); ?></option>
+					<?php foreach ( $sources as $s ) {
+						printf( '<option%1$s value="%2$s">%3$s</option>',
+							selected( $selected_source, $s, false ),
+							esc_attr( $s ),
+							esc_html( $s )
+						);
+					} ?>
+				</select>
+			<?php
 		}
-
-		$selected_source = isset( $_REQUEST['source'] ) ? $_REQUEST['source'] : '';
-		?>
-			<label for="filter-by-source" class="screen-reader-text"><?php _e( 'Filter by source', 'woocommerce' ); ?></label>
-			<select name="source" id="filter-by-source">
-				<option<?php selected( $selected_source, '' ); ?> value=""><?php _e( 'All sources', 'woocommerce' ); ?></option>
-				<?php foreach ( $sources as $s ) {
-					printf( '<option%1$s value="%2$s">%3$s</option>',
-						selected( $selected_source, $s, false ),
-						esc_attr( $s ),
-						esc_html( $s )
-					);
-				} ?>
-			</select>
-		<?php
 	}
 
 	/**