Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix resolvers tests giving false positives (https://github.com/woocommerce/woocommerce-admin/pull/666)

This commit is contained in:
Albert Juhé Lluveras 2018-10-24 16:25:42 +02:00 committed by GitHub
parent 812d72dd9f
commit d770e9a7e0
3 changed files with 40 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/woocommerce-admin/client/store/notes/test/resolvers.js
View File

@ -6,6 +6,7 @@
* External dependencies
*/
import apiFetch from '@wordpress/api-fetch';
import { dispatch } from '@wordpress/data';
/**
* Internal dependencies
@ -14,6 +15,11 @@ import resolvers from '../resolvers';
const { getNotes } = resolvers;
jest.mock( '@wordpress/data', () => ( {
dispatch: jest.fn().mockReturnValue( {
setNotes: jest.fn(),
} ),
} ) );
jest.mock( '@wordpress/api-fetch', () => jest.fn() );
describe( 'getNotes', () => {
@ -26,17 +32,21 @@ describe( 'getNotes', () => {
if ( options.path === '/wc/v3/admin/notes' ) {
return Promise.resolve( NOTES_1 );
}
if ( options.path === '/wc/v3/admin/notes/&page=2' ) {
if ( options.path === '/wc/v3/admin/notes?page=2' ) {
return Promise.resolve( NOTES_2 );
}
} );
} );
it( 'returns requested data', async () => {
getNotes().then( data => expect( data ).toEqual( NOTES_1 ) );
expect.assertions( 1 );
await getNotes( {} );
expect( dispatch().setNotes ).toHaveBeenCalledWith( NOTES_1, undefined );
} );
it( 'returns requested data for a specific query', async () => {
getNotes( { page: 2 } ).then( data => expect( data ).toEqual( NOTES_2 ) );
expect.assertions( 1 );
await getNotes( {}, { page: 2 } );
expect( dispatch().setNotes ).toHaveBeenCalledWith( NOTES_2, { page: 2 } );
} );
} );

16
plugins/woocommerce-admin/client/store/orders/test/resolvers.js
View File

@ -6,6 +6,7 @@
* External dependencies
*/
import apiFetch from '@wordpress/api-fetch';
import { dispatch } from '@wordpress/data';
/**
* Internal dependencies
@ -14,6 +15,11 @@ import resolvers from '../resolvers';
const { getOrders } = resolvers;
jest.mock( '@wordpress/data', () => ( {
dispatch: jest.fn().mockReturnValue( {
setOrders: jest.fn(),
} ),
} ) );
jest.mock( '@wordpress/api-fetch', () => jest.fn() );
describe( 'getOrders', () => {
@ -26,17 +32,21 @@ describe( 'getOrders', () => {
if ( options.path === '/wc/v3/orders' ) {
return Promise.resolve( ORDERS_1 );
}
if ( options.path === '/wc/v3/orders&orderby=id' ) {
if ( options.path === '/wc/v3/orders?orderby=id' ) {
return Promise.resolve( ORDERS_2 );
}
} );
} );
it( 'returns requested report data', async () => {
getOrders().then( data => expect( data ).toEqual( ORDERS_1 ) );
expect.assertions( 1 );
await getOrders( {} );
expect( dispatch().setOrders ).toHaveBeenCalledWith( ORDERS_1, undefined );
} );
it( 'returns requested report data for a specific query', async () => {
getOrders( { orderby: 'id' } ).then( data => expect( data ).toEqual( ORDERS_2 ) );
expect.assertions( 1 );
await getOrders( {}, { orderby: 'id' } );
expect( dispatch().setOrders ).toHaveBeenCalledWith( ORDERS_2, { orderby: 'id' } );
} );
} );

18
plugins/woocommerce-admin/client/store/products/test/resolvers.js
View File

@ -6,6 +6,7 @@
* External dependencies
*/
import apiFetch from '@wordpress/api-fetch';
import { dispatch } from '@wordpress/data';
/**
* Internal dependencies
@ -14,6 +15,11 @@ import resolvers from '../resolvers';
const { getProducts } = resolvers;
jest.mock( '@wordpress/data', () => ( {
dispatch: jest.fn().mockReturnValue( {
setProducts: jest.fn(),
} ),
} ) );
jest.mock( '@wordpress/api-fetch', () => jest.fn() );
describe( 'getProducts', () => {
@ -40,20 +46,24 @@ describe( 'getProducts', () => {
beforeAll( () => {
apiFetch.mockImplementation( options => {
if ( options.path === '/wc/v3/products' ) {
if ( options.path === '/wc/v3/reports/products' ) {
return Promise.resolve( PRODUCTS_1 );
}
if ( options.path === '/wc/v3/products?orderby=date' ) {
if ( options.path === '/wc/v3/reports/products?orderby=date' ) {
return Promise.resolve( PRODUCTS_2 );
}
} );
} );
it( 'returns requested products', async () => {
getProducts().then( data => expect( data ).toEqual( PRODUCTS_1 ) );
expect.assertions( 1 );
await getProducts( {} );
expect( dispatch().setProducts ).toHaveBeenCalledWith( PRODUCTS_1, undefined );
} );
it( 'returns requested products for a specific query', async () => {
getProducts( { orderby: 'date' } ).then( data => expect( data ).toEqual( PRODUCTS_2 ) );
expect.assertions( 1 );
await getProducts( {}, { orderby: 'date' } );
expect( dispatch().setProducts ).toHaveBeenCalledWith( PRODUCTS_2, { orderby: 'date' } );
} );
} );