Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add changelog and enable promotion in core and plugin configs (https://github.com/woocommerce/woocommerce-admin/pull/7666) 

* Add changelog and enable promotion in core and plugin configs

* Add PR number

* Make variation name a constant

* Clone spec as we are overwriting the is_visible prop

* Fix unit tests and support array and object

* Revert explat variation name

* Update changelog entry

* Update changelog once more

* Make sure the recommendations show up if marketplace suggestions is not defined defaulting to 'yes'
This commit is contained in:
louwie17 2021-09-27 10:24:47 -03:00 committed by GitHub
parent 48539bf3f4
commit da395281e7
7 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce-admin/changelogs/update-7319_enable_wc_pay_experiment Normal file
View File

@ -0,0 +1,4 @@
Significance: minor
Type: Enhancement
Add experiment for promoting WooCommerce Payments in payment methods table. #7666

2
plugins/woocommerce-admin/client/settings-recommendations/recommendations-eligibility-wrapper.tsx
View File

@ -19,7 +19,7 @@ const RecommendationsEligibilityWrapper: React.FC = ( { children } ) => {
SHOW_MARKETPLACE_SUGGESTION_OPTION,
] );
const canShowMarketplaceSuggestions =
getOption( SHOW_MARKETPLACE_SUGGESTION_OPTION ) === 'yes';
getOption( SHOW_MARKETPLACE_SUGGESTION_OPTION ) !== 'no';
return hasFinishedResolving && canShowMarketplaceSuggestions;
} );

2
plugins/woocommerce-admin/config/core.json
View File

@ -18,6 +18,6 @@
"store-alerts": true,
"tasks": false,
"transient-notices": true,
"wc-pay-promotion": false
"wc-pay-promotion": true
}
}

2
plugins/woocommerce-admin/config/plugin.json
View File

@ -18,6 +18,6 @@
"store-alerts": true,
"tasks": false,
"transient-notices": true,
"wc-pay-promotion": false
"wc-pay-promotion": true
}
}

6
plugins/woocommerce-admin/src/Features/PaymentGatewaySuggestions/EvaluateSuggestion.php
View File

@ -16,12 +16,12 @@ class EvaluateSuggestion {
/**
* Evaluates the spec and returns the suggestion.
*
* @param array $spec The suggestion to evaluate.
* @return array The evaluated suggestion.
* @param object|array $spec The suggestion to evaluate.
* @return object The evaluated suggestion.
*/
public static function evaluate( $spec ) {
$rule_evaluator = new RuleEvaluator();
$suggestion = (object) $spec;
$suggestion = is_array( $spec ) ? (object) $spec : clone $spec;
if ( isset( $suggestion->is_visible ) ) {
$is_visible = $rule_evaluator->evaluate( $suggestion->is_visible );

5
plugins/woocommerce-admin/src/Features/WcPayPromotion/Init.php
View File

@ -15,7 +15,8 @@ use Automattic\WooCommerce\Admin\Features\PaymentGatewaySuggestions\EvaluateSugg
* WC Pay Promotion engine.
*/
class Init {
const SPECS_TRANSIENT_NAME = 'woocommerce_admin_payment_method_promotion_specs';
const SPECS_TRANSIENT_NAME = 'woocommerce_admin_payment_method_promotion_specs';
const EXPLAT_VARIATION_PREFIX = 'woocommerce_wc_pay_promotion_payment_methods_table_';
/**
* Constructor.
@ -113,7 +114,7 @@ class Init {
$allow_tracking
);
$variation_name = $abtest->get_variation( 'woocommerce_wc_pay_promotion_payment_methods_table_' . $wc_pay_spec->additional_info->experiment_version );
$variation_name = $abtest->get_variation( self::EXPLAT_VARIATION_PREFIX . $wc_pay_spec->additional_info->experiment_version );
if ( 'treatment' === $variation_name ) {
return true;

6
plugins/woocommerce-admin/tests/features/payment-gateway-suggestions/evaluate-suggestion.php
View File

@ -31,7 +31,7 @@ class WC_Tests_PaymentGatewaySuggestions_EvaluateSuggestion extends WC_Unit_Test
$suggestion = array(
'id' => 'mock-gateway',
);
$evaluated = EvaluateSuggestion::evaluate( $suggestion );
$evaluated = EvaluateSuggestion::evaluate( (object) $suggestion );
$this->assertEquals( (object) $suggestion, $evaluated );
}
@ -49,7 +49,7 @@ class WC_Tests_PaymentGatewaySuggestions_EvaluateSuggestion extends WC_Unit_Test
'operation' => '=',
),
);
$evaluated = EvaluateSuggestion::evaluate( $suggestion );
$evaluated = EvaluateSuggestion::evaluate( (object) $suggestion );
$this->assertFalse( $evaluated->is_visible );
}
@ -68,7 +68,7 @@ class WC_Tests_PaymentGatewaySuggestions_EvaluateSuggestion extends WC_Unit_Test
),
);
update_option( self::MOCK_OPTION, 'a' );
$evaluated = EvaluateSuggestion::evaluate( $suggestion );
$evaluated = EvaluateSuggestion::evaluate( (object) $suggestion );
$this->assertTrue( $evaluated->is_visible );
}
}