From b4930ed0771ed99d156d4fd33224428a1837f0f3 Mon Sep 17 00:00:00 2001 From: Yordan Soares Date: Sun, 14 Mar 2021 13:55:06 -0400 Subject: [PATCH 1/9] =?UTF-8?q?Update=20Venezuelan=20currency:=20Bol=C3=AD?= =?UTF-8?q?var=20(Bs.)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### Changes: - [ ] Remove the "Venezuelan bolívar" currency (VEF) - [ ] Remove the "Bs F" symbol (VEF) - [ ] Update the "Bolívar soberano" currency to "Venezuelan bolívar" (VES) - [ ] Update the "Bs.S" symbol to "Bs." (VES) ### Justification: The official name of Venezuela's currency is Bolivar (Bs.). However, as we have had a couple of reconversions in recent years, temporary epithets have been used to distinguish the different monetary cones with a practical sense in the transition period. This is the reason why Bolivar Fuerte (Bs.F) and Bolivar Soberano (Bs.S) was used. However, the Bolívar Fuerte (monetary cone) went out of circulation on December 3, 2018 and the Bolívar Soberano (monetary cone) started to be called only Bolívar (Bs.) since February 2019, after a reasonable period of time had passed for the population to get used to the change of monetary cone. This came into effect with Resolution No. 19-02-01 published on February 14, 2019 by the Central Bank of Venezuela (BCV, Banco Central de Venezuela), where it can be read: [...] _as of the effective date of this Resolution, the price of goods and services and other monetary amounts shall be expressed only in the monetary scale in effect as of August 20, 2018, making mention of "bolívares" or the symbol "Bs."_ ### References: Resolución N° 19-02-01 del Banco Central de Venezuela (February 14, 2019) http://www.bcv.org.ve/system/files/documentos_juridicos/resolucion_cese_doble_expresion_precios_bienes_y_servicios_definitiva.pdf --- plugins/woocommerce/includes/wc-core-functions.php | 6 ++---- .../unit-tests/util/class-wc-tests-core-functions.php | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/plugins/woocommerce/includes/wc-core-functions.php b/plugins/woocommerce/includes/wc-core-functions.php index 23103042fb6..8da77c21419 100644 --- a/plugins/woocommerce/includes/wc-core-functions.php +++ b/plugins/woocommerce/includes/wc-core-functions.php @@ -631,8 +631,7 @@ function get_woocommerce_currencies() { 'USD' => __( 'United States (US) dollar', 'woocommerce' ), 'UYU' => __( 'Uruguayan peso', 'woocommerce' ), 'UZS' => __( 'Uzbekistani som', 'woocommerce' ), - 'VEF' => __( 'Venezuelan bolívar', 'woocommerce' ), - 'VES' => __( 'Bolívar soberano', 'woocommerce' ), + 'VES' => __( 'Venezuelan bolívar', 'woocommerce' ), 'VND' => __( 'Vietnamese đồng', 'woocommerce' ), 'VUV' => __( 'Vanuatu vatu', 'woocommerce' ), 'WST' => __( 'Samoan tālā', 'woocommerce' ), @@ -816,8 +815,7 @@ function get_woocommerce_currency_symbols() { 'USD' => '$', 'UYU' => '$', 'UZS' => 'UZS', - 'VEF' => 'Bs F', - 'VES' => 'Bs.S', + 'VES' => 'Bs.', 'VND' => '₫', 'VUV' => 'Vt', 'WST' => 'T', diff --git a/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php b/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php index 580d15e58f8..0c1f1edf915 100644 --- a/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php +++ b/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php @@ -193,8 +193,7 @@ class WC_Tests_Core_Functions extends WC_Unit_Test_Case { 'USD' => 'United States (US) dollar', 'UYU' => 'Uruguayan peso', 'UZS' => 'Uzbekistani som', - 'VEF' => 'Venezuelan bolívar', - 'VES' => 'Bolívar soberano', + 'VES' => 'Venezuelan bolívar', 'VND' => 'Vietnamese đồng', 'VUV' => 'Vanuatu vatu', 'WST' => 'Samoan tālā', From 4e1f95efbe47b44f46076222b1259874a0668580 Mon Sep 17 00:00:00 2001 From: Yordan Soares <38109855+YordanSoares@users.noreply.github.com> Date: Mon, 13 Dec 2021 00:40:14 -0400 Subject: [PATCH 2/9] =?UTF-8?q?Restore=20Bol=C3=ADvar=20Fuerte=20(VEF)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- plugins/woocommerce/includes/wc-core-functions.php | 2 ++ .../legacy/unit-tests/util/class-wc-tests-core-functions.php | 1 + 2 files changed, 3 insertions(+) diff --git a/plugins/woocommerce/includes/wc-core-functions.php b/plugins/woocommerce/includes/wc-core-functions.php index 8da77c21419..79a08ad7460 100644 --- a/plugins/woocommerce/includes/wc-core-functions.php +++ b/plugins/woocommerce/includes/wc-core-functions.php @@ -631,6 +631,7 @@ function get_woocommerce_currencies() { 'USD' => __( 'United States (US) dollar', 'woocommerce' ), 'UYU' => __( 'Uruguayan peso', 'woocommerce' ), 'UZS' => __( 'Uzbekistani som', 'woocommerce' ), + 'VEF' => __( 'Venezuelan bolívar (Bolívar fuerte)', 'woocommerce' ), 'VES' => __( 'Venezuelan bolívar', 'woocommerce' ), 'VND' => __( 'Vietnamese đồng', 'woocommerce' ), 'VUV' => __( 'Vanuatu vatu', 'woocommerce' ), @@ -815,6 +816,7 @@ function get_woocommerce_currency_symbols() { 'USD' => '$', 'UYU' => '$', 'UZS' => 'UZS', + 'VEF' => 'Bs F', 'VES' => 'Bs.', 'VND' => '₫', 'VUV' => 'Vt', diff --git a/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php b/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php index 0c1f1edf915..3bacc7400db 100644 --- a/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php +++ b/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php @@ -193,6 +193,7 @@ class WC_Tests_Core_Functions extends WC_Unit_Test_Case { 'USD' => 'United States (US) dollar', 'UYU' => 'Uruguayan peso', 'UZS' => 'Uzbekistani som', + 'VEF' => 'Venezuelan bolívar (Bolívar fuerte)', 'VES' => 'Venezuelan bolívar', 'VND' => 'Vietnamese đồng', 'VUV' => 'Vanuatu vatu', From e1749891c7869ea94326ee7ead9d9c5c2e42407c Mon Sep 17 00:00:00 2001 From: Yordan Soares <38109855+YordanSoares@users.noreply.github.com> Date: Fri, 22 Apr 2022 19:47:28 -0400 Subject: [PATCH 3/9] Use the price decimal separator to format product weight and dimensions --- .../woocommerce/includes/admin/class-wc-admin-assets.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/woocommerce/includes/admin/class-wc-admin-assets.php b/plugins/woocommerce/includes/admin/class-wc-admin-assets.php index 1ffac1ef198..47ebabf514c 100644 --- a/plugins/woocommerce/includes/admin/class-wc-admin-assets.php +++ b/plugins/woocommerce/includes/admin/class-wc-admin-assets.php @@ -541,11 +541,11 @@ if ( ! class_exists( 'WC_Admin_Assets', false ) ) : 'manage_suggestions_url' => admin_url( 'admin.php?page=wc-settings&tab=advanced§ion=woocommerce_com' ), 'in_app_purchase_params' => WC_Admin_Addons::get_in_app_purchase_url_params(), 'i18n_marketplace_suggestions_default_cta' - => esc_html__( 'Learn More', 'woocommerce' ), + => esc_html__( 'Learn More', 'woocommerce' ), 'i18n_marketplace_suggestions_dismiss_tooltip' - => esc_attr__( 'Dismiss this suggestion', 'woocommerce' ), + => esc_attr__( 'Dismiss this suggestion', 'woocommerce' ), 'i18n_marketplace_suggestions_manage_suggestions' - => esc_html__( 'Manage suggestions', 'woocommerce' ), + => esc_html__( 'Manage suggestions', 'woocommerce' ), ) ); wp_enqueue_script( 'marketplace-suggestions' ); From b2695fe22e55693298176c66876a4d10caf2e7c8 Mon Sep 17 00:00:00 2001 From: Yordan Soares <38109855+YordanSoares@users.noreply.github.com> Date: Fri, 22 Apr 2022 19:50:41 -0400 Subject: [PATCH 4/9] Revert "Use the price decimal separator to format product weight and dimensions" This reverts commit 31e6dcd43a278b87661f1d834172fe2db76f7b3b. --- .../woocommerce/includes/admin/class-wc-admin-assets.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/woocommerce/includes/admin/class-wc-admin-assets.php b/plugins/woocommerce/includes/admin/class-wc-admin-assets.php index 47ebabf514c..1ffac1ef198 100644 --- a/plugins/woocommerce/includes/admin/class-wc-admin-assets.php +++ b/plugins/woocommerce/includes/admin/class-wc-admin-assets.php @@ -541,11 +541,11 @@ if ( ! class_exists( 'WC_Admin_Assets', false ) ) : 'manage_suggestions_url' => admin_url( 'admin.php?page=wc-settings&tab=advanced§ion=woocommerce_com' ), 'in_app_purchase_params' => WC_Admin_Addons::get_in_app_purchase_url_params(), 'i18n_marketplace_suggestions_default_cta' - => esc_html__( 'Learn More', 'woocommerce' ), + => esc_html__( 'Learn More', 'woocommerce' ), 'i18n_marketplace_suggestions_dismiss_tooltip' - => esc_attr__( 'Dismiss this suggestion', 'woocommerce' ), + => esc_attr__( 'Dismiss this suggestion', 'woocommerce' ), 'i18n_marketplace_suggestions_manage_suggestions' - => esc_html__( 'Manage suggestions', 'woocommerce' ), + => esc_html__( 'Manage suggestions', 'woocommerce' ), ) ); wp_enqueue_script( 'marketplace-suggestions' ); From 94a4da8aa039bee1468875201bb93e73b17a4763 Mon Sep 17 00:00:00 2001 From: Peter Fabian Date: Thu, 4 May 2023 14:29:57 +0200 Subject: [PATCH 5/9] Added changelog. --- plugins/woocommerce/changelog/update-venezuelan-currency | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 plugins/woocommerce/changelog/update-venezuelan-currency diff --git a/plugins/woocommerce/changelog/update-venezuelan-currency b/plugins/woocommerce/changelog/update-venezuelan-currency new file mode 100644 index 00000000000..e04b7c2c650 --- /dev/null +++ b/plugins/woocommerce/changelog/update-venezuelan-currency @@ -0,0 +1,4 @@ +Significance: minor +Type: enhancement + +Update Venezuelan currency: Bolívar (Bs.). From c1c5c043226c42496cf2334c762fbc9fb0accd6d Mon Sep 17 00:00:00 2001 From: Yordan Soares <38109855+YordanSoares@users.noreply.github.com> Date: Thu, 17 Aug 2023 01:08:34 +0200 Subject: [PATCH 6/9] Update wc-core-functions.php --- plugins/woocommerce/includes/wc-core-functions.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/woocommerce/includes/wc-core-functions.php b/plugins/woocommerce/includes/wc-core-functions.php index 79a08ad7460..3ab480886db 100644 --- a/plugins/woocommerce/includes/wc-core-functions.php +++ b/plugins/woocommerce/includes/wc-core-functions.php @@ -631,7 +631,7 @@ function get_woocommerce_currencies() { 'USD' => __( 'United States (US) dollar', 'woocommerce' ), 'UYU' => __( 'Uruguayan peso', 'woocommerce' ), 'UZS' => __( 'Uzbekistani som', 'woocommerce' ), - 'VEF' => __( 'Venezuelan bolívar (Bolívar fuerte)', 'woocommerce' ), + 'VEF' => __( 'Venezuelan bolívar (2008–2018)', 'woocommerce' ), 'VES' => __( 'Venezuelan bolívar', 'woocommerce' ), 'VND' => __( 'Vietnamese đồng', 'woocommerce' ), 'VUV' => __( 'Vanuatu vatu', 'woocommerce' ), From bc0343b7dc6ac879a574a9cbf9dcaca3dc6f7c3a Mon Sep 17 00:00:00 2001 From: Yordan Soares <38109855+YordanSoares@users.noreply.github.com> Date: Thu, 17 Aug 2023 01:08:41 +0200 Subject: [PATCH 7/9] Update class-wc-tests-core-functions.php --- .../legacy/unit-tests/util/class-wc-tests-core-functions.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php b/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php index 3bacc7400db..ddfea9eed70 100644 --- a/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php +++ b/plugins/woocommerce/tests/legacy/unit-tests/util/class-wc-tests-core-functions.php @@ -193,7 +193,7 @@ class WC_Tests_Core_Functions extends WC_Unit_Test_Case { 'USD' => 'United States (US) dollar', 'UYU' => 'Uruguayan peso', 'UZS' => 'Uzbekistani som', - 'VEF' => 'Venezuelan bolívar (Bolívar fuerte)', + 'VEF' => 'Venezuelan bolívar (2008–2018)', 'VES' => 'Venezuelan bolívar', 'VND' => 'Vietnamese đồng', 'VUV' => 'Vanuatu vatu', From c594fc7d858ad422a6647d80ec57fc3349d754c8 Mon Sep 17 00:00:00 2001 From: barryhughes <3594411+barryhughes@users.noreply.github.com> Date: Fri, 18 Aug 2023 09:30:55 -0700 Subject: [PATCH 8/9] Update API tests following changes to VES and VEF currencies. --- .../tests/api-core-tests/tests/data/data-crud.test.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/woocommerce/tests/api-core-tests/tests/data/data-crud.test.js b/plugins/woocommerce/tests/api-core-tests/tests/data/data-crud.test.js index b25231e80c4..08edbe83848 100644 --- a/plugins/woocommerce/tests/api-core-tests/tests/data/data-crud.test.js +++ b/plugins/woocommerce/tests/api-core-tests/tests/data/data-crud.test.js @@ -6016,7 +6016,7 @@ test.describe('Data API tests', () => { expect(responseJSON).toEqual(expect.arrayContaining([ expect.objectContaining({ "code": "VEF", - "name": "Venezuelan bolívar", + "name": "Venezuelan bolívar (2008–2018)", "symbol": "Bs F", "_links": { "self": [{ @@ -6031,8 +6031,8 @@ test.describe('Data API tests', () => { expect(responseJSON).toEqual(expect.arrayContaining([ expect.objectContaining({ "code": "VES", - "name": "Bolívar soberano", - "symbol": "Bs.S", + "name": "Venezuelan bolívar", + "symbol": "Bs.", "_links": { "self": [{ "href": expect.stringContaining("data/currencies/VES") From e7aaa3bddd58d565aebfff09b4719bd619c345db Mon Sep 17 00:00:00 2001 From: barryhughes <3594411+barryhughes@users.noreply.github.com> Date: Tue, 22 Aug 2023 11:39:28 -0700 Subject: [PATCH 9/9] Update expectations for VES and VEF currencies. --- plugins/woocommerce/tests/api-core-tests/data/settings.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/woocommerce/tests/api-core-tests/data/settings.js b/plugins/woocommerce/tests/api-core-tests/data/settings.js index f635f7d5e0a..1c438f874a3 100644 --- a/plugins/woocommerce/tests/api-core-tests/data/settings.js +++ b/plugins/woocommerce/tests/api-core-tests/data/settings.js @@ -158,8 +158,8 @@ const currencies = { "USD": "United States (US) dollar ($)", "UYU": "Uruguayan peso ($)", "UZS": "Uzbekistani som (UZS)", - "VEF": "Venezuelan bolívar (Bs F)", - "VES": "Bolívar soberano (Bs.S)", + "VEF": "Venezuelan bolívar (2008–2018) (Bs F)", + "VES": "Venezuelan bolívar (Bs.)", "VND": "Vietnamese đồng (₫)", "VUV": "Vanuatu vatu (Vt)", "WST": "Samoan tālā (T)",