Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cache empty suggestions if API fails, to reduce congestion/thrashing + 

+ don't use wp_remote_safe_get – overkill
+ use wp_send_json_success to streamline/simplify API data ajax handler
This commit is contained in:
haszari 2019-02-21 10:20:58 +13:00
parent e37583bb2b
commit dd27bf278b
1 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
includes/marketplace-suggestions/class-wc-marketplace-suggestions-api.php
View File

@ -16,30 +16,29 @@ defined( 'ABSPATH' ) || exit;
* @return array of json API data
*/
function wc_marketplace_suggestions_get_api_data() {
$suggestion_data_url = 'https://d3t0oesq8995hv.cloudfront.net/add-ons/marketplace-suggestions.json';
$suggestion_data = get_transient( 'wc_marketplace_suggestions' );
if ( false !== $suggestion_data ) {
return $suggestion_data;
}
$raw_suggestions = wp_safe_remote_get(
$suggestion_data_url = 'https://d3t0oesq8995hv.cloudfront.net/add-ons/marketplace-suggestions.json';
$raw_suggestions = wp_remote_get(
$suggestion_data_url,
array( 'user-agent' => 'WooCommerce Marketplace Suggestions' )
);
if ( is_wp_error( $raw_suggestions ) ) {
return array();
}
// Parse the data to check for any errors.
// If it's valid, store structure in transient.
$suggestions = json_decode( wp_remote_retrieve_body( $raw_suggestions ) );
if ( $suggestions && is_array( $suggestions ) ) {
set_transient( 'wc_marketplace_suggestions', $suggestions, WEEK_IN_SECONDS );
return $suggestions;
if ( ! is_wp_error( $raw_suggestions ) ) {
$suggestions = json_decode( wp_remote_retrieve_body( $raw_suggestions ) );
if ( $suggestions && is_array( $suggestions ) ) {
set_transient( 'wc_marketplace_suggestions', $suggestions, WEEK_IN_SECONDS );
return $suggestions;
}
}
// Cache empty suggestions data to reduce requests if there are any issues with API.
set_transient( 'wc_marketplace_suggestions', '[]', DAY_IN_SECONDS );
return array();
}
@ -48,10 +47,7 @@ function wc_marketplace_suggestions_get_api_data() {
*/
function wc_marketplace_suggestions_ajax_handler() {
$suggestion_data = wc_marketplace_suggestions_get_api_data();
echo wp_json_encode( $suggestion_data );
wp_die();
wp_send_json_success( $suggestion_data );
}