From f33283306efc7db9b07d74b0613d24f8dd1b9863 Mon Sep 17 00:00:00 2001 From: faisal-alvi Date: Wed, 19 Apr 2023 14:30:23 +0530 Subject: [PATCH 1/3] Remove `aria-disabled` from `Update Cart` button --- plugins/woocommerce/client/legacy/js/frontend/cart.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/woocommerce/client/legacy/js/frontend/cart.js b/plugins/woocommerce/client/legacy/js/frontend/cart.js index cdee33f5d79..c1bc3474550 100644 --- a/plugins/woocommerce/client/legacy/js/frontend/cart.js +++ b/plugins/woocommerce/client/legacy/js/frontend/cart.js @@ -127,7 +127,7 @@ jQuery( function( $ ) { } $( '.woocommerce-cart-form' ).replaceWith( $new_form ); - $( '.woocommerce-cart-form' ).find( ':input[name="update_cart"]' ).prop( 'disabled', true ).attr( 'aria-disabled', true ); + $( '.woocommerce-cart-form' ).find( ':input[name="update_cart"]' ).prop( 'disabled', true ); if ( $notices.length > 0 ) { show_notice( $notices ); @@ -327,14 +327,14 @@ jQuery( function( $ ) { '.woocommerce-cart-form .cart_item :input', this.input_changed ); - $( '.woocommerce-cart-form :input[name="update_cart"]' ).prop( 'disabled', true ).attr( 'aria-disabled', true ); + $( '.woocommerce-cart-form :input[name="update_cart"]' ).prop( 'disabled', true ); }, /** * After an input is changed, enable the update cart button. */ input_changed: function() { - $( '.woocommerce-cart-form :input[name="update_cart"]' ).prop( 'disabled', false ).attr( 'aria-disabled', false ); + $( '.woocommerce-cart-form :input[name="update_cart"]' ).prop( 'disabled', false ); }, /** From cb1baac1c5f748f52be64615bddb9e96da63d9bd Mon Sep 17 00:00:00 2001 From: faisal-alvi Date: Wed, 19 Apr 2023 14:38:27 +0530 Subject: [PATCH 2/3] adding a changelog --- plugins/woocommerce/changelog/fix-37600 | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 plugins/woocommerce/changelog/fix-37600 diff --git a/plugins/woocommerce/changelog/fix-37600 b/plugins/woocommerce/changelog/fix-37600 new file mode 100644 index 00000000000..8a94aa99280 --- /dev/null +++ b/plugins/woocommerce/changelog/fix-37600 @@ -0,0 +1,4 @@ +Significance: patch +Type: fix + +The "Update Cart" button does not need an aria-disabled attribute, as it has a disabled attribute, this PR removes it. \ No newline at end of file From e5c306db3d0c99861b301edd62cf326983a53cfd Mon Sep 17 00:00:00 2001 From: Faisal Alvi Date: Wed, 19 Apr 2023 15:48:02 +0530 Subject: [PATCH 3/3] Update fix-37600 --- plugins/woocommerce/changelog/fix-37600 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/woocommerce/changelog/fix-37600 b/plugins/woocommerce/changelog/fix-37600 index 8a94aa99280..73f0f3a001c 100644 --- a/plugins/woocommerce/changelog/fix-37600 +++ b/plugins/woocommerce/changelog/fix-37600 @@ -1,4 +1,4 @@ Significance: patch Type: fix -The "Update Cart" button does not need an aria-disabled attribute, as it has a disabled attribute, this PR removes it. \ No newline at end of file +Removed aria-disabled attribute from "Update Cart" button as it already has a disabled attribute.