Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #27763 from woocommerce/fix/27445 

Remove protection as we already diff and update only if needed.
This commit is contained in:
Néstor Soriano 2020-10-15 10:01:34 +02:00 committed by GitHub
parent 5daf39e169 d51dd26816
commit e4a109f0d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
includes/admin/wc-admin-functions.php
View File

@ -210,7 +210,7 @@ function wc_maybe_adjust_line_item_product_stock( $item, $item_quantity = -1 ) {
$item_quantity = wc_stock_amount( $item_quantity >= 0 ? $item_quantity : $item->get_quantity() );
$already_reduced_stock = wc_stock_amount( $item->get_meta( '_reduced_stock', true ) );
if ( ! $product || ! $product->managing_stock() || ! $already_reduced_stock || $item_quantity === $already_reduced_stock ) {
if ( ! $product || ! $product->managing_stock() ) {
return false;
}

28
tests/php/includes/admin/wc-admin-functions-test.php → tests/php/includes/admin/class-wc-admin-functions-test.php
View File

@ -41,4 +41,32 @@ class WC_Admin_Functions_Test extends \WC_Unit_Test_Case {
// Restore REQUEST_URI.
$_SERVER['REQUEST_URI'] = $default_uri;
}
/**
* Test adjust line item function when order does not have meta `_reduced_stock` already.
*
* @link https://github.com/woocommerce/woocommerce/issues/27445.
*/
public function test_wc_maybe_adjust_line_item_product_stock() {
$product = WC_Helper_Product::create_simple_product();
$product->set_manage_stock( true );
$product->set_stock_quantity( 1000 );
$product->save();
$order = WC_Helper_Order::create_order();
$order->set_status( 'processing' );
$order_item_id = $order->add_product( $product, 10 );
// Stocks have not reduced yet.
$product = wc_get_product( $product->get_id() );
$this->assertEquals( 1000, $product->get_stock_quantity() );
$order_item = new WC_Order_Item_Product( $order_item_id );
wc_maybe_adjust_line_item_product_stock( $order_item );
// Stocks should have been reduced now.
$product = wc_get_product( $product->get_id() );
$this->assertEquals( 990, $product->get_stock_quantity() );
}
}

1
tests/php/includes/class-wc-ajax-test.php
View File

@ -84,5 +84,4 @@ class WC_AJAX_Test extends \WC_Unit_Test_Case {
}
}
}
}