Merge pull request #12604 from woocommerce/fix-12509

[2.6] [REST API] Throw exception when product image ID is not a valid attachment
This commit is contained in:
Claudio Sanches 2016-12-15 13:43:56 -02:00 committed by GitHub
commit e5290fef79
1 changed files with 4 additions and 0 deletions

View File

@ -844,6 +844,10 @@ class WC_REST_Products_Controller extends WC_REST_Posts_Controller {
$attachment_id = wc_rest_set_uploaded_image_as_attachment( $upload, $product->get_id() );
}
if ( ! wp_attachment_is_image( $attachment_id ) ) {
throw new WC_REST_Exception( 'woocommerce_product_ĩnvalid_image_id', sprintf( __( '#%s is an invalid image ID.', 'woocommerce' ), $attachment_id ), 400 );
}
if ( isset( $image['position'] ) && 0 === $image['position'] ) {
$product->set_image_id( $attachment_id );
} else {