Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Break up logic so is callable is only checked on internal meta keys

This commit is contained in:
Mike Jolley 2017-10-27 16:23:05 +01:00
parent 32da25c4f1
commit e72a297842
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
includes/abstracts/abstract-wc-data.php
View File

@ -270,20 +270,27 @@ abstract class WC_Data {
* Check if the key is an internal one. * Check if the key is an internal one.
* *
* @since 3.2.0 * @since 3.2.0
* @param string $key * @param string $key Key to check.
* @return bool true if it's an internal key, false otherwise * @return bool true if it's an internal key, false otherwise
*/ */
protected function is_internal_meta_key( $key ) { protected function is_internal_meta_key( $key ) {
$internal_meta_key = ! empty( $key ) && $this->data_store && in_array( $key, $this->data_store->get_internal_meta_keys() );
if ( ! $internal_meta_key ) {
return false;
}
$has_setter_or_getter = is_callable( array( $this, 'set_' . $key ) ) || is_callable( array( $this, 'get_' . $key ) ); $has_setter_or_getter = is_callable( array( $this, 'set_' . $key ) ) || is_callable( array( $this, 'get_' . $key ) );
if ( $has_setter_or_getter && $this->data_store && ! empty( $key ) && in_array( $key, $this->data_store->get_internal_meta_keys() ) ) {
if ( ! $has_setter_or_getter ) {
return false;
}
wc_doing_it_wrong( __FUNCTION__, sprintf( __( 'Generic add/update/get meta methods should not be used for internal meta data, including "%s". Use getters and setters.', 'woocommerce' ), $key ), '3.2.0' ); wc_doing_it_wrong( __FUNCTION__, sprintf( __( 'Generic add/update/get meta methods should not be used for internal meta data, including "%s". Use getters and setters.', 'woocommerce' ), $key ), '3.2.0' );
return true; return true;
} }
return false;
}
/** /**
* Get Meta Data by Key. * Get Meta Data by Key.
* *