From e770aef3feb695add659c1738b0f9e793c001d54 Mon Sep 17 00:00:00 2001 From: RJ <27843274+rjchow@users.noreply.github.com> Date: Fri, 9 Aug 2024 23:57:24 +0800 Subject: [PATCH] fix: wcadmin react18 createroot print shipping banner (#48831) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: André Kallehauge <3846700+kallehauge@users.noreply.github.com> --- .../wp-admin-scripts/print-shipping-label-banner/index.js | 7 +++++-- .../fix-wcadmin-react18-createroot-print-shipping-banner | 4 ++++ 2 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 plugins/woocommerce/changelog/fix-wcadmin-react18-createroot-print-shipping-banner diff --git a/plugins/woocommerce-admin/client/wp-admin-scripts/print-shipping-label-banner/index.js b/plugins/woocommerce-admin/client/wp-admin-scripts/print-shipping-label-banner/index.js index f71b921073d..a1b6a03c11f 100644 --- a/plugins/woocommerce-admin/client/wp-admin-scripts/print-shipping-label-banner/index.js +++ b/plugins/woocommerce-admin/client/wp-admin-scripts/print-shipping-label-banner/index.js @@ -1,7 +1,7 @@ /** * External dependencies */ -import { render } from '@wordpress/element'; +import { createRoot } from '@wordpress/element'; import { withPluginsHydration } from '@woocommerce/data'; /** @@ -19,4 +19,7 @@ const HydratedShippingBanner = withPluginsHydration( { ...getAdminSetting( 'plugins' ), jetpackStatus: getAdminSetting( 'dataEndpoints', {} ).jetpackStatus, } )( ShippingBanner ); -render( , metaBox ); + +createRoot( metaBox ).render( + +); diff --git a/plugins/woocommerce/changelog/fix-wcadmin-react18-createroot-print-shipping-banner b/plugins/woocommerce/changelog/fix-wcadmin-react18-createroot-print-shipping-banner new file mode 100644 index 00000000000..a42519f5094 --- /dev/null +++ b/plugins/woocommerce/changelog/fix-wcadmin-react18-createroot-print-shipping-banner @@ -0,0 +1,4 @@ +Significance: patch +Type: fix + +Changed from using React.render to React.createRoot for print shipping banner as it has been deprecated since React 18 \ No newline at end of file