Upgrade TypeScript to v5.1 (#39531)

2023-08-08 12:35:31 +08:00 · 2023-08-08 12:35:31 +08:00 · e8c3808527
parent 428feb58a7
commit e8c3808527
61 changed files with 628 additions and 514 deletions
--- a/.syncpackrc
+++ b/.syncpackrc
@ -76,7 +76,7 @@
 			"packages": [
 				"**"
 			],
-			"pinVersion": "^4.9.5"
+			"pinVersion": "^5.1.6"
 		},
 		{
 			"dependencies": [
--- a/package.json
+++ b/package.json
@ -60,7 +60,7 @@
 		"sass-loader": "^10.4.1",
 		"syncpack": "^10.7.3",
 		"turbo": "^1.10.7",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"url-loader": "^1.1.2",
 		"webpack": "^5.76.2"
 	},
--- a/packages/js/admin-e2e-tests/changelog/dev-upgrade-ts-5
+++ b/packages/js/admin-e2e-tests/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/admin-e2e-tests/package.json
+++ b/packages/js/admin-e2e-tests/package.json
@ -50,7 +50,7 @@
 		"jest-mock-extended": "^1.0.18",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"publishConfig": {
 		"access": "public"
--- a/packages/js/admin-layout/changelog/dev-upgrade-ts-5
+++ b/packages/js/admin-layout/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/admin-layout/package.json
+++ b/packages/js/admin-layout/package.json
@ -56,7 +56,7 @@
 		"react-dom": "^17.0.2",
 		"sass-loader": "^10.2.1",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"webpack": "^5.70.0",
 		"webpack-cli": "^3.3.12"
 	},
--- a/packages/js/ai/changelog/dev-upgrade-ts-5
+++ b/packages/js/ai/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/ai/package.json
+++ b/packages/js/ai/package.json
@ -67,7 +67,7 @@
 		"rimraf": "^3.0.2",
 		"sass-loader": "^10.2.1",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"webpack": "^5.70.0",
 		"webpack-cli": "^3.3.12"
 	},
--- a/packages/js/api/changelog/dev-upgrade-ts-5
+++ b/packages/js/api/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/api/package.json
+++ b/packages/js/api/package.json
@ -1,6 +1,6 @@
 {
 	"name": "@woocommerce/api",
-	"version": "0.2.0",
+	"version": "0.3.0",
 	"author": "Automattic",
 	"description": "A simple interface for interacting with a WooCommerce installation.",
 	"homepage": "https://github.com/woocommerce/woocommerce/tree/trunk/packages/js/api/README.md",
@ -58,7 +58,7 @@
 		"eslint": "^8.32.0",
 		"jest": "^27",
 		"ts-jest": "^27",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"publishConfig": {
 		"access": "public"
--- a/packages/js/api/tsconfig.json
+++ b/packages/js/api/tsconfig.json
@ -1,14 +1,11 @@
 {
 	"extends": "../../../tsconfig.base.json",
 	"compilerOptions": {
-		"types": [ "node", "jest", "axios", "create-hmac" ],
+		"types": [ "node", "jest", "create-hmac" ],
 		"rootDir": "src",
 		"outDir": "dist",
 		"target": "es5",
-		"typeRoots": [
-			"./typings",
-			"./node_modules/@types"
-		]
+		"typeRoots": [ "./node_modules/@types" ]
 	},
 	"include": [ "src/" ]
 }
--- a/packages/js/components/changelog/dev-upgrade-ts-5
+++ b/packages/js/components/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/components/package.json
+++ b/packages/js/components/package.json
@ -141,7 +141,8 @@
 		"react": "^17.0.2",
 		"rimraf": "^3.0.2",
 		"sass-loader": "^10.2.1",
-		"ts-jest": "^27.1.3",
+		"ts-jest": "^29.1.1",
+		"typescript": "^5.1.6",
 		"uuid": "^8.3.0",
 		"webpack": "^5.70.0",
 		"webpack-cli": "^3.3.12"
--- a/packages/js/components/src/experimental-select-control/select-control.tsx
+++ b/packages/js/components/src/experimental-select-control/select-control.tsx
@ -181,6 +181,7 @@ function SelectControl< ItemType = DefaultItemType >( {
 		highlightedIndex,
 		getItemProps,
 		selectItem,
+		// @ts-expect-error - TODO fix this type.
 		selectedItem: comboboxSingleSelectedItem,
 		openMenu,
 		closeMenu,
@ -203,6 +204,7 @@ function SelectControl< ItemType = DefaultItemType >( {
 				onInputChange( value, changes );
 			}
 		},
+		// @ts-expect-error - TODO fix this type.
 		stateReducer: ( state, actionAndChanges ) => {
 			const { changes, type } = actionAndChanges;
 			let newChanges;
--- a/packages/js/csv-export/changelog/dev-upgrade-ts-5
+++ b/packages/js/csv-export/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/csv-export/package.json
+++ b/packages/js/csv-export/package.json
@ -58,7 +58,7 @@
 		"concurrently": "^7.0.0",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"lint-staged": {
 		"*.(t|j)s?(x)": [
--- a/packages/js/currency/changelog/dev-upgrade-ts-5
+++ b/packages/js/currency/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/currency/package.json
+++ b/packages/js/currency/package.json
@ -61,7 +61,7 @@
 		"concurrently": "^7.0.0",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"lint-staged": {
 		"*.(t|j)s?(x)": [
--- a/packages/js/customer-effort-score/changelog/dev-upgrade-ts-5
+++ b/packages/js/customer-effort-score/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/customer-effort-score/package.json
+++ b/packages/js/customer-effort-score/package.json
@ -64,7 +64,7 @@
 		"rimraf": "^3.0.2",
 		"sass-loader": "^10.2.1",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"webpack": "^5.70.0",
 		"webpack-cli": "^3.3.12"
 	},
--- a/packages/js/data/changelog/dev-upgrade-ts-5
+++ b/packages/js/data/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/data/package.json
+++ b/packages/js/data/package.json
@ -71,7 +71,7 @@
 		"redux": "^4.1.0",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"peerDependencies": {
 		"@wordpress/core-data": "wp-6.0",
--- a/packages/js/date/changelog/dev-upgrade-ts-5
+++ b/packages/js/date/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/date/package.json
+++ b/packages/js/date/package.json
@ -48,7 +48,7 @@
 		"concurrently": "^7.0.0",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"peerDependencies": {
 		"lodash": "^4.17.0"
--- a/packages/js/dependency-extraction-webpack-plugin/changelog/dev-upgrade-ts-5
+++ b/packages/js/dependency-extraction-webpack-plugin/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/dependency-extraction-webpack-plugin/package.json
+++ b/packages/js/dependency-extraction-webpack-plugin/package.json
@ -35,7 +35,7 @@
 		"jest-cli": "^27.5.1",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"webpack": "^5.70.0",
 		"webpack-cli": "^3.3.12"
 	},
--- a/packages/js/eslint-plugin/changelog/dev-upgrade-ts-5
+++ b/packages/js/eslint-plugin/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/eslint-plugin/package.json
+++ b/packages/js/eslint-plugin/package.json
@ -53,7 +53,7 @@
 		"jest-cli": "^27.5.1",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"lint-staged": {
 		"*.(t|j)s?(x)": [
--- a/packages/js/experimental/changelog/dev-upgrade-ts-5
+++ b/packages/js/experimental/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/experimental/package.json
+++ b/packages/js/experimental/package.json
@ -74,7 +74,7 @@
 		"rimraf": "^3.0.2",
 		"sass-loader": "^10.2.1",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"webpack": "^5.70.0",
 		"webpack-cli": "^3.3.12"
 	},
--- a/packages/js/explat/changelog/dev-upgrade-ts-5
+++ b/packages/js/explat/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/explat/package.json
+++ b/packages/js/explat/package.json
@ -52,7 +52,7 @@
 		"concurrently": "^7.0.0",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"scripts": {
 		"turbo:build": "tsc --project tsconfig.json && tsc --project tsconfig-cjs.json",
--- a/packages/js/internal-js-tests/package.json
+++ b/packages/js/internal-js-tests/package.json
@ -47,7 +47,7 @@
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
 		"babel-jest": "^27.5.1",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"lint-staged": {
 		"*.(t|j)s?(x)": [
--- a/packages/js/internal-style-build/package.json
+++ b/packages/js/internal-style-build/package.json
@ -45,7 +45,7 @@
 		"jest-cli": "^27.5.1",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"webpack": "^5.70.0"
 	},
 	"lint-staged": {
--- a/packages/js/navigation/changelog/dev-upgrade-ts-5
+++ b/packages/js/navigation/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/navigation/package.json
+++ b/packages/js/navigation/package.json
@ -71,7 +71,7 @@
 		"concurrently": "^7.0.0",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"lint-staged": {
 		"*.(t|j)s?(x)": [
--- a/packages/js/notices/package.json
+++ b/packages/js/notices/package.json
@ -63,7 +63,7 @@
 		"redux": "^4.2.0",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"lint-staged": {
 		"*.(t|j)s?(x)": [
--- a/packages/js/number/changelog/dev-upgrade-ts-5
+++ b/packages/js/number/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/number/package.json
+++ b/packages/js/number/package.json
@ -57,7 +57,7 @@
 		"concurrently": "^7.0.0",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"lint-staged": {
 		"*.(t|j)s?(x)": [
--- a/packages/js/onboarding/changelog/dev-upgrade-ts-5
+++ b/packages/js/onboarding/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/onboarding/package.json
+++ b/packages/js/onboarding/package.json
@ -60,7 +60,7 @@
 		"rimraf": "^3.0.2",
 		"sass-loader": "^10.2.1",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"webpack": "^5.70.0",
 		"webpack-cli": "^3.3.12"
 	},
--- a/packages/js/product-editor/changelog/dev-upgrade-ts-5
+++ b/packages/js/product-editor/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/product-editor/package.json
+++ b/packages/js/product-editor/package.json
@ -109,7 +109,7 @@
 		"rimraf": "^3.0.2",
 		"sass-loader": "^10.2.1",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"webpack": "^5.70.0",
 		"webpack-cli": "^3.3.12"
 	},
--- a/packages/js/tracks/changelog/dev-upgrade-ts-5
+++ b/packages/js/tracks/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/packages/js/tracks/package.json
+++ b/packages/js/tracks/package.json
@ -52,7 +52,7 @@
 		"concurrently": "^7.0.0",
 		"rimraf": "^3.0.2",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"lint-staged": {
 		"*.(t|j)s?(x)": [
--- a/plugins/woo-ai/changelog/dev-upgrade-ts-5
+++ b/plugins/woo-ai/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/plugins/woo-ai/package.json
+++ b/plugins/woo-ai/package.json
@ -23,7 +23,7 @@
 		"eslint": "^8.32.0",
 		"prettier": "npm:wp-prettier@^2.6.2",
 		"ts-loader": "^9.4.1",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"uglify-js": "^3.5.3"
 	},
 	"dependencies": {
--- a/plugins/woocommerce-admin/client/core-profiler/index.tsx
+++ b/plugins/woocommerce-admin/client/core-profiler/index.tsx
@ -314,6 +314,7 @@ const getGeolocation = async ( context: CoreProfilerStateMachineContext ) => {
 };

 const preFetchGeolocation = assign( {
+	// @ts-expect-error -- TODO fix this type issue.
 	spawnGeolocationRef: ( context: CoreProfilerStateMachineContext ) =>
 		spawn(
 			() => getGeolocation( context ),
@ -380,6 +381,7 @@ const updateOnboardingProfileOption = (
 };

 const spawnUpdateOnboardingProfileOption = assign( {
+	// @ts-expect-error -- TODO fix this type issue.
 	spawnUpdateOnboardingProfileOptionRef: (
 		context: CoreProfilerStateMachineContext
 	) =>
@ -431,6 +433,7 @@ const updateBusinessInfo = async (
 };

 const persistBusinessInfo = assign( {
+	// @ts-expect-error -- TODO fix this type issue.
 	persistBusinessInfoRef: (
 		context: CoreProfilerStateMachineContext,
 		event: BusinessInfoEvent
--- a/plugins/woocommerce-admin/package.json
+++ b/plugins/woocommerce-admin/package.json
@ -193,7 +193,7 @@
 		"eslint-plugin-react": "^7.29.2",
 		"eslint-plugin-xstate": "^1.1.0",
 		"expose-loader": "^3.1.0",
-		"fork-ts-checker-webpack-plugin": "^6.5.0",
+		"fork-ts-checker-webpack-plugin": "^8.0.0",
 		"jest": "^27.5.1",
 		"jest-environment-jsdom": "~27.5.0",
 		"jest-environment-node": "^27.5.1",
@ -222,7 +222,7 @@
 		"style-loader": "^0.23.1",
 		"stylelint": "^14.5.3",
 		"ts-jest": "^27.1.3",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"url-loader": "^1.1.2",
 		"webpack": "^5.70.0",
 		"webpack-bundle-analyzer": "^3.9.0",
--- a/plugins/woocommerce-beta-tester/changelog/dev-upgrade-ts-5
+++ b/plugins/woocommerce-beta-tester/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/plugins/woocommerce-beta-tester/package.json
+++ b/plugins/woocommerce-beta-tester/package.json
@ -21,7 +21,7 @@
 		"eslint": "^8.32.0",
 		"prettier": "npm:wp-prettier@^2.8.5",
 		"ts-loader": "^9.4.1",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"uglify-js": "^3.5.3"
 	},
 	"dependencies": {
--- a/plugins/woocommerce-docs/package.json
+++ b/plugins/woocommerce-docs/package.json
@ -35,6 +35,6 @@
 		"prettier": "npm:wp-prettier@^2.6.2",
 		"ts-loader": "^9.4.1",
 		"ts-node": "^10.9.1",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	}
 }
--- a/plugins/woocommerce/changelog/dev-upgrade-ts-5
+++ b/plugins/woocommerce/changelog/dev-upgrade-ts-5
@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Upgrade TypeScript to 5.1.6
--- a/plugins/woocommerce/package.json
+++ b/plugins/woocommerce/package.json
@ -92,7 +92,7 @@
 		"mocha": "7.2.0",
 		"prettier": "npm:wp-prettier@^2.8.5",
 		"stylelint": "^13.8.0",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"uuid": "^8.3.2",
 		"webpack": "5.70.0",
 		"webpack-cli": "3.3.12",
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
--- a/tools/code-analyzer/package.json
+++ b/tools/code-analyzer/package.json
@ -24,7 +24,7 @@
 		"eslint": "^8.32.0",
 		"ts-node": "^10.2.1",
 		"tslib": "^2.3.1",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"scripts": {
 		"lint": "eslint . --ext .ts",
--- a/tools/monorepo-merge/package.json
+++ b/tools/monorepo-merge/package.json
@ -33,7 +33,7 @@
 		"shx": "^0.3.3",
 		"ts-node": "^10.2.1",
 		"tslib": "^2.3.1",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"oclif": {
 		"bin": "monorepo-merge",
--- a/tools/monorepo-utils/package.json
+++ b/tools/monorepo-utils/package.json
@ -38,7 +38,7 @@
 		"eslint": "^8.32.0",
 		"jest": "^29.5.0",
 		"ts-jest": "^29.1.0",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"scripts": {
 		"build": "tsc",
--- a/tools/package-release/package.json
+++ b/tools/package-release/package.json
@ -31,7 +31,7 @@
 		"shx": "^0.3.3",
 		"ts-node": "^10.2.1",
 		"tslib": "^2.3.1",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"oclif": {
 		"bin": "package-release",
--- a/tools/release-posts/package.json
+++ b/tools/release-posts/package.json
@ -21,7 +21,7 @@
 		"@types/node": "^16.18.18",
 		"@types/node-fetch": "^2.6.2",
 		"@types/semver": "^7.3.10",
-		"typescript": "^4.9.5"
+		"typescript": "^5.1.6"
 	},
 	"dependencies": {
 		"@commander-js/extra-typings": "^0.1.0",
--- a/tools/storybook/package.json
+++ b/tools/storybook/package.json
@ -48,7 +48,7 @@
 		"@woocommerce/eslint-plugin": "workspace:*",
 		"react": "^17.0.2",
 		"react-dom": "^17.0.2",
-		"typescript": "^4.9.5",
+		"typescript": "^5.1.6",
 		"webpack": "^5.70.0"
 	},
 	"dependencies": {