Removed Unnecessary `run` Usage
Since `pnpm` defaults to `run` unless a built-in command exists we don't really need to use `run`.
This commit is contained in:
parent
a82e646157
commit
e9484c33f4
|
@ -35,7 +35,7 @@ Please take a moment to review the [project readme](https://github.com/woocommer
|
||||||
|
|
||||||
- Ensure you stick to the [WordPress Coding Standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/).
|
- Ensure you stick to the [WordPress Coding Standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/).
|
||||||
- Run our build process described in the document on [how to set up WooCommerce development environment](https://github.com/woocommerce/woocommerce/wiki/How-to-set-up-WooCommerce-development-environment), it will install our pre-commit hook, code sniffs, dependencies, and more.
|
- Run our build process described in the document on [how to set up WooCommerce development environment](https://github.com/woocommerce/woocommerce/wiki/How-to-set-up-WooCommerce-development-environment), it will install our pre-commit hook, code sniffs, dependencies, and more.
|
||||||
- Before pushing commits to GitHub, check your code against our code standards. For PHP code in the WooCommerce Core project you can do this by running `pnpm --filter=@woocommerce/plugin-woocommerce run lint:php:changes:branch`.
|
- Before pushing commits to GitHub, check your code against our code standards. For PHP code in the WooCommerce Core project you can do this by running `pnpm --filter=@woocommerce/plugin-woocommerce lint:php:changes:branch`.
|
||||||
- Whenever possible, please fix pre-existing code standards errors in code that you change.
|
- Whenever possible, please fix pre-existing code standards errors in code that you change.
|
||||||
- Please consider adding appropriate tests related to your change if applicable such as unit, API and E2E tests. You can check the following guides for this purpose:
|
- Please consider adding appropriate tests related to your change if applicable such as unit, API and E2E tests. You can check the following guides for this purpose:
|
||||||
- [Writing unit tests](https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/tests/README.md#guide-for-writing-unit-tests).
|
- [Writing unit tests](https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/tests/README.md#guide-for-writing-unit-tests).
|
||||||
|
|
|
@ -25,5 +25,5 @@ runs:
|
||||||
working-directory: plugins/woocommerce
|
working-directory: plugins/woocommerce
|
||||||
shell: bash
|
shell: bash
|
||||||
run: |
|
run: |
|
||||||
pnpm env:dev --filter=@woocommerce/plugin-woocommerce
|
pnpm --filter=@woocommerce/plugin-woocommerce env:dev
|
||||||
pnpm env:performance-init --filter=@woocommerce/plugin-woocommerce
|
pnpm --filter=@woocommerce/plugin-woocommerce env:performance-init
|
||||||
|
|
|
@ -32,7 +32,7 @@ jobs:
|
||||||
working-directory: plugins/woocommerce
|
working-directory: plugins/woocommerce
|
||||||
env:
|
env:
|
||||||
ENABLE_HPOS: 1
|
ENABLE_HPOS: 1
|
||||||
run: pnpm env:test:cot --filter=@woocommerce/plugin-woocommerce
|
run: pnpm --filter=@woocommerce/plugin-woocommerce env:test:cot
|
||||||
|
|
||||||
- name: Download and install Chromium browser.
|
- name: Download and install Chromium browser.
|
||||||
working-directory: plugins/woocommerce
|
working-directory: plugins/woocommerce
|
||||||
|
@ -91,7 +91,7 @@ jobs:
|
||||||
working-directory: plugins/woocommerce
|
working-directory: plugins/woocommerce
|
||||||
env:
|
env:
|
||||||
ENABLE_HPOS: 1
|
ENABLE_HPOS: 1
|
||||||
run: pnpm env:test:cot --filter=@woocommerce/plugin-woocommerce
|
run: pnpm --filter=@woocommerce/plugin-woocommerce env:test:cot
|
||||||
|
|
||||||
- name: Run Playwright API tests.
|
- name: Run Playwright API tests.
|
||||||
id: run_playwright_api_tests
|
id: run_playwright_api_tests
|
||||||
|
|
|
@ -105,7 +105,7 @@ jobs:
|
||||||
working-directory: plugins/woocommerce
|
working-directory: plugins/woocommerce
|
||||||
env:
|
env:
|
||||||
ENABLE_HPOS: 0
|
ENABLE_HPOS: 0
|
||||||
run: pnpm env:test --filter=@woocommerce/plugin-woocommerce
|
run: pnpm --filter=@woocommerce/plugin-woocommerce env:test
|
||||||
|
|
||||||
- name: Run Playwright API tests.
|
- name: Run Playwright API tests.
|
||||||
id: run_playwright_api_tests
|
id: run_playwright_api_tests
|
||||||
|
@ -159,8 +159,8 @@ jobs:
|
||||||
env:
|
env:
|
||||||
ENABLE_HPOS: 0
|
ENABLE_HPOS: 0
|
||||||
run: |
|
run: |
|
||||||
pnpm env:dev --filter=@woocommerce/plugin-woocommerce
|
pnpm --filter=@woocommerce/plugin-woocommerce env:dev
|
||||||
pnpm env:performance-init --filter=@woocommerce/plugin-woocommerce
|
pnpm --filter=@woocommerce/plugin-woocommerce env:performance-init
|
||||||
|
|
||||||
- name: Install k6
|
- name: Install k6
|
||||||
run: |
|
run: |
|
||||||
|
|
|
@ -12,7 +12,7 @@ To get started, run the following commands:
|
||||||
|
|
||||||
```text
|
```text
|
||||||
pnpm --filter=@woocommerce/plugin-woocommerce-beta-tester install
|
pnpm --filter=@woocommerce/plugin-woocommerce-beta-tester install
|
||||||
pnpm --filter=@woocommerce/plugin-woocommerce-beta-tester run start
|
pnpm --filter=@woocommerce/plugin-woocommerce-beta-tester start
|
||||||
```
|
```
|
||||||
|
|
||||||
See [wp-scripts](https://github.com/WordPress/gutenberg/tree/master/packages/scripts) for more usage information.
|
See [wp-scripts](https://github.com/WordPress/gutenberg/tree/master/packages/scripts) for more usage information.
|
||||||
|
|
|
@ -113,7 +113,7 @@ export const updateReleaseBranchChangelogs = async (
|
||||||
|
|
||||||
Logger.notice( `Running the changelog script in ${ tmpRepoPath }` );
|
Logger.notice( `Running the changelog script in ${ tmpRepoPath }` );
|
||||||
execSync(
|
execSync(
|
||||||
`pnpm --filter=@woocommerce/plugin-woocommerce run changelog write --add-pr-num -n -vvv --use-version ${ version }`,
|
`pnpm --filter=@woocommerce/plugin-woocommerce changelog write --add-pr-num -n -vvv --use-version ${ version }`,
|
||||||
{
|
{
|
||||||
cwd: tmpRepoPath,
|
cwd: tmpRepoPath,
|
||||||
stdio: 'inherit',
|
stdio: 'inherit',
|
||||||
|
|
|
@ -216,7 +216,7 @@ foreach ( $touched_projects as $slug => $files ) {
|
||||||
} elseif ( getenv( 'CI' ) ) {
|
} elseif ( getenv( 'CI' ) ) {
|
||||||
printf( "---\n" ); // Bracket message containing newlines for better visibility in GH's logs.
|
printf( "---\n" ); // Bracket message containing newlines for better visibility in GH's logs.
|
||||||
printf(
|
printf(
|
||||||
"::error::Project %s is being changed, but no change file in %s is touched!\n\nUse `pnpm --filter=./%s run changelog add` to add a change file.\n",
|
"::error::Project %s is being changed, but no change file in %s is touched!\n\nUse `pnpm --filter=./%s changelog add` to add a change file.\n",
|
||||||
$slug,
|
$slug,
|
||||||
"$slug/{$changelogger_projects[ $slug ]['changes-dir']}/",
|
"$slug/{$changelogger_projects[ $slug ]['changes-dir']}/",
|
||||||
$slug
|
$slug
|
||||||
|
@ -234,7 +234,7 @@ foreach ( $touched_projects as $slug => $files ) {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if ( $exit && ! getenv( 'CI' ) && ! $list ) {
|
if ( $exit && ! getenv( 'CI' ) && ! $list ) {
|
||||||
printf( "\e[32mUse `pnpm --filter={project} run changelog add` to add a change file for each project.\e[0m\n" );
|
printf( "\e[32mUse `pnpm --filter={project} changelog add` to add a change file for each project.\e[0m\n" );
|
||||||
}
|
}
|
||||||
|
|
||||||
exit( $exit );
|
exit( $exit );
|
||||||
|
|
|
@ -10,6 +10,13 @@
|
||||||
},
|
},
|
||||||
"author": "Automattic",
|
"author": "Automattic",
|
||||||
"license": "GPL-3.0-or-later",
|
"license": "GPL-3.0-or-later",
|
||||||
|
"scripts": {
|
||||||
|
"build-storybook": "build-storybook -c ./.storybook",
|
||||||
|
"build-woocommerce": "pnpm --filter=@woocommerce/plugin-woocommerce build",
|
||||||
|
"preinstall": "npx only-allow pnpm",
|
||||||
|
"storybook": "pnpm run build-woocommerce && ./import-wp-css-storybook.sh && BABEL_ENV=storybook STORYBOOK=true start-storybook -c ./.storybook -p 6007 --ci",
|
||||||
|
"storybook-rtl": "USE_RTL_STYLE=true pnpm run storybook"
|
||||||
|
},
|
||||||
"engines": {
|
"engines": {
|
||||||
"node": "^16.14.1",
|
"node": "^16.14.1",
|
||||||
"pnpm": "^8.6.7"
|
"pnpm": "^8.6.7"
|
||||||
|
@ -17,13 +24,6 @@
|
||||||
"bugs": {
|
"bugs": {
|
||||||
"url": "https://github.com/woocommerce/woocommerce/issues"
|
"url": "https://github.com/woocommerce/woocommerce/issues"
|
||||||
},
|
},
|
||||||
"scripts": {
|
|
||||||
"build-storybook": "build-storybook -c ./.storybook",
|
|
||||||
"preinstall": "npx only-allow pnpm",
|
|
||||||
"build-woocommerce": "pnpm --filter=@woocommerce/plugin-woocommerce run build",
|
|
||||||
"storybook": "pnpm run build-woocommerce && ./import-wp-css-storybook.sh && BABEL_ENV=storybook STORYBOOK=true start-storybook -c ./.storybook -p 6007 --ci",
|
|
||||||
"storybook-rtl": "USE_RTL_STYLE=true pnpm run storybook"
|
|
||||||
},
|
|
||||||
"devDependencies": {
|
"devDependencies": {
|
||||||
"@babel/plugin-proposal-class-properties": "^7.18.6",
|
"@babel/plugin-proposal-class-properties": "^7.18.6",
|
||||||
"@babel/preset-env": "^7.23.5",
|
"@babel/preset-env": "^7.23.5",
|
||||||
|
|
Loading…
Reference in New Issue