From ed1c4b11b836b07d89b0e2b2b51552797446f7de Mon Sep 17 00:00:00 2001 From: Rodrigo Primo Date: Thu, 21 Nov 2019 10:41:27 -0300 Subject: [PATCH] Fix PHPCS errors in WC_Tests_Data_Store class file --- tests/unit-tests/crud/data-store.php | 30 ++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/tests/unit-tests/crud/data-store.php b/tests/unit-tests/crud/data-store.php index f430470123c..f5f70bb44df 100644 --- a/tests/unit-tests/crud/data-store.php +++ b/tests/unit-tests/crud/data-store.php @@ -1,7 +1,13 @@ assertEquals( $e->getMessage(), 'Invalid data store.' ); return; @@ -27,9 +33,9 @@ class WC_Tests_Data_Store extends WC_Unit_Test_Case { * * @since 3.0.0 */ - function test_invalid_store_load_throws_exception() { + public function test_invalid_store_load_throws_exception() { try { - $product_store = WC_Data_Store::load( 'does-not-exist' ); + WC_Data_Store::load( 'does-not-exist' ); } catch ( Exception $e ) { $this->assertEquals( $e->getMessage(), 'Invalid data store.' ); return; @@ -42,7 +48,7 @@ class WC_Tests_Data_Store extends WC_Unit_Test_Case { * * @since 3.0.0 */ - function test_store_swap() { + public function test_store_swap() { $this->load_dummy_store(); $store = new WC_Data_Store( 'dummy' ); @@ -61,7 +67,7 @@ class WC_Tests_Data_Store extends WC_Unit_Test_Case { * * @since 3.0.0 */ - function test_store_sub_type() { + public function test_store_sub_type() { $this->load_dummy_store(); $store = WC_Data_Store::load( 'dummy-sub' ); $this->assertEquals( 'WC_Dummy_Data_Store_CPT', $store->get_current_class_name() ); @@ -74,7 +80,7 @@ class WC_Tests_Data_Store extends WC_Unit_Test_Case { * * @since 3.0.0 */ - function load_dummy_store() { + private function load_dummy_store() { include_once dirname( dirname( dirname( __FILE__ ) ) ) . '/framework/class-wc-dummy-data-store.php'; add_filter( 'woocommerce_data_stores', array( $this, 'add_dummy_data_store' ) ); } @@ -82,9 +88,11 @@ class WC_Tests_Data_Store extends WC_Unit_Test_Case { /** * Adds a default class for the 'dummy' data store. * + * @param array $stores Loaded data stores. + * @return array Modified list of data stores. * @since 3.0.0 */ - function add_dummy_data_store( $stores ) { + public function add_dummy_data_store( $stores ) { $stores['dummy'] = 'WC_Dummy_Data_Store_CPT'; return $stores; } @@ -92,9 +100,11 @@ class WC_Tests_Data_Store extends WC_Unit_Test_Case { /** * Helper function/filter to swap out the default dummy store for a different one. * + * @param string $store Data store class name. + * @return string New data store class name. * @since 3.0.0 */ - function set_dummy_store( $store ) { + public function set_dummy_store( $store ) { return 'WC_Dummy_Data_Store_Custom_Table'; } }