Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request woocommerce/woocommerce-admin#2387 from woocommerce/fix/2365-improve-tab-switching-read-suppression 

Improve hidden tab suppression/fix rapid requests
This commit is contained in:
Paul Sealock 2019-06-13 09:22:48 +12:00 committed by GitHub
parent d5f91b4232 f88efb3173
commit ed21ccf62e
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/woocommerce-admin/client/wc-api/wc-api-spec.js
View File

@ -36,6 +36,11 @@ function createWcApiSpec() {
}, },
operations: { operations: {
read( resourceNames ) { read( resourceNames ) {
if ( document.hidden ) {
// Don't do any read updates while the tab isn't active.
return [];
}
return [ return [
...imports.operations.read( resourceNames ), ...imports.operations.read( resourceNames ),
...items.operations.read( resourceNames ), ...items.operations.read( resourceNames ),

7
plugins/woocommerce-admin/client/wc-api/wp-data-store/create-api-client.js
View File

@ -19,11 +19,12 @@ function createStore( name ) {
function createDataHandlers( store ) { function createDataHandlers( store ) {
return { return {
dataRequested: resourceNames => { dataRequested: resourceNames => {
const { resources } = store.getState(); // This is a temporary fix until it can be resolved upstream in fresh-data.
const newResources = resourceNames.some( resourceName => ! resources[ resourceName ] ); // See: https://github.com/woocommerce/woocommerce-admin/pull/2387/files#r292355276
if ( ! newResources && document.hidden ) { if ( document.hidden ) {
return; return;
} }
store.dispatch( { store.dispatch( {
type: 'FRESH_DATA_REQUESTED', type: 'FRESH_DATA_REQUESTED',
resourceNames, resourceNames,