Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix flaky assembler homepage e2e test (#48356) 

* Fix flaky assembler homepage test

* Add changelog

* Increase waiting time for the assembler loading

* Remove beforeEach and add function to all tests
This commit is contained in:
Veljko V 2024-06-12 19:09:41 +02:00 committed by GitHub
parent 2899a5da94
commit ed310fede4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 40 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce/changelog/e2e-fix-flaky-assembler-homepage-test Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: dev
E2E tests: fixing flaky assembler homepage test

4
plugins/woocommerce/tests/e2e-pw/tests/customize-store/assembler/assembler.page.js
View File

@ -16,7 +16,9 @@ export class AssemblerPage {
'.cys-fullscreen-iframe[style="opacity: 1;"]'
);
await frame.getByRole( 'button', { name: 'Save' } ).waitFor();
await frame
.getByRole( 'button', { name: 'Save' } )
.waitFor( { timeout: 25000 } );
}
/**

53
plugins/woocommerce/tests/e2e-pw/tests/customize-store/assembler/homepage.spec.js
View File

@ -10,6 +10,16 @@ const test = base.extend( {
},
} );
async function prepareAssembler( pageObject, baseURL ) {
await pageObject.setupSite( baseURL );
await pageObject.waitForLoadingScreenFinish();
const assembler = await pageObject.getAssembler();
await assembler.getByText( 'Design your homepage' ).click();
await assembler
.locator( '.components-placeholder__preview' )
.waitFor( { state: 'hidden' } );
}
test.describe( 'Assembler -> Homepage', () => {
test.use( { storageState: process.env.ADMINSTATE } );
@ -49,19 +59,12 @@ test.describe( 'Assembler -> Homepage', () => {
}
} );
test.beforeEach( async ( { baseURL, pageObject } ) => {
await pageObject.setupSite( baseURL );
await pageObject.waitForLoadingScreenFinish();
const assembler = await pageObject.getAssembler();
await assembler.getByText( 'Design your homepage' ).click();
await assembler
.locator( '.components-placeholder__preview' )
.waitFor( { state: 'hidden' } );
} );
test( 'Available homepage should be displayed', async ( {
pageObject,
baseURL,
} ) => {
await prepareAssembler( pageObject, baseURL );
const assembler = await pageObject.getAssembler();
const homepages = assembler.locator(
@ -73,7 +76,10 @@ test.describe( 'Assembler -> Homepage', () => {
test( 'The selected homepage should be focused when is clicked', async ( {
pageObject,
baseURL,
} ) => {
await prepareAssembler( pageObject, baseURL );
const assembler = await pageObject.getAssembler();
const homepage = assembler
.locator( '.block-editor-block-patterns-list__item' )
@ -85,7 +91,10 @@ test.describe( 'Assembler -> Homepage', () => {
test( 'The selected homepage should be visible on the site preview', async ( {
pageObject,
baseURL,
} ) => {
await prepareAssembler( pageObject, baseURL );
const assembler = await pageObject.getAssembler();
const editor = await pageObject.getEditor();
@ -127,6 +136,8 @@ test.describe( 'Assembler -> Homepage', () => {
baseURL,
}, testInfo ) => {
testInfo.snapshotSuffix = '';
await prepareAssembler( pageObject, baseURL );
const assembler = await pageObject.getAssembler();
const homepage = assembler
.locator( '.block-editor-block-patterns-list__item' )
@ -172,8 +183,8 @@ test.describe( 'Assembler -> Homepage', () => {
test.describe( 'Homepage tracking banner', () => {
test( 'Should show the "Want more patterns?" banner with the Opt-in message when tracking is not allowed', async ( {
baseURL,
pageObject,
baseURL,
} ) => {
await setOption(
request,
@ -182,6 +193,8 @@ test.describe( 'Assembler -> Homepage', () => {
'no'
);
await prepareAssembler( pageObject, baseURL );
const assembler = await pageObject.getAssembler();
await expect(
assembler.getByText( 'Want more patterns?' )
@ -193,10 +206,10 @@ test.describe( 'Assembler -> Homepage', () => {
).toBeVisible();
} );
test( 'Should show the "Want more patterns?" banner with the offline message when the user is offline', async ( {
test( 'Should show the "Want more patterns?" banner with the offline message when the user is offline and tracking is not allowed', async ( {
context,
baseURL,
pageObject,
baseURL,
} ) => {
await setOption(
request,
@ -204,6 +217,9 @@ test.describe( 'Assembler -> Homepage', () => {
'woocommerce_allow_tracking',
'no'
);
await prepareAssembler( pageObject, baseURL );
await context.setOffline( true );
const assembler = await pageObject.getAssembler();
@ -228,6 +244,8 @@ test.describe( 'Assembler -> Homepage', () => {
'yes'
);
await prepareAssembler( pageObject, baseURL );
const assembler = await pageObject.getAssembler();
await expect(
assembler.getByText( 'Want more patterns?' )
@ -266,14 +284,9 @@ test.describe( 'Assembler -> Homepage -> PTK API is down', () => {
} );
} );
await pageObject.setupSite( baseURL );
await pageObject.waitForLoadingScreenFinish();
const assembler = await pageObject.getAssembler();
await assembler.getByText( 'Design your homepage' ).click();
await assembler
.locator( '.components-placeholder__preview' )
.waitFor( { state: 'hidden' } );
await prepareAssembler( pageObject, baseURL );
const assembler = await pageObject.getAssembler();
await expect(
assembler.getByText( 'Want more patterns?' )
).toBeVisible();