diff --git a/plugins/woocommerce-blocks/.github/pull_request_template.md b/plugins/woocommerce-blocks/.github/pull_request_template.md index 77dcfbddef5..77f23181e58 100644 --- a/plugins/woocommerce-blocks/.github/pull_request_template.md +++ b/plugins/woocommerce-blocks/.github/pull_request_template.md @@ -1,47 +1,19 @@ - + - +## What Fixes # - - +## Why -#### Accessibility + - - -- [ ] I've tested using only a keyboard (no mouse) -- [ ] I've tested using a screen reader -- [ ] All animations respect [`prefers-reduced-motion`](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion) -- [ ] All text has [at least a 4.5 color contrast with its background](https://webaim.org/resources/contrastchecker/) - -#### Other Checks - -- [ ] This PR has either a `[type]` label or a `[skip-changelog]` label. -- [ ] This PR adds/removes a feature flag & I've updated [this doc](https://github.com/woocommerce/woocommerce-blocks/blob/trunk/docs/internal-developers/blocks/feature-flags-and-experimental-interfaces.md). -- [ ] This PR adds/removes an experimental interfaces and I've updated [this doc](https://github.com/woocommerce/woocommerce-blocks/blob/trunk/docs/internal-developers/blocks/feature-flags-and-experimental-interfaces.md). -- [ ] I tagged two reviewers because this PR makes queries to the database or I think it might have some security impact. - -### Screenshots - - - -| Before | After | -| ------ | ----- | -| | | - -### Testing - -#### Automated Tests -* [ ] Changes in this PR are covered by Automated Tests. - * [ ] Unit tests - * [ ] E2E tests - -#### User Facing Testing +## Testing Instructions +_Please consider any edge cases this change may have, and also other areas of the product this may impact._ + 1. 2. 3. @@ -49,18 +21,38 @@ Fixes # * [ ] Do not include in the Testing Notes * [ ] Should be tested by the development team exclusively -### WooCommerce Visibility +## Screenshots or screencast - + + +| Before | After | +| ------ | ----- | +| | | + +## WooCommerce Visibility + + +Required: * [ ] WooCommerce Core * [ ] Feature plugin * [ ] Experimental +* [ ] N/A -### Performance Impact +## Checklist - +Required: +* [ ] This PR has either a `[type]` label or a `[skip-changelog]` label. +* [ ] This PR is assigned to a milestone. -### Changelog +Conditional: +* [ ] This PR has a changelog description (if `[skip-changelog]` label is not present). +* [ ] This PR adds/removes a feature flag & I've updated [this doc](https://github.com/woocommerce/woocommerce-blocks/blob/trunk/docs/internal-developers/blocks/feature-flags-and-experimental-interfaces.md). +* [ ] This PR adds/removes an experimental interfaces, and I've updated [this doc](https://github.com/woocommerce/woocommerce-blocks/blob/trunk/docs/internal-developers/blocks/feature-flags-and-experimental-interfaces.md). +* [ ] This PR has been accessibility tested. +* [ ] This PR has had any necessary documentation added/updated. + +## Changelog + > Add suggested changelog entry here.