Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rename default placeholder in attribute form (#37645) 

* Rename placeholder

# Conflicts:
#	plugins/woocommerce/includes/admin/meta-boxes/views/html-product-attribute.php

* Fix input `onblur`

* Add changelog

---------

Co-authored-by: Fernando Marichal <contacto@fernandomarichal.com>
This commit is contained in:
Fernando Marichal 2023-04-17 13:07:32 -03:00 committed by GitHub
parent a67b7df26f
commit f6685b88b9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/woocommerce/changelog/dev-37158_rename_default_placeholder_in_attribute_form Normal file
View File

@ -0,0 +1,4 @@
Significance: minor
Type: dev
Rename the default placeholder in the new attribute form header to New attribute

16
plugins/woocommerce/client/legacy/js/admin/meta-boxes-product.js
View File

@ -555,13 +555,19 @@ jQuery( function ( $ ) {
} );
$( '.product_attributes' ).on( 'blur', 'input.attribute_name', function () {
var text = $( this ).val();
var attributeName = $( this )
var $inputElement = $( this );
var text = $inputElement.val();
var $attribute = $inputElement
.closest( '.woocommerce_attribute' )
.find( 'strong.attribute_name' );
var isPlaceholder = attributeName.hasClass( 'placeholder' );
if ( ( isPlaceholder && text ) || ! isPlaceholder ) {
attributeName.removeClass( 'placeholder' ).text( text );
if ( text === '' ) {
$attribute
.addClass( 'placeholder' )
.text(
woocommerce_admin_meta_boxes.i18n_attribute_name_placeholder
);
} else {
$attribute.removeClass( 'placeholder' ).text( text );
}
} );

1
plugins/woocommerce/includes/admin/class-wc-admin-assets.php
View File

@ -422,6 +422,7 @@ if ( ! class_exists( 'WC_Admin_Assets', false ) ) :
'i18n_delete_note' => __( 'Are you sure you wish to delete this note? This action cannot be undone.', 'woocommerce' ),
'i18n_apply_coupon' => __( 'Enter a coupon code to apply. Discounts are applied to line totals, before taxes.', 'woocommerce' ),
'i18n_add_fee' => __( 'Enter a fixed amount or percentage to apply as a fee.', 'woocommerce' ),
'i18n_attribute_name_placeholder' => __( 'New attribute', 'woocommerce' ),
'i18n_product_simple_tip' => __( '<b>Simple –</b> covers the vast majority of any products you may sell. Simple products are shipped and have no options. For example, a book.', 'woocommerce' ),
'i18n_product_grouped_tip' => __( '<b>Grouped –</b> a collection of related products that can be purchased individually and only consist of simple products. For example, a set of six drinking glasses.', 'woocommerce' ),
'i18n_product_external_tip' => __( '<b>External or Affiliate –</b> one that you list and describe on your website but is sold elsewhere.', 'woocommerce' ),

2
plugins/woocommerce/includes/admin/meta-boxes/views/html-product-attribute.php
View File

@ -8,7 +8,7 @@ if ( ! defined( 'ABSPATH' ) ) {
<div class="handlediv" title="<?php esc_attr_e( 'Click to toggle', 'woocommerce' ); ?>"></div>
<div class="tips sort" data-tip="<?php esc_attr_e( 'Drag and drop to set admin attribute order', 'woocommerce' ); ?>"></div>
<a href="#" class="remove_row delete"><?php esc_html_e( 'Remove', 'woocommerce' ); ?></a>
<strong class="attribute_name<?php echo esc_attr( $attribute->get_name() === '' ? ' placeholder' : '' ); ?>"><?php echo esc_html( $attribute->get_name() !== '' ? wc_attribute_label( $attribute->get_name() ) : __( 'Custom attribute', 'woocommerce' ) ); ?></strong>
<strong class="attribute_name<?php echo esc_attr( $attribute->get_name() === '' ? ' placeholder' : '' ); ?>"><?php echo esc_html( $attribute->get_name() !== '' ? wc_attribute_label( $attribute->get_name() ) : __( 'New attribute', 'woocommerce' ) ); ?></strong>
</h3>
<div class="woocommerce_attribute_data wc-metabox-content hidden">
<?php require __DIR__ . '/html-product-attribute-inner.php'; ?>