Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix undefined error when selecting a product without an image (https://github.com/woocommerce/woocommerce-blocks/pull/254) 

prior to this commit, an 'individual product' block would produce
an error if associated with a product with no image.
This commit is contained in:
Michael Rogowski 2018-12-17 15:15:32 -05:00 committed by Kelly Dwan
parent 8b4503f53b
commit fef17476c8
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/woocommerce-blocks/assets/js/legacy/views/specific-select.jsx
View File

@ -348,13 +348,15 @@ class ProductSpecificSearchResultsDropdownElement extends Component {
render() { render() {
const product = this.props.product; const product = this.props.product;
const icon = this.props.selected ? <Dashicon icon="yes" /> : null; const icon = this.props.selected ? <Dashicon icon="yes" /> : null;
const productImage = product.images.length !== 0 ?
(<img src={ product.images[ 0 ].src } alt={ product.name } />) : null;
/* eslint-disable jsx-a11y/click-events-have-key-events */ /* eslint-disable jsx-a11y/click-events-have-key-events */
/* eslint-disable jsx-a11y/no-static-element-interactions */ /* eslint-disable jsx-a11y/no-static-element-interactions */
/* reason: This interface will be deprecated, the new component is accessible. */ /* reason: This interface will be deprecated, the new component is accessible. */
return ( return (
<div className={ 'wc-products-list-card__content' + ( this.props.selected ? ' wc-products-list-card__content--added' : '' ) } onClick={ this.handleClick }> <div className={ 'wc-products-list-card__content' + ( this.props.selected ? ' wc-products-list-card__content--added' : '' ) } onClick={ this.handleClick }>
<img src={ product.images[ 0 ].src } alt="" /> { productImage }
<span className="wc-products-list-card__content-item-name">{ product.name }</span> <span className="wc-products-list-card__content-item-name">{ product.name }</span>
{ icon } { icon }
</div> </div>
@ -458,11 +460,13 @@ class ProductSpecificSelectedProducts extends Component {
} }
const productData = PRODUCT_DATA[ productId ]; const productData = PRODUCT_DATA[ productId ];
const productImage = productData.images.length !== 0 ?
(<img src={ productData.images[ 0 ].src } alt={ productData.name } />) : null;
productElements.push( productElements.push(
<li className="wc-products-list-card__item" key={ productData.id + '-specific-select-edit' } > <li className="wc-products-list-card__item" key={ productData.id + '-specific-select-edit' } >
<div className="wc-products-list-card__content"> <div className="wc-products-list-card__content">
<img src={ productData.images[ 0 ].src } alt="" /> { productImage }
<span className="wc-products-list-card__content-item-name">{ productData.name }</span> <span className="wc-products-list-card__content-item-name">{ productData.name }</span>
<button <button
type="button" type="button"