Commit Graph

133 Commits

Author SHA1 Message Date
leogermani 83cc3a9365 get_payment_method relies on a more generic DOM element
When checking the payment method, I think it would be better to rely on a more generic DOM element to make sure the find() method will find what it is looking for, in case theme authors have changed the position of things inside the form.

Ive stumble into this because I wanted to display the order review in the top of the page, before the billing form, but I wanted to keep the payment form at the end of the page, so, after changing the order_review DIV position, I did:

```
remove_action( 'woocommerce_checkout_order_review', 'woocommerce_checkout_payment', 20);
add_action( 'woocommerce_checkout_after_customer_details', 'woocommerce_checkout_payment');
```

After I did this, the get_payment_method stopped working.

I might be wrong, but I think this proposal gives more flexibility to theme authors, while not breaking anything. This tweak Ive done dont look really ugly to me, I think I should be able to move things inside the checkout form around.

Thanks for looking into it

cheers
2016-11-27 16:51:22 -02:00
Mike Jolley c93486ccc7 Typo in comment. 2016-10-14 12:38:55 +01:00
Akeda Bagus e213e1cd00 Added data to be passed in `updated_checkout` event handler.
Resolves #11872.
2016-09-08 16:17:37 +07:00
Jeroen Sormani 8e757b78ef Allow checkbox to have '.update_totals_on_change' class 2016-09-05 16:42:25 +02:00
Justin Shreve f77cdd366d Move our "if no other payment methods are found" selection logic, outside of the if/else block for selectedPaymentMethod. We want to make sure it still ruins, even if selectedPaymentMethod matches nothing. 2016-08-02 10:05:18 -07:00
Justin Shreve e58c0f7f45 Switch our selection for finding the checked box. :checked is faster than filtering. 2016-08-02 09:18:54 -07:00
Justin Shreve a534512b8a Still hide checkboxes for single payment options, even if we select a "previously selected" option. 2016-08-02 09:18:54 -07:00
Justin Shreve 1f25dc001b After payment form fragments are updated, make sure to set the previously selected payment method back as the selected/default payment method. 2016-08-02 09:18:54 -07:00
Claudio Sanches 561cdd35e5 Apply validation for checkbox while update and submit errors #11360 2016-07-05 19:21:51 -03:00
Claudio Sanches 41f3deb665 Apply validation for checkboxes, closes #11360 2016-07-05 18:29:17 -03:00
Mike Jolley f6a42e55ac Remove all notices on fail 2016-06-23 13:47:24 +01:00
Mike Jolley 7513f40a9d Notice group for order review notices 2016-06-23 13:31:34 +01:00
Shiva Poudel 00cc3711ac Minor tweaks and JSHint ignore for update notice script 2016-06-06 23:05:10 +05:45
Claudio Sanches e39274e753 HTTPS for everybody 2016-05-26 22:48:49 -03:00
Mike Jolley 3893d0ec19 Fixes tokenisation form when > 1 are used at once.
@claudiosmweb can you give this a check over since it was missed?
2016-05-24 17:52:32 +01:00
Brent Shepherd aa2b97cb4c Allow string indexes for shipping packages 2016-05-23 17:34:43 -07:00
Mike Jolley 6f04ff1fa0 Replace size with length
Fixes #10444
2016-03-01 13:08:25 +00:00
Justin Shreve 6a8abc9f28 Keep track of terms & conditions state and recheck the box if necessary. 2016-02-10 10:38:39 -08:00
Phil Young ee54e040df Chrome autocomplete to update checkout shipping. Closes #9850
When using Chrome's autocomplete to alter an address field in the
checkout, the shipping selection in the order review will now update.
Closes #9850.
2015-12-16 10:02:18 +00:00
Jeff Stieler e334d75591 Allow plugins to force a reload of the checkout page without an error condition. 2015-12-03 18:20:22 -08:00
Mike Jolley 9f76a61bcd Extra comments, fix JS Lint issue, and log fixes for debugging purposes. 2015-12-03 10:51:39 +00:00
Max Rice b50e830b54 [#9655] Recover from malformed JSON checkout response
If a plugin or other code produces output during checkout processing,
it breaks the JSON parsing. This commit makes use of jQuery’s Ajax
dataFilter which allow us to sanitize the raw response before it’s
parsed by the Ajax handler.
2015-12-02 17:31:43 -05:00
Mike Jolley 327cf87191 Merge pull request #9728 from woothemes/issue/9727-order-review-payment-method-change-ui
Hook up payment method change UI on “Pay for Order” forms.
2015-12-02 10:45:26 +00:00
mitogh 0808bbf1ba Update variable to use the cached version 2015-11-30 22:12:26 -06:00
Jeff Stieler 8adc422034 Hook up payment method change UI on “Pay for Order” forms. 2015-11-30 11:09:09 -07:00
Mike Jolley 27a7793f00 Min and POT 2015-11-25 18:46:57 +00:00
Mike Jolley c8ef6902f5 Allow checkout to be updated without posting shipping methods
Fixes #9552 @claudiosmweb
2015-11-20 14:51:38 +00:00
Mike Jolley 77054e11fa Improve appearance when only 1 gateway is active.
Closes #8982
2015-10-30 15:23:16 +00:00
Mike Jolley 58b01886c9 Add validation handling for checkboxes
@jameskoster set label color red too so this is indicated

Fixes #9464
2015-10-30 13:45:59 +00:00
Claudio Sanches eedff144e7 Created assets/js/frontend/password-strength-meter.js #9319 2015-10-09 13:31:47 -03:00
nishitlangaliya f468f16e29 fixes: changes as per suggestion given by claudiosmweb ref #8938 2015-10-09 13:25:47 +05:30
nishitlangaliya a45ef9f814 fixes: done changes using dom operation. ref #8938 2015-10-08 20:14:53 +05:30
Mike Jolley 34a568aea8 manual update trigger for checkout
Closes #9119
2015-10-06 12:40:23 +01:00
Claudio Sanches 79cd558c38 Fixed conflicts 2015-10-01 17:41:49 +02:00
Mike Jolley 3a8fd365d8 [2.4] IE doesn't like 'input' events for inputs with placeholders
Fixes #8992
2015-09-16 13:17:39 +01:00
Florian Ludwig 35655f8544 Fixed all inefficient selector usages
Use find for more efficient selectors - more information on e.g.
https://24ways.org/2011/your-jquery-now-with-less-suck/
2015-09-07 19:51:10 +02:00
Emil Kjær Eriksen 733a9a2fe5 checkout.js now looks for payment method in entire checkout form 2015-08-12 18:03:59 +02:00
Mike Jolley d0c2c10c47 Made the linter happy 2015-07-27 17:55:37 +01:00
Mike Jolley 0ab151562a Fix issues with trailing slashes on permalinks
Closes #8658
2015-07-27 11:56:07 +01:00
Mike Jolley 2834eff221 Merge branch 'variations-8477'
Conflicts:
	assets/js/frontend/add-to-cart-variation.js
	assets/js/frontend/add-to-cart-variation.min.js
	assets/js/frontend/add-to-cart.min.js
	assets/js/frontend/checkout.min.js
	assets/js/frontend/geolocation.min.js
2015-07-10 11:37:05 +01:00
Claudio Sanches 3c409e07e1 Fixed js coding standards in assets/js/frontend/checkout.js 2015-07-09 15:04:00 -03:00
Mike Jolley 65f19d5ca7 Ajax variation handling
If there are more variations than the threshold allows (set to 20
currently) this loads the matching variation via ajax instead of inline
in the HTML. #8477
2015-07-09 15:56:20 +01:00
Jake Johnson afe3e1f236 Update checkout when changing address text fields. Fixes #8308 2015-06-05 11:27:44 -07:00
Mike Jolley c1e3da8bcb Return real json response during checkout
Closes #8086
2015-05-15 13:51:51 +01:00
Claudio Sanches 1dadbb2842 Fixed coding standards for #7879 2015-04-13 12:37:22 -03:00
Danny van Kooten 88f2e690bb Changing all inefficient selectors of $('body') to $(document.body), which is about 80% faster (and even more on mobile, see https://jsperf.com/jquery-body-vs-document-body-selector/2 ). 2015-04-03 14:21:47 +02:00
Mike Jolley 21c5513526 Added endpoint for faster ajax requests 2015-03-20 12:28:26 +00:00
Mike Jolley 492c8e361b No selected payment method? Check the first. 2015-02-24 10:43:11 +00:00
Mike Jolley 600b561fd9 Small timeout on checkout update action to prevent several triggering at once.
Closes #7423
2015-02-16 15:45:25 +00:00
Mike Jolley 4cfabb8e16 Only update checkout when form.checkout exists
Fixes #7422
2015-02-16 14:57:04 +00:00