Commit Graph

26 Commits

Author SHA1 Message Date
Patricia Hillebrandt 5dd7713346
[Performance]: Replace `classnames` usage with `clsx` (#47760)
* Replace classnames with clsx within woocommerce-blocks.

* Undo unnecessary change to getClassnames const.

* Replace classnames with clsx within woocommerce-admin.

* Add changelog.

* Update the pnpm lock file

* Address lint.

* Address lint errors for the block-library.
2024-05-31 05:49:36 +02:00
Joel Thiessen 588776deb3 Fix persisted queries being lost when navigating to excluded page (such as Homescreen) (https://github.com/woocommerce/woocommerce-admin/pull/6614) 2021-04-02 14:35:31 -07:00
Joshua T Flowers 198e3fb7ce Add navigation container tests (https://github.com/woocommerce/woocommerce-admin/pull/6464)
* Add changelog and testing instructions

* Set active level when matching a new item

* Add navigation container tests

* Add testing instructions and changelog

* Update testing instructions

* Fix up missing changelog entries after rebase

* Add in missing menu items from useSelect in tests
2021-03-05 09:35:53 -05:00
Joshua T Flowers 40a86daf2f Remove active item from navigation store (https://github.com/woocommerce/woocommerce-admin/pull/6486)
* Remove active item from navigation store

* Add changelog entry
2021-03-03 16:57:00 -05:00
Joshua T Flowers a8757648a1 Refactor menu item mapping and sorting (https://github.com/woocommerce/woocommerce-admin/pull/6382)
* Separate primary and secondary menu components

* Simplify category mapping

* Map categories and items simultaneously to improve performance

* Sort added menu items

* Pre-sort menu items

* Create single mapped sorting on server-side

* Fix incorrect menu ID references

* Update tests

* Move methods to utils file

* Add in permissions check in client nav

* Fix server-side capability check

* Fix duplicate expectation and test name

* Add testing instructions
2021-02-22 13:54:27 -05:00
Paul Sealock 3483f1930e Navigation: Add test to container component (https://github.com/woocommerce/woocommerce-admin/pull/6344)
* getCategoriesMap

* getMenuItemsByCategory

* changelog
2021-02-18 13:06:28 -05:00
Joshua T Flowers 8371325ba6 Fix empty nav menu (https://github.com/woocommerce/woocommerce-admin/pull/6366) 2021-02-18 12:27:04 -05:00
Joshua T Flowers 452494a4fe Move favorited menu items to primary menu (https://github.com/woocommerce/woocommerce-admin/pull/6290)
* Update menu ID when favoriting an item

* Allow favorites to be included alongside the primary menu items

* Add categories to favorites menu server-side

* Don't reset menu state when active item is the same

* Make sure favorites are finished resolving before showing
2021-02-16 11:12:25 -05:00
Joshua T Flowers 80f5532543 Fix navigation priority settings conflict (https://github.com/woocommerce/woocommerce-admin/pull/6336)
* Remove the late addition of the core items for the navigation

* Add fallbacks in case the nav is not detected server-side

* Check if ref is set before resizing
2021-02-12 16:42:04 -05:00
Joshua T Flowers 683f8adf33 Add favoriting extensions client UI (https://github.com/woocommerce/woocommerce-admin/pull/6287)
* Add category title component

* Add category title styling

* Record tracks event when toggling favorite

* Fix aria labels

* Fix colors for favorite button

* Use CategoryTitle for secondary nav menu
2021-02-12 11:51:02 -05:00
Joshua T Flowers baaaf39bf0 Try: Refactor head and body heights (https://github.com/woocommerce/woocommerce-admin/pull/6247)
* Move navigation to WC header

* Remove wp toolbar class

* Set body margin on header change

* Fix up layout margins

* Remove excess padding on mobile

* Fix navigation preload styles and embed

* Fix preloading space due to adminbar missing

* Remove embed padding on wrap

* Fix body display for wpadmin menu

* Fix up wpadminbar reset padding

* Remove body padding on full screen layouts

* Fix mobile admin bar height on full screen

* Clean up body margin on unmount

* Center the activity panel (https://github.com/woocommerce/woocommerce-admin/pull/6289)

* Center the activity panel

* Handle PR feedback

* Fix up secondary nav group style changes

* Remove screen reader style changes

* Debounce resize event

* Make responsive button selector more specific

Co-authored-by: Hsing-Yu Flowers <hsingyuc.7@gmail.com>
2021-02-12 11:32:26 -05:00
Joshua T Flowers e27d5127b8 Separate secondary items into separate menu in navigation (https://github.com/woocommerce/woocommerce-admin/pull/6253)
* Convert navigation to grid

* Include back button in primary menu

* Update secondary menu keys

* Use array instead of fragment to avoid unique key
2021-02-08 15:41:08 -05:00
Joshua T Flowers bc998444a3 Future proof experimental components (https://github.com/woocommerce/woocommerce-admin/pull/5961)
* Possibly use safe Text component

* Possibly use safe navigation components

* Add experimental package

* Update components to import from woocommerce/experimental

* Make experimental package private

* Reference experimental package relatively

* Update packages/experimental/README.md

Co-authored-by: Paul Sealock <psealock@gmail.com>

* Update packages/experimental/CHANGELOG.md

Co-authored-by: Paul Sealock <psealock@gmail.com>

* Update history state instead of mocking getQuery in tests

* Handle PR feedback

* Create excluded externals array and return early

Co-authored-by: Paul Sealock <psealock@gmail.com>
2021-01-07 18:57:09 -05:00
Joel Thiessen 750efaef0f Removing duplicate back button on root level of new navigation (https://github.com/woocommerce/woocommerce-admin/pull/5915) 2021-01-04 09:00:42 -08:00
Joshua T Flowers 6e2bf974c7 Add filter for root back URL (https://github.com/woocommerce/woocommerce-admin/pull/5878)
* Add filter for root back URL

* Add filter for root back button label
2020-12-15 12:05:32 -05:00
Joshua T Flowers c659d2a729 Fix nav group titles showing in child menus (https://github.com/woocommerce/woocommerce-admin/pull/5793) 2020-12-03 10:50:38 -05:00
Joshua T Flowers 1e01adcbc1 Add navigation item click tracks (https://github.com/woocommerce/woocommerce-admin/pull/5707)
* Add tracking to navigation item clicks

* Track back button click in navigation
2020-12-02 13:16:54 -05:00
Joshua T Flowers 5ba669a2f4 Only show menu items from same parent menu (https://github.com/woocommerce/woocommerce-admin/pull/5731)
* Only render nav items belonging to parent menu ID

* Set item menu ID for items automatically

* Use categories map to filter items early

* Convert categorized menus to objects

* Prevent bypassing menu via existing parent

* Fix plugins name
2020-12-02 09:36:35 -05:00
Joel Thiessen b8238d91dc Adding wrapper class around navigation to implement scroll styles/logic (https://github.com/woocommerce/woocommerce-admin/pull/5570) 2020-11-12 09:10:42 -08:00
Joshua T Flowers cae0f33e38 Fix non-matching items and post type matching (https://github.com/woocommerce/woocommerce-admin/pull/5593)
* Don't match menu items with a non-positive score

* Match single post type page to post type menu item
2020-11-11 10:16:12 -08:00
Joel Thiessen c8a67bfef9 Navigation: Adding ability for new navigation to scroll when list of links exceed viewport height (https://github.com/woocommerce/woocommerce-admin/pull/5524)
* Adding ability for new navigation to scroll when list of links exceeds the viewport height

* Resetting scroll to the top of element when transitioning menus on navigation
2020-11-06 12:52:01 -08:00
Joshua T Flowers 88a4ed76eb Try: Register plugins under separate navigation menu (https://github.com/woocommerce/woocommerce-admin/pull/5513)
* Create separate methods for registering plugin items

* Fix add plugin category

* Allow scrolling of nav menu

* Use group title

* Add example plugin items

* Make menu item and category methods private

* Add analytics pages to navigation

* Register home item if dashboard feature is enabled

* Allow navigation registration from all wca items

* Update example plugin item registration

* Update order of menu groups

* Update plugins group name to extensions

* Remove temporary scroll fixes
2020-11-05 09:00:04 -05:00
Joshua T Flowers 11ebc96fbe Show parent as default back button label (https://github.com/woocommerce/woocommerce-admin/pull/5435)
* Show parent as default back button label

* Make back button logic more succinct
2020-10-22 15:56:44 -04:00
Joshua T Flowers 84e006cc62 Migrate navigation store to data package (https://github.com/woocommerce/woocommerce-admin/pull/5420)
* Move data store to package and hydrate navigation

* Use wc settings to get site URL and title

* Use wc settings admin link

* Update nav util tests to work with installs in subdirectory
2020-10-21 13:02:45 -04:00
Joshua T Flowers 81a8a28b20 Only show menu group if items exist (https://github.com/woocommerce/woocommerce-admin/pull/5403)
* Only show menu group if items exist

* Improve performance for menu item filtering
2020-10-21 13:01:46 -04:00
Paul Sealock ad7cf64303 Navigation: Add client code (https://github.com/woocommerce/woocommerce-admin/pull/5309)
* is_feature_enabled

* feature class

* copy/paste

* hooked up

* its alive

* add wc-admin items

* clean up entry point

* Analytics remove url

* rebase error

* add back in check is_feature_enabled

* specificity CSS
2020-10-13 14:40:53 +13:00