Commit Graph

29467 Commits

Author SHA1 Message Date
Gerhard 7074b0933c Don't wrap wp_json_encode string in quotes, it already does it for us. 2018-12-10 10:14:56 +02:00
Khan M Rashedun-Naby 50bb510c93 Fix for issue #22182 2018-12-10 00:47:49 +06:00
Ron Rennick 34bdc3744a phpcs sniff fixes for templates/single-product-reviews.php 2018-12-07 09:59:01 -06:00
Ron Rennick 52f13f8708 fix phpcs sniffs in class-wc-widget-rating-filter.php 2018-12-07 09:27:56 -06:00
Rodrigo Primo 0b413351a2
Merge pull request #22031 from Prospress/fix/22027
fix PHP 5.2 sniffs in class-wc-install.php
2018-12-07 11:43:46 -02:00
Faisal Alvi 8dbb795610 abs-wc-widget-coding-stds
Few coding standard fixes in the file abstract-wc-widget.php
2018-12-07 18:57:03 +05:30
Rodrigo Primo 5da1b72464
Merge pull request #21913 from Prospress/fix/21909
Capitalize dashboard widget titles
2018-12-07 11:24:25 -02:00
Faisal Alvi 6fd8971b8d
Merge pull request #2 from woocommerce/master
Updating to head
2018-12-07 18:47:32 +05:30
Claudio Sanches 7cbcaf04e8
Merge pull request #22121 from woocommerce/fix/update-settings-controller
Fix updating settings via the API
2018-12-06 16:49:44 -02:00
Ron Rennick 2b74017200 apply usage restriction compare to entire string 2018-12-06 12:32:04 -06:00
Ron Rennick 8c852780ea phpcs sniff fixes for class-wc-cart.php 2018-12-06 12:31:21 -06:00
Claudio Sanches fb35324c4f [REST API] Fixed orderby slug 2018-12-06 16:17:58 -02:00
Rodrigo Primo 99b633d1e5
Merge pull request #22028 from woocommerce/phpcs-wp-db
Update WPCS sniff names
2018-12-06 15:56:12 -02:00
Peter Fabian dc39d265fd Merge branch 'master' into fix/update-settings-controller 2018-12-06 16:28:46 +01:00
Gustavo Bordoni 31aded7091
Remove one more PHP 52 incomaptible \ 2018-12-06 09:48:18 -05:00
Gustavo Bordoni 98d6a715a2
PHP 5.2 Compatibility 2018-12-06 09:45:09 -05:00
Rodrigo Primo 164758a5f0
Merge pull request #22110 from stromhalm/patch-1
Properly close option tag in customer search
2018-12-06 12:18:54 -02:00
Bradley Davis e97204a483 Removed @author tag from docbloc in the template files 2018-12-06 12:13:39 -02:00
Rodrigo Primo e7296aec03
Merge pull request #22081 from rvdsteege/patch-1
Fix incorrect return type documentation for product factory `get_product()`.
2018-12-06 12:09:52 -02:00
Rodrigo Primo a52e72f87f
Merge pull request #22155 from grigorijurasov/patch-1
Line 27 - replacing a typo in the comment
2018-12-06 11:07:37 -02:00
Rodrigo Primo 644f6b1cba Use separate Travis build jobs to run e2e tests and PHPCS
This commit creates two new Travis build jobs, one to run the e2e tests and another to run PHPCS. Doing this, instead of running those two checks in the same build job as the PHP 7.2 unit tests, should make the total build time shorter and it should make it easier to see why the build failed.
2018-12-06 09:14:13 -02:00
grigorijurasov adbce426c5
Line 27 - replacing a typo in the comment
Line 27 - there's currently a typo, `numer`, changing that to `number`
2018-12-06 12:38:42 +02:00
Rodrigo Primo 62faa2dceb
Merge pull request #22140 from rodrigoprimo/fix/travis-php7
Make sure PHPUnit tests runs when using PHP 7.2+ in the Travis builds
2018-12-06 08:24:37 -02:00
Rodrigo Primo 522df96217 Make sure PHPUnit tests runs when using PHP 7.2+ in the Travis builds
Due to a recent change in the Travis environment, WooCommerce unit tests stopped working with the following error (see for example https://travis-ci.org/woocommerce/woocommerce/jobs/463470674#L876) in the PHP 7.2 and 7.3 build jobs:

Fatal error: Class PHPUnit_Util_Test may not inherit from final class (PHPUnit\Util\Test) in /tmp/wordpress-tests-lib/includes/phpunit6-compat.php on line 18

This error is happening because Travis started ignoring the PHPUnit version that we install manually via Composer (f7bc3fb851/tests/bin/travis.sh (L6)) and started using the PHPUnit version that is shipped with each of its PHP docker images. This means that for the docker images running PHP 7.2 and 7.3, PHPUnit 7 is used but the WordPress unit test framework is not compatible with PHPUnit 7 (see WordPress core ticket https://core.trac.wordpress.org/ticket/43218) and produces the error above. I believe that this is happening because Travis changed the directory where it installs composer global packages from `$HOME/.composer/` to `$HOME/.config/composer/` (https://github.com/travis-ci/travis-ci/issues/7289#issuecomment-427333966) and we add `$HOME/.composer/vendor/bin:$PATH` to the `$PATH`. So this commit simply updates the path in the line where we add it to the `$PATH`.

I tried to use `composer exec` instead of updating `$PATH` but that didn't work for PHP 5.2.
2018-12-05 15:15:49 -02:00
Aslam Shekh 0611204238 Fixed Wordpress standard as per given suggestion on here:- https://github.com/woocommerce/woocommerce/pull/22122#issuecomment-444207375 2018-12-05 08:12:57 -08:00
Rodrigo Primo f7bc3fb851
Merge pull request #21366 from birgire/unit-tests-count-asserting-21365
Use assertCount instead of assertEquals
2018-12-05 11:15:52 -02:00
Rodrigo Primo a91bc5b1ec phpcs fixes using phpcbf 2018-12-04 16:04:24 -02:00
Kathy Darling eadef501af need to pass a null parameter in second place where woocommerce_add_to_cart_redirect filter appears to avoid errors. 2018-12-04 11:58:54 -06:00
Kathy Darling f9fecefb5f Add product object and add to cart success status as params for woocommerce_add_to_cart_redirect filter 2018-12-04 11:58:14 -06:00
Rodrigo Primo 24fd6f89c6 Merge branch 'master' into phpcs-wp-db 2018-12-04 15:39:19 -02:00
Justin Shreve 379f257e3d Load the correct class for settings options 2018-12-04 11:20:34 -05:00
Joshua Flowers a16eba8543 Strip hash from URL that prevents reload on refunds 2018-12-04 10:11:40 +08:00
Adrian Jagusch 8732d200e1
Properly close option tag in customer search 2018-12-03 15:27:45 +01:00
Peter Fabian 9547895863 Don't remove existing meta queries via REST API. 2018-12-03 11:52:36 +01:00
Brent Shepherd f19ebbfa66 Make webhooks scheduled actions unique
Fixes #22087
2018-12-03 13:09:03 +10:00
Claudio Sanches a0e77eb40c Use wc_strtoupper on formatted address 2018-11-30 15:59:28 -02:00
claudiulodro 2fed9b94a3 Remove duplicate sanitizing 2018-11-30 08:49:43 -08:00
claudiulodro 5d0d275bec Remove duplicate sanitizing 2018-11-30 08:49:43 -08:00
claudiulodro 2bccd4899a Revise to make code cleaner 2018-11-30 08:49:43 -08:00
claudiulodro d1533261f5 Extra sanitizing around payment_method_title 2018-11-30 08:49:43 -08:00
Ron Rennick 267b5ed569 only include order erasure bulk action if erasure is enabled in settings 2018-11-29 16:20:56 -04:00
Ron Rennick 59c1b2f669 phpcs sniff fixes class-wc-admin-list-table-orders.php 2018-11-29 16:16:51 -04:00
Ron Rennick b7f87c8cd2 Remove the stock data type on low stock threshhold input which can be blank 2018-11-29 14:58:51 -04:00
Claudiu Lodromanean c4fcaa8938
Merge pull request #22062 from woocommerce/update/wptested
Bump "Tested up to" header
2018-11-29 08:43:20 -08:00
Reüel van der Steege b433219f71
Fix incorrect return type documentation for product factory `get_product()`.
This method returns `false` if the product cannot be loaded, not `null`.
2018-11-29 15:25:24 +01:00
Fulvio Notarstefano 3c4f0db9cc Make shipping may estimate text filterable 2018-11-29 17:16:22 +08:00
Fulvio Notarstefano 1d2700e42f Make shipping may be available text filterable 2018-11-29 14:19:20 +08:00
Claudiu Lodromanean 7049cd28e9
Merge pull request #22057 from leewillis77/status-report-plugin-fix
"Active plugins" fix for status report
2018-11-28 11:09:26 -08:00
Ron Rennick 548fc72718 ensure product parent exists before getting its image 2018-11-28 14:41:12 -04:00
Ron Rennick b0b2320559 fix phpcs sniffs in abstract-wc-product.php 2018-11-28 14:34:24 -04:00