Commit Graph

465 Commits

Author SHA1 Message Date
Darren Ethier f8ebc4cd6d refactor all client files to use new settings api (https://github.com/woocommerce/woocommerce-admin/pull/3002) 2019-10-07 07:51:25 -04:00
Paul Sealock 029e514c75 wcSettings: fix countries getSettings (https://github.com/woocommerce/woocommerce-admin/pull/2974)
* wcSettings: fix countries getSettings

* Revert "wcSettings: fix countries getSettings"

This reverts commit cdccfa95cded4b1d7e8908102e8814a0281b027e.

* fix incorrect countries usage

* apply countries fix to Customers Report
2019-10-01 10:43:26 +13:00
Darren Ethier d728d38219 Refactor: Alternative approach to implementing extendable settings from the server (https://github.com/woocommerce/woocommerce-admin/pull/2917)
* integrate with new asset data registration (php side)

- includes back-compatibility.

* update js configuration and implement settings alias

- this aliases `@woocommerce/wc-admin-settings` to the settings api exposed via blocks (either the blocks plugin or core) and all the settings provided via the server.
- Adds fallback for back-compat if `wc.wcSettings` is not available in the environment (fallsback to `wcSettings`).

* initial pass to update all wcSettings direct usage to the new api

- this is just an initial pass, more can be done in separate pulls.

* missed one spot for adding new filter implementation

* fix incorrect jest config

* Avoid unnecessary assignment and directly return.

* Remove unnecessary defaults

* Fix inline comment text case.

Co-Authored-By: Albert Juhé Lluveras <contact@albertjuhe.com>

* Remove unnecessary inline comment.

* use @todo instead of TODO

Co-Authored-By: Albert Juhé Lluveras <contact@albertjuhe.com>

* fix incorrect reference in webpack config.

* add missing import and slightly delay dependency injection for scripts

* update get-setting and set-setting callbacks

* disable lint rule for console.error on dev doc builds
2019-09-23 17:47:08 -04:00
Jeff Stieler 2fed2f2467 Fix report column labels on client side. 2019-09-04 07:49:37 -07:00
Ron Rennick 24d3104eca fix merge conflicts 2019-09-03 14:08:02 -03:00
Jeff Stieler 079748cbb2 Remove "filter" from the report charts filter names. 2019-08-28 07:55:55 -07:00
Jeff Stieler c795fb0e09 Allow filters and advanced filters to be added to reports without them. 2019-08-27 12:33:31 -07:00
Ron Rennick 9d2d085aee handle offset attribute and children 2019-08-23 15:34:44 -03:00
Jeff Stieler 7a28fbc0ff Add filters for all report filter configs. 2019-08-23 09:41:42 -07:00
Ron Rennick dbf6b54fd0 Merge pull request woocommerce/woocommerce-admin#2812 from cojennin/fix/2745-csv-coupons
Orders report now shows coupons in Coupon(s) column
2019-08-20 11:18:33 -03:00
Connor Jennings d44af04add Update client/analytics/report/orders/table.js
Co-Authored-By: Joshua T Flowers <joshuatf@gmail.com>
2019-08-20 09:15:55 -04:00
Ron Rennick 17c66a79a5 Merge branch 'master' into fix/2243 2019-08-20 10:04:10 -03:00
Jeff Stieler 6a4616765d Merge pull request woocommerce/woocommerce-admin#2806 from woocommerce/fix/report-column-visibility
Fix bug with checking user preferences for report column visibility.
2019-08-19 10:18:35 -07:00
Connor Jennings 68a8012f57 CSV download of Orders now shows coupons in Coupon(s) column 2019-08-19 12:45:57 -04:00
Ron Rennick 1517f865e1 convert scroll functionality to a component 2019-08-19 03:18:40 -03:00
Jeff Stieler 974566ea0c Fix bug with checking user preferences for report column visibility. 2019-08-16 13:06:19 -07:00
Jeff Stieler 4f4ab5e076 Pass "show data picker" prop to underlying component in ReportFilters.
Fixes errant date picker on the Customers Report.
2019-08-16 10:04:42 -07:00
Ron Rennick d2b48f0fcd scroll import action to import section of settings page 2019-08-14 14:35:28 -03:00
Ron Rennick 833cc7a1c2 convert zero last active date to null in customer query 2019-08-07 16:12:47 -03:00
Paul Sealock d98eceffc7 Revert "Revert "Update to new Snackbar component and notice store"" (https://github.com/woocommerce/woocommerce-admin/pull/2643)
* Revert "Revert "Update to new Snackbar component and notice store""

* Update uploader component to use createNotice

* Bump required WP version to 5.2

* Update required PHP and WP versions in plugin header
2019-07-23 11:26:46 +08:00
Jeff Stieler 69245c848b Merge pull request woocommerce/woocommerce-admin#2638 from woocommerce/add/2605-tracks-priority-3
Add priority 3 Tracks events
2019-07-16 09:10:11 -06:00
Albert Juhé Lluveras f392b5588d Replace 'stringifyQuery' with 'addQueryArgs' (https://github.com/woocommerce/woocommerce-admin/pull/2655) 2019-07-16 10:56:24 +02:00
Jeff Stieler 562a1a231d Send tracks event when historical data is deleted. 2019-07-12 11:46:38 -06:00
Jeff Stieler e5424fdd4d Send a tracks event when analytics settings are reset to defaults. 2019-07-12 11:46:38 -06:00
Jeff Stieler 280542255f Send a track event when analytics settings are saved. 2019-07-12 11:46:37 -06:00
Jeff Stieler 1da8aba8e8 Send a tracks event for report table pagination actions. 2019-07-12 11:46:37 -06:00
Jeff Stieler ea6116592e Merge branch 'master' into add/2604-tracks-priority-2 2019-07-12 11:34:50 -06:00
Jeff Stieler 34e91de4ce Merge pull request woocommerce/woocommerce-admin#2637 from woocommerce/fix/report-table-pagination
Fix "page" parameter collision between routing and table pagination.
2019-07-11 17:23:31 -06:00
Jeff Stieler b92bef4941 Fix "page" parameter collision between routing and table pagination. 2019-07-11 14:18:16 -06:00
Timmy Crawford f4735658d7 Revert "Update to new Snackbar component and notice store (https://github.com/woocommerce/woocommerce-admin/pull/2596)"
This reverts commit 980ff6fa71.
2019-07-10 09:58:51 -07:00
Jeff Stieler 7a7283dffa Send a tracks event when the report table filter search is used. 2019-07-10 08:37:02 -06:00
Jeff Stieler ce731b958a Send tracks event when advanced filter match type is changed. 2019-07-09 16:45:31 -06:00
Jeff Stieler a13487265c Send tracks event when table sorting is changed. 2019-07-09 14:38:53 -06:00
Jeff Stieler f7c48e6738 Send tracks event when report table columns are toggled. 2019-07-09 13:55:51 -06:00
Ron Rennick c31d5eeace Merge pull request woocommerce/woocommerce-admin#2612 from woocommerce/fix/2427
exclude old WC auto-draft orders from import
2019-07-09 13:05:36 -03:00
Ron Rennick b41b5bad0a change order import label to Orders and Refunds 2019-07-09 09:53:41 -03:00
Paul Sealock 314ed6da56 Tracks: Fix Link onclick 2019-07-09 07:51:20 +12:00
Joshua T Flowers 980ff6fa71 Update to new Snackbar component and notice store (https://github.com/woocommerce/woocommerce-admin/pull/2596)
* Add new wordpress/components version and fix dependencies

* Add in snackbar styling and gutenberg variables

* Convert all existing notice actions to wordpress/notices

* Fix linting errors

* Add package.lock changes

* Update search list control snapshots with new attributes
2019-07-08 12:10:34 +08:00
Timmy Crawford 799d0266b1 ReportTable: Add back in ids array generation. (https://github.com/woocommerce/woocommerce-admin/pull/2571) 2019-07-05 07:12:32 -07:00
Timmy Crawford 995f26250e Settings: Fix wsod when no actionable statuses are set. (https://github.com/woocommerce/woocommerce-admin/pull/2577)
* Fix wsod when no actionable statuses are set.

* Updates per feedback.
2019-07-05 07:12:03 -07:00
Daniel Rey López 08417da553 Allow each page to specify their breadcrumbs without having to render the Header component (https://github.com/woocommerce/woocommerce-admin/pull/2491)
* Simplify Header rendering, remove the use of react-slot-fill

* Remove the useless "/analytics" route

* Move all the <Header> renders to the new, declarative way of specifying breadcrumbs

* Re-render the Layout when a report is added using the REPORTS_FILTER, since that affects the breadcrumbs output

* Fix the base breadcrumb link and breadcrumbs on embedded pages

* Expanded Layout.propTypes to specify the breadcrumbs' shape
2019-07-05 09:15:49 +01:00
Timmy Crawford aaab16086d Header: Adjust sizes at all breakpoints (https://github.com/woocommerce/woocommerce-admin/pull/2562)
* Adjust activity panel sizes.

* one header size to rule them all.
2019-07-04 08:58:08 -07:00
Jeff Stieler 81a71e608f Merge pull request woocommerce/woocommerce-admin#2561 from woocommerce/fix/2448-remove-learn-more-link
Remove placeholder "learn more" link from excluded status setting.
2019-07-03 08:43:27 -06:00
Paul Sealock 7f898194b4 Tracks: add events to chart and table 2019-07-03 11:42:06 +12:00
Timmy Crawford 1814741014 Settings: Better structure to settings page, and protect form changes (https://github.com/woocommerce/woocommerce-admin/pull/2544)
* Add section header for historical import.

* Add alert on unsaved changes.

* The glass is half full. Therefore my state change should be too.

* Update button text.
2019-07-02 13:50:59 -07:00
Jeff Stieler 564b618f62 Remove placeholder "learn more" link from excluded status setting. 2019-07-02 13:42:29 -06:00
Paul Sealock 123af97b1c Merge pull request woocommerce/woocommerce-admin#2525 from woocommerce/add/filters-tracks
Advanced Filters: Add Tracks events
2019-07-01 11:05:59 +12:00
Jeff Stieler 35d763fa8c Merge pull request woocommerce/woocommerce-admin#2463 from KZeni/patch-2
Add State alongside City (and other customer info).
2019-06-28 12:24:25 -06:00
Kurt Zenisek 29c5098304 Swapped out postal_code for postcode to fix a bug 2019-06-28 13:15:50 -05:00
Kurt Zenisek c2b255360d Renamed "State" label to "Region" 2019-06-28 11:41:22 -05:00
Paul Sealock e32b5560c0 Advanced Filters: Add Tracks events 2019-06-28 12:34:41 +12:00
Paul Sealock 68c8bfedd9 Table extension: fix page error and jsDoc 2019-06-26 10:28:32 +12:00
Paul Sealock 68a95f8a83 Report Tables: extend columns 2019-06-20 20:03:56 +12:00
Kurt Zenisek 228acaf09e Added state alongside city & other info, and made location info sortable for convenient grouping of data at a glance.
I figured there's no reason you couldn't sort by the location data just so you can group them together (ex. quickly see how many are from a specific state at a glance rather than having it spread out & not having a means to group them together from this view.)
2019-06-19 17:15:58 -05:00
Paul Sealock dbd536c7a3 Settings: Add default date 2019-06-12 11:40:21 +12:00
Albert Juhé Lluveras 5d01cee56c Add progress bars to Historical Data Import screen (https://github.com/woocommerce/woocommerce-admin/pull/2312)
* Hook up import/status endpoint to Historical Data Import screen

* Fix PHP tests

* Add speak message when the import is complete

* Several fixes

* Cleanup

* Update progress bars every 3 seconds and bugfixes

* Rename ongoingImport to activeImport

* Use timestamp to identify queries

* Use timestamps for historical data state

* Add 'initializing' status

* Cleanup

* Pass less props around

* Refactor getStatus

* Set stop timestamp on request error

* Typo
2019-06-11 14:47:53 +02:00
Albert Juhé Lluveras 3123c4e047 Fix wrong average numbers in chart legends (https://github.com/woocommerce/woocommerce-admin/pull/2352)
* Fix wrong average numbers in chart legends

* Dashboard Extension example: update legend totals

* Rename 'totals' to 'legendTotals'

* Make sure legendTotals includes key property
2019-06-11 14:31:53 +02:00
Mike Jolley 3bd945511a Merge pull request woocommerce/woocommerce-admin#2191 from woocommerce/fix/low-stock-handling
Low stock handling inconsistencies with WooCommerce 3.6+
2019-06-06 12:15:46 +02:00
Paul Sealock 39d9ed38ed Merge pull request woocommerce/woocommerce-admin#2369 from shoheitanaka/patch-2
Double space at 191 row
2019-06-06 10:13:16 +02:00
Shohei Tanaka 85bd2ce168 Double space at 191 row
I find double space, like misspelling.
2019-06-06 15:18:33 +09:00
Shohei Tanaka fccf1f6156 Misspelling at update config.jp
This sentence is order, but older.
2019-06-06 14:54:28 +09:00
Joshua T Flowers 72206d296c Update settings wc-api to accept multiple setting groups (https://github.com/woocommerce/woocommerce-admin/pull/2293)
* Allow getSettings to read settings from any group

* Change updateSettings to accept object with multiple setting groups
2019-05-24 15:22:21 +08:00
Joshua T Flowers 633177bdea Update Card component to use Muriel design (https://github.com/woocommerce/woocommerce-admin/pull/2252)
* Use Muriel card styling and override card styles in reports

* Add card description prop

* Add isInactive prop and styling to card component
2019-05-22 16:38:25 +08:00
Albert Juhé Lluveras a382fd6143 Hook up import/totals endpoint to Historical Data Import screen (https://github.com/woocommerce/woocommerce-admin/pull/2208)
* Hook up import/totals endpoint to Historical Data Import screen

* Remove getImportTotalsError and isGetImportTotalsRequesting selectors which were not used

* Remove duplicate style import

* Fix RTL displays
2019-05-20 22:50:25 +02:00
Paul Sealock 34aa71cfbb Dashboard Charts: simplify data 2019-05-21 08:09:49 +12:00
Joshua T Flowers 1d978224eb Drop 'sold' from 'products sold' in products report (https://github.com/woocommerce/woocommerce-admin/pull/2240) 2019-05-16 13:05:55 +08:00
Joshua T Flowers c87ab4eed7 Update how refunds are displayed in tables (https://github.com/woocommerce/woocommerce-admin/pull/2102)
* Add customer functions to order and refund classes

* Use parent order for refund order number

* Add renderCurrency method to format negative currencies

* Allow negative number of items for refund fields in database
2019-05-16 13:04:37 +08:00
Albert Juhé Lluveras 54a09ab232 Replace Rebuild reports settings with Import Historical Data (https://github.com/woocommerce/woocommerce-admin/pull/2198)
* Hide progress bars and status from Import Historical Data screen

* Remove Rebuild Reports Sections from Settings

* Add Delete Imported Data button to the default actions

* Unify @todo comments
2019-05-10 11:34:03 +02:00
Joshua T Flowers c6a6e737c4 Add refund filtering to order reports (https://github.com/woocommerce/woocommerce-admin/pull/2179)
* Add customer functions to order and refund classes

* Extract shared order and refund methods to trait

* Add refund filter to advanced filters in orders report

* Filter refund types in orders data store

* Extract refunds subquery to parent report data store method

* Add refund subquery filtering to order stats data store

* Add tests around refund type filtering

* Change the default option for the refunds filter
2019-05-10 14:56:57 +08:00
Ron Rennick 2cd44376de Merge pull request woocommerce/woocommerce-admin#2150 from woocommerce/add/report-filter-default-value
add a defaultValue parameter to the ReportFilters, ReportChart component
2019-05-09 09:39:16 -03:00
Albert Juhé Lluveras 77ff3ea5cf Hook up API Historical Data screen to API endpoints (https://github.com/woocommerce/woocommerce-admin/pull/2177)
* Hook up API Historical Data screen to API endpoints

* Avoid making an unnecessary Math.abs()
2019-05-09 11:11:58 +02:00
Mike Jolley 196543ef7f Render stock status as 'low' on stock report 2019-05-08 15:25:46 +01:00
Paul Sealock ee895e0f77 Check for config.defaultValue in Report Chart 2019-05-08 08:46:58 +12:00
Albert Juhé Lluveras 46d3be23dd Add Historical Data Import Screen (https://github.com/woocommerce/woocommerce-admin/pull/2073)
* Add Historical Data Import Screen

* Fix date picker not being accessible

* Cleanup

* Fix period selector typo

Co-Authored-By: Aljullu <aljullu@gmail.com>

* Move state to props

* Add filter to status labels

* Get rid of 'step' state property

* Format 'importDate' as YYYY-MM-DD

* Minor improvements

* Hardcode control height

* Use dateValidationMessages when possible

* Update imported all data actions

* Update filter name
2019-05-07 09:18:48 +02:00
Joshua T Flowers 0ed477fc3c Fix customer type filter param in orders report (https://github.com/woocommerce/woocommerce-admin/pull/2169) 2019-05-07 13:17:43 +08:00
Jeff Stieler a36e3cd024 Merge pull request woocommerce/woocommerce-admin#2034 from woocommerce/add/1850-import-endpoint
Add import endpoint and controller
2019-05-01 13:29:00 -06:00
Albert Juhé Lluveras 1c67b40d76 Scroll to top of the table when navigating table pages (https://github.com/woocommerce/woocommerce-admin/pull/2051)
* Scroll to top of the table when navigating table pages

* Cleanup

* Avoid using scroll-padding-top

* Add space between the table top and the scroll point

* Only call  if the page is different

* Move focus to the top of the table when switching pages

* Use CSS variables in the Activity Panel and breadcrumbs CSS (https://github.com/woocommerce/woocommerce-admin/pull/2096)

* Use CSS variables in the Activity Panel and breadcrumbs CSS

* Cleanup

* Focus on table element when navigating pages
2019-04-30 11:43:55 +02:00
Ron Rennick e409ef943a update analytics report readme 2019-04-29 08:58:33 -03:00
Hardip Parmar e39a8e6e35 Remove CSV Download button when no data is available (https://github.com/woocommerce/woocommerce-admin/pull/2084) 2019-04-22 11:15:01 +08:00
Paul Sealock 8ff24a9a7e Example Extensions: create build environment 2019-04-17 14:01:56 +12:00
Joshua Flowers 780c9da3d2 Hook up regenerate UI setting to new import endpoint 2019-04-12 16:50:42 +08:00
Joshua T Flowers eb0b137020 Hook up leaderboards endpoint to dashboard (https://github.com/woocommerce/woocommerce-admin/pull/2004)
* Add allowed leaderboards endpoint to prefetch list

* Hook up leadboards endpoint to dashboard

* Skip data fetch for leaderboard if per page is less than 1

* Add tests to check for rendered html display
2019-04-11 10:53:05 +08:00
Albert Juhé Lluveras 458f3ed065 Fix SKU sorting in the Variations report when a comparison is active (https://github.com/woocommerce/woocommerce-admin/pull/1952)
* make is sortable true.

* Variations endpoint: Fix sorting by SKU when there is an active comparison

* Cleanup

* Extract FROM parameter logic to 'get_from_sql_params'

* Remove unnecessary 'get_order_by_sql_params' from Products and Variations data stores
2019-04-01 10:09:45 +02:00
Joshua T Flowers 42ddfc0108 Add coupons count to data store and hook up to summary numbers in orders report (https://github.com/woocommerce/woocommerce-admin/pull/1912)
* Change coupons sum to distinct coupon count in REST API

* Hook up unique coupon count to orders summary numbers

* Add coupons count to order segmenting

* Add coupons count to expected stats in order test and revenue tests
2019-04-01 10:16:57 +08:00
ronakganatra9 3cddc714c6 issue fix woocommerce/woocommerce-admin#1801 SKU filter issue fixed. (https://github.com/woocommerce/woocommerce-admin/pull/1837)
* issue fix woocommerce/woocommerce-admin#1801 SKU filter issue fixed.

* make is sortable true.

* phpcs error fix.

* Fix PHPCS errors and warnings.

* Fix PHPCS errors and warnings.

* Update client/analytics/report/products/table-variations.js

Co-Authored-By: ronakganatra9 <ronakganatra9@gmail.com>

* Update includes/data-stores/class-wc-admin-reports-variations-data-store.php

Co-Authored-By: ronakganatra9 <ronakganatra9@gmail.com>

* changed postmeta.meta_value to meta_value
2019-03-31 20:53:48 +02:00
Albert Juhé Lluveras 6862d05e2f Update packages with vulnerabilities (https://github.com/woocommerce/woocommerce-admin/pull/1913)
* Update packages with vulnerabilities

* Fix tests

* Replace require.requireActual with jest.requireActual
2019-03-26 12:31:57 +01:00
Paul Sealock b32e8afeeb Merge pull request woocommerce/woocommerce-admin#1873 from woocommerce/refactor/config-getQuery
Refactor getFilterQuery by explicitly passing down configs
2019-03-25 13:12:53 +13:00
Paul Sealock b29b232a46 pass in filters 2019-03-25 13:03:53 +13:00
Albert Juhé Lluveras a7af5e4603 Create DEFAULT_ACTIONABLE_STATUSES constant (https://github.com/woocommerce/woocommerce-admin/pull/1867) 2019-03-22 09:48:20 +01:00
Albert Juhé Lluveras 9038bdfdae Table: update columns visibility on headers change (https://github.com/woocommerce/woocommerce-admin/pull/1846)
* Typos

* Table: update columns visibility on headers change

* Make sure initial user pref columns are loaded in all reports

* Return early filterShownHeaders when hiddenKeys is an empty array

* Undo 'headers', 'prevHeaders' order switch
2019-03-21 11:35:00 +01:00
Joshua T Flowers 3f2dd07a53 Hide stock panel and menu if stock management is disabled (https://github.com/woocommerce/woocommerce-admin/pull/1841)
* Add manage stock setting to global wcSettings

* Hide Stock tab from activity panel if stock management is disabled

* Hide Stock report if stock management is disabled

* Prevent stock page from loading if disabled and visited directly

* Hide stock status and quantity columns when disabled
2019-03-21 13:42:07 +08:00
Albert Juhé Lluveras 641d0b766f CSSLint: Remove whitespace at the end of line (https://github.com/woocommerce/woocommerce-admin/pull/1845) 2019-03-20 00:34:22 +01:00
ronakganatra9 7e8f5fa53b Fixwoocommerce/woocommerce-admin#1768 Added a Margin of 40 pixel for better user interface, on mobile devices. (https://github.com/woocommerce/woocommerce-admin/pull/1842)
* Added a Margin of 40 pixel for better user interface, on mobile devices.

* applied suggestion and commited changes for all devices.

* applied suggestion and removed extra tab.
2019-03-19 14:22:40 +01:00
Paul Sealock 6d5484aa87 Fix table links to internal reports 2019-03-19 14:27:31 +13:00
Joshua T Flowers d416f78e9f Update/variations search method (https://github.com/woocommerce/woocommerce-admin/pull/1792)
* Add product search option REST API

* Remove product_name search in favor of sku and name searching

* Search by product search term instead of generic search in autocompleter

* Add product search option REST API

* Override existing search param instead of new param

* Remove product_name search in favor of sku and name searching

* Add product search param to variations controller

* Add group by to prevent duplicate variations in response

* Use product_search in variation autocompleter

* Trim whitespace in product_search query

* Change variation search placeholder

* Override search param instead of using new product_search param

* Add baseSearchQuery to prevent losing single_product filter in variations report

* Unset s param instead of setting to false
2019-03-18 12:23:08 +08:00
Joshua T Flowers b1dd517eb6 Add single customer filter and hook up customer link (https://github.com/woocommerce/woocommerce-admin/pull/1798)
* Add a single customer filter to the customers report

* Hook up activity panel orders customer link to customer report

* Use customer name for label instead of username
2019-03-18 10:39:54 +08:00
Albert Juhé Lluveras e6cf40e3f0 Allow sorting by tax_code in Taxes report (https://github.com/woocommerce/woocommerce-admin/pull/1812) 2019-03-15 21:44:03 +01:00
Joshua T Flowers df5f001140 Update compare button help text (https://github.com/woocommerce/woocommerce-admin/pull/1796) 2019-03-15 09:00:48 +08:00
Jeff Stieler bfe5a75e98 Update text domain. (https://github.com/woocommerce/woocommerce-admin/pull/1795)
* Translation call text domain change from “wc-admin” to “woocommerce-admin”.

* Fix .pot file generation.

* Fix errantly closed array item in /revenue/stats controller.

* Rename plugin zip, main file, and repo name to "woocommerce-admin".
2019-03-13 11:14:02 -06:00
Albert Juhé Lluveras 1bbf79c105 Avoid useless Chart re-renders and clean-up component state (https://github.com/woocommerce/woocommerce-admin/pull/1780)
* Improve Chart rendering performance

* Avoid reassigning yFormat prop in Chart

* Update focused keys on legend toggle

* Use selectionLimit constant instead of a hardcoded value

* Minor improvements
2019-03-13 11:38:43 +01:00